Skip to content

Commit 88ddcde

Browse files
authored
Merge branch 'main' into bump-to-v0.351.0
2 parents f4ac4fe + c1816e1 commit 88ddcde

4 files changed

Lines changed: 22 additions & 5 deletions

File tree

gradle/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ FROM ghcr.io/dependabot/dependabot-updater-core
33

44
# Install Java
55
RUN apt-get update && apt-get install -y --no-install-recommends \
6-
openjdk-21-jdk \
6+
openjdk-21-jdk-headless \
77
ca-certificates-java \
88
wget \
99
&& rm -rf /var/lib/apt/lists/*

maven/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ FROM maven:3.9.9 as maven
55
FROM ghcr.io/dependabot/dependabot-updater-core
66

77
RUN apt-get update && apt-get install -y --no-install-recommends \
8-
openjdk-21-jdk \
8+
openjdk-21-jdk-headless \
99
ca-certificates-java \
1010
&& rm -rf /var/lib/apt/lists/*
1111

@@ -18,7 +18,7 @@ RUN ln -s ${MAVEN_HOME}/bin/mvn /usr/bin/mvn
1818
USER dependabot
1919

2020
ENV PATH=$JAVA_HOME/bin:$PATH
21-
ENV MAVEN_CONFIG "$DEPENDABOT_HOME/.m2"
21+
ENV MAVEN_ARGS="-Dmaven.repo.local=$DEPENDABOT_HOME/.m2"
2222

2323
COPY --chown=dependabot:dependabot --parents maven common $DEPENDABOT_HOME/
2424
COPY --chown=dependabot:dependabot updater $DEPENDABOT_HOME/dependabot-updater

npm_and_yarn/lib/dependabot/npm_and_yarn/constraint_helper.rb

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -261,9 +261,16 @@ def self.to_ruby_constraint_with_version(constraint, dependabot_versions = [])
261261

262262
full_version = Regexp.last_match(1)
263263

264-
# Normalize version: if full_version does not have patch version, add ".0"
264+
# Normalize version: ensure it has major.minor.patch format
265265
version_parts = T.must(full_version).split(".")
266-
full_version = "#{full_version}.0" if version_parts.length == 2
266+
full_version = case version_parts.length
267+
when 1
268+
"#{full_version}.0.0" # major only -> major.0.0
269+
when 2
270+
"#{full_version}.0" # major.minor -> major.minor.0
271+
else
272+
full_version # already major.minor.patch
273+
end
267274

268275
_, major, minor = version_components(full_version)
269276
return nil if major.nil?

npm_and_yarn/spec/dependabot/npm_and_yarn/package_manager_helper_spec.rb

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,16 @@
141141
end
142142
end
143143

144+
context "with engines field for package manager with '^' constraint and missing minor/patch version" do
145+
let(:lockfiles) { {} }
146+
let(:package_json) { { "engines" => { "npm" => "^10" } } }
147+
148+
it "returns a NpmPackageManager instance from engines field" do
149+
expect(helper.package_manager).to be_a(Dependabot::NpmAndYarn::NpmPackageManager)
150+
expect(helper.package_manager.detected_version).to eq("10")
151+
end
152+
end
153+
144154
context "with engines field for npm >=11.0.0" do
145155
let(:lockfiles) { {} }
146156
let(:package_json) { { "engines" => { "npm" => ">=11.0.0" } } }

0 commit comments

Comments
 (0)