Fix tests code style and update workflows (#102)

Author: antonkomarev

.github/workflows/tests.yml

@@ -46,10 +46,10 @@ jobs:
 
     steps:
       - name: Checkout code
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
 
       - name: Cache dependencies
-        uses: actions/cache@v2
+        uses: actions/cache@v4
         with:
           path: ~/.composer/cache/files
           key: dependencies-laravel-${{ matrix.laravel }}-php-${{ matrix.php }}-composer-${{ hashFiles('composer.json') }}

tests/AbstractTestCase.php

@@ -21,6 +21,8 @@
 
 abstract class AbstractTestCase extends Orchestra
 {
+    public static $latestResponse;
+
     /**
      * Actions to be performed on PHPUnit start.
      *

tests/Unit/Events/ModelWasBannedTest.php

@@ -20,8 +20,7 @@
 
 final class ModelWasBannedTest extends AbstractTestCase
 {
-    /** @test */
-    public function it_can_fire_event_on_helper_call(): void
+    public function test_it_can_fire_event_on_helper_call(): void
     {
         Event::fake(ModelWasBanned::class);
         $entity = User::factory()->create();
@@ -31,8 +30,7 @@ public function it_can_fire_event_on_helper_call(): void
         Event::assertDispatched(ModelWasBanned::class);
     }
 
-    /** @test */
-    public function it_can_fire_event_on_relation_create(): void
+    public function test_it_can_fire_event_on_relation_create(): void
     {
         Event::fake(ModelWasBanned::class);
         $entity = User::factory()->create();

tests/Unit/Events/ModelWasUnbannedTest.php

@@ -20,8 +20,7 @@
 
 final class ModelWasUnbannedTest extends AbstractTestCase
 {
-    /** @test */
-    public function it_can_fire_event_on_helper_call(): void
+    public function test_it_can_fire_event_on_helper_call(): void
     {
         Event::fake(ModelWasUnbanned::class);
         $ban = Ban::factory()->create();
@@ -31,8 +30,7 @@ public function it_can_fire_event_on_helper_call(): void
         Event::assertDispatched(ModelWasUnbanned::class);
     }
 
-    /** @test */
-    public function it_can_fire_event_on_relation_delete(): void
+    public function test_it_can_fire_event_on_relation_delete(): void
     {
         Event::fake(ModelWasUnbanned::class);
         $ban = Ban::factory()->create();

tests/Unit/Models/BanTest.php

@@ -20,8 +20,7 @@
 
 final class BanTest extends AbstractTestCase
 {
-    /** @test */
-    public function it_can_fill_comment(): void
+    public function test_it_can_fill_comment(): void
     {
         $ban = new Ban([
             'comment' => 'Enjoy your ban!',
@@ -30,8 +29,7 @@ public function it_can_fill_comment(): void
         $this->assertSame('Enjoy your ban!', $ban->comment);
     }
 
-    /** @test */
-    public function it_can_fill_expired_at(): void
+    public function test_it_can_fill_expired_at(): void
     {
         $expiredAt = Carbon::now()->toDateTimeString();
 
@@ -42,8 +40,7 @@ public function it_can_fill_expired_at(): void
         $this->assertEquals($expiredAt, $ban->getAttribute('expired_at'));
     }
 
-    /** @test */
-    public function it_can_fill_created_by_type(): void
+    public function test_it_can_fill_created_by_type(): void
     {
         $ban = new Ban([
             'created_by_type' => 'TestType',
@@ -52,8 +49,7 @@ public function it_can_fill_created_by_type(): void
         $this->assertSame('TestType', $ban->getAttribute('created_by_type'));
     }
 
-    /** @test */
-    public function it_can_fill_created_by_id(): void
+    public function test_it_can_fill_created_by_id(): void
     {
         $ban = new Ban([
             'created_by_id' => '4',
@@ -62,8 +58,7 @@ public function it_can_fill_created_by_id(): void
         $this->assertSame('4', $ban->getAttribute('created_by_id'));
     }
 
-    /** @test */
-    public function it_casts_expired_at(): void
+    public function test_it_casts_expired_at(): void
     {
         $ban = new Ban([
             'expired_at' => '2018-03-28 00:00:00',
@@ -72,8 +67,7 @@ public function it_casts_expired_at(): void
         $this->assertInstanceOf(Carbon::class, $ban->getAttribute('expired_at'));
     }
 
-    /** @test */
-    public function it_casts_deleted_at(): void
+    public function test_it_casts_deleted_at(): void
     {
         $ban = Ban::factory()->create([
             'deleted_at' => '2018-03-28 00:00:00',
@@ -82,8 +76,7 @@ public function it_casts_deleted_at(): void
         $this->assertInstanceOf(Carbon::class, $ban->deleted_at);
     }
 
-    /** @test */
-    public function it_not_modify_null_expired_at(): void
+    public function test_it_not_modify_null_expired_at(): void
     {
         $ban = new Ban([
             'expired_at' => null,
@@ -92,8 +85,7 @@ public function it_not_modify_null_expired_at(): void
         $this->assertNull($ban->getAttribute('expired_at'));
     }
 
-    /** @test */
-    public function it_can_has_ban_creator(): void
+    public function test_it_can_has_ban_creator(): void
     {
         $bannedBy = User::factory()->create();
 
@@ -105,8 +97,7 @@ public function it_can_has_ban_creator(): void
         $this->assertInstanceOf(User::class, $ban->createdBy);
     }
 
-    /** @test */
-    public function it_can_set_custom_ban_creator(): void
+    public function test_it_can_set_custom_ban_creator(): void
     {
         $bannable = User::factory()->create();
         $bannedBy = User::factory()->create();
@@ -119,8 +110,7 @@ public function it_can_set_custom_ban_creator(): void
         $this->assertTrue($ban->createdBy->is($bannedBy));
     }
 
-    /** @test */
-    public function it_not_overwrite_ban_creator_with_auth_user_if_custom_value_is_provided(): void
+    public function test_it_not_overwrite_ban_creator_with_auth_user_if_custom_value_is_provided(): void
     {
         $bannable = User::factory()->create();
         $bannedBy = User::factory()->create();
@@ -136,8 +126,7 @@ public function it_not_overwrite_ban_creator_with_auth_user_if_custom_value_is_p
         $this->assertTrue($ban->createdBy->is($bannedBy));
     }
 
-    /** @test */
-    public function it_can_make_model_with_expire_carbon_date(): void
+    public function test_it_can_make_model_with_expire_carbon_date(): void
     {
         $expiredAt = Carbon::now();
 
@@ -148,8 +137,7 @@ public function it_can_make_model_with_expire_carbon_date(): void
         $this->assertEquals($expiredAt, $ban->getAttribute('expired_at'));
     }
 
-    /** @test */
-    public function it_can_make_model_with_expire_string_date(): void
+    public function test_it_can_make_model_with_expire_string_date(): void
     {
         $ban = new Ban([
             'expired_at' => '2086-03-28 00:00:00',
@@ -158,8 +146,7 @@ public function it_can_make_model_with_expire_string_date(): void
         $this->assertEquals('2086-03-28 00:00:00', $ban->getAttribute('expired_at'));
     }
 
-    /** @test */
-    public function it_can_make_model_with_expire_relative_date(): void
+    public function test_it_can_make_model_with_expire_relative_date(): void
     {
         $ban = new Ban([
             'expired_at' => '+1 year',
@@ -172,8 +159,7 @@ public function it_can_make_model_with_expire_relative_date(): void
         );
     }
 
-    /** @test */
-    public function it_can_has_bannable_model(): void
+    public function test_it_can_has_bannable_model(): void
     {
         $user = User::factory()->create();
 
@@ -185,8 +171,7 @@ public function it_can_has_bannable_model(): void
         $this->assertInstanceOf(User::class, $ban->bannable);
     }
 
-    /** @test */
-    public function it_can_scope_bannable_models(): void
+    public function test_it_can_scope_bannable_models(): void
     {
         $user1 = User::factory()->create();
         Ban::factory()->count(4)->create([
@@ -204,8 +189,7 @@ public function it_can_scope_bannable_models(): void
         $this->assertCount(4, $bannableModels);
     }
 
-    /** @test */
-    public function it_can_check_if_ban_is_permanent(): void
+    public function test_it_can_check_if_ban_is_permanent(): void
     {
         $permanentBan = new Ban();
         $temporaryBan = new Ban([
@@ -216,8 +200,7 @@ public function it_can_check_if_ban_is_permanent(): void
         $this->assertFalse($temporaryBan->isPermanent());
     }
 
-    /** @test */
-    public function it_can_check_if_ban_is_temporary(): void
+    public function test_it_can_check_if_ban_is_temporary(): void
     {
         $permanentBan = new Ban();
         $temporaryBan = new Ban([
@@ -228,8 +211,7 @@ public function it_can_check_if_ban_is_temporary(): void
         $this->assertTrue($temporaryBan->isTemporary());
     }
 
-    /** @test */
-    public function it_can_check_if_ban_with_null_expired_at_is_permanent(): void
+    public function test_it_can_check_if_ban_with_null_expired_at_is_permanent(): void
     {
         $permanentBan = new Ban([
             'expired_at' => null,

tests/Unit/Observers/BanObserverTest.php

@@ -18,8 +18,7 @@
 
 final class BanObserverTest extends AbstractTestCase
 {
-    /** @test */
-    public function it_can_set_banned_flag_to_owner_model_on_create(): void
+    public function test_it_can_set_banned_flag_to_owner_model_on_create(): void
     {
         $user = User::factory()->create([
             'banned_at' => null,

tests/Unit/Scopes/BannedAtScopeTest.php

@@ -20,8 +20,7 @@
 
 final class BannedAtScopeTest extends AbstractTestCase
 {
-    /** @test */
-    public function it_can_get_all_models_by_default(): void
+    public function test_it_can_get_all_models_by_default(): void
     {
         User::factory()->count(2)->create([
             'banned_at' => Carbon::now()->subDay(),
@@ -35,8 +34,7 @@ public function it_can_get_all_models_by_default(): void
         $this->assertCount(5, $entities);
     }
 
-    /** @test */
-    public function it_can_get_models_without_banned(): void
+    public function test_it_can_get_models_without_banned(): void
     {
         User::factory()->count(2)->create([
             'banned_at' => Carbon::now()->subDay(),
@@ -50,8 +48,7 @@ public function it_can_get_models_without_banned(): void
         $this->assertCount(3, $entities);
     }
 
-    /** @test */
-    public function it_can_get_models_with_banned(): void
+    public function test_it_can_get_models_with_banned(): void
     {
         User::factory()->count(2)->create([
             'banned_at' => Carbon::now()->subDay(),
@@ -65,8 +62,7 @@ public function it_can_get_models_with_banned(): void
         $this->assertCount(5, $entities);
     }
 
-    /** @test */
-    public function it_can_get_only_banned_models(): void
+    public function test_it_can_get_only_banned_models(): void
     {
         User::factory()->count(2)->create([
             'banned_at' => Carbon::now()->subDay(),
@@ -80,8 +76,7 @@ public function it_can_get_only_banned_models(): void
         $this->assertCount(2, $entities);
     }
 
-    /** @test */
-    public function it_can_auto_apply_banned_at_default_scope(): void
+    public function test_it_can_auto_apply_banned_at_default_scope(): void
     {
         User::factory()->count(3)->create([
             'banned_at' => Carbon::now()->subDay(),

tests/Unit/Services/BanServiceTest.php

@@ -20,8 +20,7 @@
 
 final class BanServiceTest extends AbstractTestCase
 {
-    /** @test */
-    public function it_can_delete_all_expired_bans(): void
+    public function test_it_can_delete_all_expired_bans(): void
     {
         Ban::factory()->count(3)->create([
             'expired_at' => Carbon::now()->subMonth(),