libs/widget-lib/src/widgetIframeLoading.ts (1)

163-174: 💤 Low value

Consider removing the message listener in onWidgetReady.

The onRetryMessage listener (added on line 159) is only removed in cancelWidgetLoading, not in onWidgetReady. After the widget loads successfully, this listener remains attached and fires on every window message event, returning early due to the isLoaded check. While functionally harmless, it adds unnecessary overhead.

♻️ Suggested fix

     onWidgetReady() {
       isLoaded = true
       clearTimeout(loadingTimeoutID)
+      window.removeEventListener('message', onRetryMessage)
     },

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@libs/widget-lib/src/widgetIframeLoading.ts` around lines 163 - 174, The
onRetryMessage listener is only removed in cancelWidgetLoading, so after a
successful load the window 'message' listener remains attached; update the
onWidgetReady handler to also remove the listener (call
window.removeEventListener('message', onRetryMessage)) and perform the same
cleanup you do on cancel (e.g., clearTimeout(loadingTimeoutID) and optionally
call cleanUpLoadCheck()) so the listener and timers are cleared when the widget
loads successfully.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

apps/widget-configurator/src/components/VersionedCowSwapWidget/VersionedCowSwapWidget.tsx (1)

59-73: 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

Forward onLoadingError through the pinned widget path.

onLoadingError is part of widgetProps (Line 86) but gets dropped in LazyPinnedCowSwapWidget (Lines 65 and 72). That makes the callback work only for sdkVersion === 'local' and breaks preview error callback propagation for pinned versions.

Suggested fix

 function LazyPinnedCowSwapWidget({
   sdkVersion,
   params,
   provider,
   listeners,
   onReady,
+  onLoadingError,
 }: VersionedCowSwapWidgetProps & { sdkVersion: PinnedWidgetSdkVersion }): ReactNode {
   const LazyCowSwapWidget = LAZY_WIDGETS_BY_VERSION[sdkVersion]
   const legacyIframeLoadReveal = widgetSdkVersionSupportsReadyEvent(sdkVersion) ? undefined : onReady

   return (
     <Suspense fallback={null}>
       <LegacyPinnedPreviewReveal onIframeLoad={legacyIframeLoadReveal}>
-        <LazyCowSwapWidget params={params} provider={provider} listeners={listeners} onReady={onReady} />
+        <LazyCowSwapWidget
+          params={params}
+          provider={provider}
+          listeners={listeners}
+          onReady={onReady}
+          onLoadingError={onLoadingError}
+        />
       </LegacyPinnedPreviewReveal>
     </Suspense>
   )
 }

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

function LazyPinnedCowSwapWidget({
  sdkVersion,
  params,
  provider,
  listeners,
  onReady,
  onLoadingError,
}: VersionedCowSwapWidgetProps & { sdkVersion: PinnedWidgetSdkVersion }): ReactNode {
  const LazyCowSwapWidget = LAZY_WIDGETS_BY_VERSION[sdkVersion]
  const legacyIframeLoadReveal = widgetSdkVersionSupportsReadyEvent(sdkVersion) ? undefined : onReady

  return (
    <Suspense fallback={null}>
      <LegacyPinnedPreviewReveal onIframeLoad={legacyIframeLoadReveal}>
        <LazyCowSwapWidget
          params={params}
          provider={provider}
          listeners={listeners}
          onReady={onReady}
          onLoadingError={onLoadingError}
        />
      </LegacyPinnedPreviewReveal>
    </Suspense>
  )
}

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@apps/widget-configurator/src/components/VersionedCowSwapWidget/VersionedCowSwapWidget.tsx`
around lines 59 - 73, The LazyPinnedCowSwapWidget function is missing the
onLoadingError prop in its destructuring and is not forwarding it to the
LazyCowSwapWidget component. Add onLoadingError to the destructuring of
VersionedCowSwapWidgetProps in the LazyPinnedCowSwapWidget function parameters,
and then pass onLoadingError as a prop to the LazyCowSwapWidget component
alongside the existing params, provider, listeners, and onReady props. This
ensures error callbacks are properly propagated for all pinned widget versions,
not just local ones.