test: cover admin ui resource handler registration#5511
Merged
SteKoe merged 3 commits intoJul 11, 2026
Merged
Conversation
Contributor
|
Hi @amirdeljouyi, thanks for your PR! I have changed the assertions as your tests were not as meaningful as possible. Both tests only assert doesNotThrowAnyException(). This is a smoke test, not a behavior test, which is more appropriate. Nothing verifies the registered handler paths (/, /extensions/) or the configured resource locations. A regression that swaps the two handlers, drops the extension handler, or uses the wrong locations would still pass. The tests don't back up the stated intent. Again, thanks for your PR, keep on! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I added two focused tests for the UI resource handler configuration.
Impact on coverage:
AdminServerUiAutoConfiguration, including the reactive resource handlers and the servlet resource handlers.AdminServerUiAutoConfigurationincreases by 14.81%.Why:
They make sure the servlet and reactive configs can register the main UI assets and extension asset handlers with the configured locations.
I hope you find these tests useful. 😄 Please let me know if you have any questions or concerns.
Thanks,