diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index e678af9f..d3d4156e 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -107,7 +107,7 @@ jobs: - name: Upload coverage reports to Codecov uses: codecov/codecov-action@v5 if: ${{ !cancelled() }} - continue-on-error: ${{ matrix.experimental }} + continue-on-error: true with: token: ${{ secrets.CODECOV_TOKEN }} verbose: false # optional (default = false) @@ -115,7 +115,7 @@ jobs: - name: Get Cover uses: orgoro/coverage@3f13a558c5af7376496aa4848bf0224aead366ac # v3.2 if: ${{ !cancelled() }} - continue-on-error: ${{ matrix.experimental }} + continue-on-error: true with: coverageFile: coverage.xml token: ${{ secrets.GITHUB_TOKEN }} @@ -123,7 +123,7 @@ jobs: - name: Upload test results to Codecov uses: codecov/test-results-action@v1 if: ${{ !cancelled() }} - continue-on-error: ${{ matrix.experimental }} + continue-on-error: true with: token: ${{ secrets.CODECOV_TOKEN }} verbose: false # optional (default = false) diff --git a/ckanext/xloader/loader.py b/ckanext/xloader/loader.py index d48aeefd..9574dfc4 100644 --- a/ckanext/xloader/loader.py +++ b/ckanext/xloader/loader.py @@ -259,8 +259,7 @@ def split_copy_by_size(input_file, engine, logger, resource_id, headers, delimit logger.info('Completed chunked processing: %s chunks processed for file size %s bytes', chunk_count, file_size) if infile: - infile.close() - os.remove(infile.name) + cleanup_temp_file(infile) def _read_metadata(table_filepath, mimetype, logger):