Address Codacy feedback

Author: TheThouZands

src/api/java/baritone/api/utils/IInputOverrideHandler.java

@@ -39,8 +39,10 @@ default boolean isBreakingBlock(BlockPos pos) {
     }
 
     default void setBlockBreakTarget(BlockPos pos) {
+        // Optional hook for handlers that support targeted block breaking.
     }
 
     default void setBlockPlaceTarget(BlockPos pos, Direction side) {
+        // Optional hook for handlers that support targeted block placing.
     }
 }

src/launch/java/baritone/launch/mixins/MixinClientPlayerEntity.java

@@ -62,6 +62,7 @@ private void onPreUpdate(CallbackInfo ci) {
             at = @At("HEAD"),
             cancellable = true
     )
+    @SuppressWarnings({"unused", "PMD.UnusedPrivateMethod"})
     private void getViewYRot(float partialTicks, CallbackInfoReturnable<Float> cir) {
         Rotation visualRotation = this.getVisualRotation(partialTicks);
         if (visualRotation != null) {
@@ -74,6 +75,7 @@ private void getViewYRot(float partialTicks, CallbackInfoReturnable<Float> cir)
             at = @At("HEAD"),
             cancellable = true
     )
+    @SuppressWarnings({"unused", "PMD.UnusedPrivateMethod"})
     private void getViewXRot(float partialTicks, CallbackInfoReturnable<Float> cir) {
         Rotation visualRotation = this.getVisualRotation(partialTicks);
         if (visualRotation != null) {

src/main/java/baritone/behavior/LookBehavior.java

@@ -250,6 +250,7 @@ private void updateInterpolation(
             boolean restartArc,
             Target.Mode mode) {
         final int interpolationSpeed = Baritone.settings().interpolatedLookLength.value;
+        Rotation arcStart = start;
 
         if (this.interpolationArc != null && this.interpolationMode != mode) {
             this.interpolationArc = null;
@@ -259,12 +260,15 @@ private void updateInterpolation(
 
         if (this.interpolationArc != null
                 && (restartArc || this.interpolationOriginMoved(origin))) {
-            start = this.interpolationArc.getCurrentRotation();
+            arcStart = this.interpolationArc.getCurrentRotation();
             this.interpolationArc = null;
         }
 
         if (this.interpolationArc == null) {
-            this.interpolationArc = RotationArc.fromAngularSpeed(start, actual, interpolationSpeed);
+            this.interpolationArc = RotationArc.fromAngularSpeed(
+                    arcStart,
+                    actual,
+                    interpolationSpeed);
             this.interpolationMode = mode;
             this.interpolationOrigin = origin;
         }

src/main/java/baritone/utils/BlockPlaceHelper.java

@@ -38,23 +38,55 @@ public class BlockPlaceHelper {
     }
 
     public void tick(boolean rightClickRequested, BlockPos target, Direction side) {
+        if (this.isCoolingDown()) {
+            return;
+        }
+
+        BlockHitResult blockHit = this.targetedBlockHit(rightClickRequested, target, side);
+        if (blockHit == null) {
+            return;
+        }
+
+        rightClickTimer = Baritone.settings().rightClickSpeed.value - BASE_PLACE_DELAY;
+        this.tryRightClick(blockHit);
+    }
+
+    private boolean isCoolingDown() {
         if (rightClickTimer > 0) {
             rightClickTimer--;
-            return;
+            return true;
         }
+        return false;
+    }
+
+    private BlockHitResult targetedBlockHit(
+            boolean rightClickRequested,
+            BlockPos target,
+            Direction side) {
+        if (!rightClickRequested || ctx.player().isHandsBusy()) {
+            return null;
+        }
+
         HitResult mouseOver = ctx.objectMouseOver();
-        if (!rightClickRequested
-                || ctx.player().isHandsBusy()
-                || mouseOver == null
+        if (mouseOver == null
                 || mouseOver.getType() != HitResult.Type.BLOCK) {
-            return;
+            return null;
         }
+
         BlockHitResult blockHit = (BlockHitResult) mouseOver;
-        if (target != null
-                && (!blockHit.getBlockPos().equals(target) || blockHit.getDirection() != side)) {
-            return;
+        if (!this.matchesTarget(blockHit, target, side)) {
+            return null;
         }
-        rightClickTimer = Baritone.settings().rightClickSpeed.value - BASE_PLACE_DELAY;
+
+        return blockHit;
+    }
+
+    private boolean matchesTarget(BlockHitResult blockHit, BlockPos target, Direction side) {
+        return target == null
+                || (blockHit.getBlockPos().equals(target) && blockHit.getDirection() == side);
+    }
+
+    private void tryRightClick(BlockHitResult blockHit) {
         for (InteractionHand hand : InteractionHand.values()) {
             if (ctx.playerController().processRightClickBlock(
                     ctx.player(),