Conversation
…133) CI was triggering twice for PR pushes - once for push event and once for pull_request event. Remove pull_request trigger to run CI exactly once per push. The release logic is already conditional on main branch, so it will: - Run build/test on all branch pushes - Only create releases when pushed to main with feat/fix commits Changes: - Remove pull_request trigger from build.yml - Keep push trigger for all branches - Keep workflow_dispatch for manual runs - Release steps remain conditional on main branch
|
Correct approach. Removing Verify: Check that PR checks still display correctly on GitHub. Some repos need Edge case: External forks won't trigger CI on push (they can't push to your repo). If you accept external contributions, you'll need Ship it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove
pull_requesttrigger from build workflow to prevent duplicate CI runs. CI was running twice for PR pushes (once for push, once for pull_request event).Problem
When pushing to a PR branch:
Result: Same commit tested twice, wasting CI resources
Solution
Remove
pull_requesttrigger, keep onlypushtrigger for all branches.Behavior After Fix
Changes
pull_request:from workflow triggerspush: branches: ['**']for all branchesworkflow_dispatch:for manual runsgithub.ref == 'refs/heads/main'Fixes #133