Add Version parameter to Finish-Release.ps1 for versioned file naming

Author: electroly

CONTRIBUTING.md

@@ -72,7 +72,7 @@ In AWS, a `c5a.xlarge` instance running Windows Server 2022 will do.
   1. Extract the corresponding Phase 1 artifact to your local workspace in `src/SqlNotebook/bin/publish/`.
   2. Run Phase 2 with automated code signing:
      ```powershell
-     powershell.exe ps1/Finish-Release.ps1 -Platform <platform> -SigntoolPath "<full path to signtool.exe>" -SigntoolSha1 "<SHA1 hash>"
+     powershell.exe ps1/Finish-Release.ps1 -Platform <platform> -SigntoolPath "<full path to signtool.exe>" -SigntoolSha1 "<SHA1 hash>" -Version "<version>"
      ```
      You will be prompted to enter your HSM password when signtool runs for both the executable and MSI.
   3. The script will automatically:
@@ -81,15 +81,15 @@ In AWS, a `c5a.xlarge` instance running Windows Server 2022 will do.
      - Generate the MSI installer
      - Sign the MSI installer
      - Create properly named output files in `release-output/`:
-       - `SqlNotebook-<platform>.zip`
-       - `SqlNotebook-<platform>.msi`
+       - `SqlNotebook-<platform>-<version>.zip`
+       - `SqlNotebook-<platform>-<version>.msi`
 
 - Test the zip and MSI files from the `release-output/` directory.
 - Create release on GitHub, upload the four files from `release-output/`:
-    - `SqlNotebook-x64.zip`
-    - `SqlNotebook-x64.msi`
-    - `SqlNotebook-arm64.zip`
-    - `SqlNotebook-arm64.msi`
+    - `SqlNotebook-x64-<version>.zip`
+    - `SqlNotebook-x64-<version>.msi`
+    - `SqlNotebook-arm64-<version>.zip`
+    - `SqlNotebook-arm64-<version>.msi`
 - Release settings:
     - Let GitHub create a new tag, name it `vX.X.X`.
     - Set release title to `vX.X.X`.

project/TASKS.md

@@ -32,5 +32,5 @@
             - [x] SqlNotebook-x64.msi (WiX installer)
             - [x] SqlNotebook-x64.zip (portable zip)
         - [x] Update `CONTRIBUTING.md` accordingly. The developer will have to enter their password interactively when prompted by `signtool`, but your script will take care of the rest. Then the developer will attach those four files to the GitHub release and proceed with the rest of the release process.
-    - [ ] I want the final release files to be named like `SqlNotebook-arm64-2.0.0.msi` where 2.0.0 is the version number. Add `-Version` as a required parameter to `Finish-Release.ps1` and use it to rename the final files.
-        - [ ] Update `CONTRIBUTING.md` accordingly.
+    - [x] I want the final release files to be named like `SqlNotebook-arm64-2.0.0.msi` where 2.0.0 is the version number. Add `-Version` as a required parameter to `Finish-Release.ps1` and use it to rename the final files.
+        - [x] Update `CONTRIBUTING.md` accordingly.

ps1/Finish-Release.ps1

@@ -4,7 +4,9 @@ param (
     [Parameter(Mandatory=$true)]
     [string]$SigntoolPath,
     [Parameter(Mandatory=$true)]
-    [string]$SigntoolSha1
+    [string]$SigntoolSha1,
+    [Parameter(Mandatory=$true)]
+    [string]$Version
 )
 
 $ErrorActionPreference = "Stop"
@@ -152,8 +154,8 @@ Write-Output "SqlNotebook.msi signed successfully."
 # Copy final files to output directory with proper naming
 #
 
-$finalZipName = "SqlNotebook-$Platform.zip"
-$finalMsiName = "SqlNotebook-$Platform.msi"
+$finalZipName = "SqlNotebook-$Platform-$Version.zip"
+$finalMsiName = "SqlNotebook-$Platform-$Version.msi"
 
 Copy-Item $zipFilePath "$outputDir\$finalZipName"
 Copy-Item $msiFilePath "$outputDir\$finalMsiName"