Fix warnings in build output

Add @SuppressWarnings annotations for deprecated and removal APIs across multiple modules. Update ExtendedFormEditor to use current JFaceResources API methods (destroy/create instead of destroyImage/createImage). Remove deprecated servicefactory parameter from Component annotation in test.

fix gradle-plugin warnings

fix JUnit deprecation warning

Update ArgumentsProvider to match JUnit 5.10+ API
JUnit Jupiter's ArgumentsProvider interface changed to include a ParameterDeclarations parameter in the provideArguments method. Update three test classes that implement custom argument providers to match the new signature.

try to fix maven deprecation warnings

Replace Maven @component with @Inject in Maven plugins

Update all Maven plugin mojos to use standard JSR-330 @Inject annotation instead of Maven-specific @component annotation. This removes the warnings and uses the dependency injection approach to use standard Java conventions supported by Maven 3.9+.
See https://maven.apache.org/maven-jsr330.html#how-to-use-jsr-330-in-plugins

Clean up resource management and remove unused code

Wrap P2Indexer instantiations in try-with-resources for proper cleanup, remove unused imports

Changes:
- Wrap P2Indexer objects in try-with-resources blocks to ensure cleanup
- Move AssertJ SoftAssertions imports to group with test configuration
- Remove unused imports (java.util.Map, org.apache.maven.project.MavenProjectHelper)
- Remove unused FEATURE_PATTERN constant from R5LabelFormatter
- Fix minor whitespace inconsistencies

Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>

Author: chrisrueger

biz.aQute.bnd/src/aQute/bnd/main/bnd.java

@@ -1470,6 +1470,7 @@ interface releaseOptions extends Options {
 	 *
 	 * @throws Exception
 	 */
+	@SuppressWarnings("removal")
 	@Description("Release this project")
 	public void _release(releaseOptions options) throws Exception {
 		Set<Project> projects = new LinkedHashSet<>();

biz.aQute.bndlib.tests/test/test/AnalysisPluginTest.java

@@ -6,7 +6,6 @@
 import java.io.File;
 import java.util.ArrayList;
 import java.util.List;
-import java.util.Map;
 
 import org.junit.jupiter.api.Test;
 

biz.aQute.bndlib.tests/test/test/BuilderTest.java

@@ -52,6 +52,7 @@
 import org.junit.jupiter.params.provider.Arguments;
 import org.junit.jupiter.params.provider.ArgumentsProvider;
 import org.junit.jupiter.params.provider.ArgumentsSource;
+import org.junit.jupiter.params.support.ParameterDeclarations;
 
 import aQute.bnd.build.model.EE;
 import aQute.bnd.header.Attrs;
@@ -1191,7 +1192,8 @@ public void testEEMacro2(String pkg, String bree, String osgiee, String version)
 
 	static class CompilerVersionsArgumentsProvider implements ArgumentsProvider {
 		@Override
-		public Stream<? extends Arguments> provideArguments(ExtensionContext context) throws Exception {
+		public Stream<? extends Arguments> provideArguments(ParameterDeclarations parameters, ExtensionContext context)
+			throws Exception {
 			FileTree tree = new FileTree();
 			Stream<File> files = tree.stream(new File("compilerversions/src"), "*");
 			return files.filter(File::isDirectory)

biz.aQute.bndlib.tests/test/test/ClassReferenceTest.java

@@ -16,6 +16,7 @@
 import org.junit.jupiter.params.provider.Arguments;
 import org.junit.jupiter.params.provider.ArgumentsProvider;
 import org.junit.jupiter.params.provider.ArgumentsSource;
+import org.junit.jupiter.params.support.ParameterDeclarations;
 
 import aQute.bnd.build.model.EE;
 import aQute.bnd.osgi.Builder;
@@ -60,7 +61,8 @@ public void classReferences(String pkg) throws Exception {
 
 	static class CompilerVersionsArgumentsProvider implements ArgumentsProvider {
 		@Override
-		public Stream<? extends Arguments> provideArguments(ExtensionContext context) throws Exception {
+		public Stream<? extends Arguments> provideArguments(ParameterDeclarations parameters, ExtensionContext context)
+			throws Exception {
 			FileTree tree = new FileTree();
 			Stream<File> files = tree.stream(new File("compilerversions/src"), "*");
 			return files.filter(File::isDirectory)
@@ -79,7 +81,8 @@ public void checkEEFor(Clazz.JAVA java) throws Exception {
 
 	static class JAVAArgumentsProvider implements ArgumentsProvider {
 		@Override
-		public Stream<? extends Arguments> provideArguments(ExtensionContext context) throws Exception {
+		public Stream<? extends Arguments> provideArguments(ParameterDeclarations parameters, ExtensionContext context)
+			throws Exception {
 			Clazz.JAVA[] values = Clazz.JAVA.values();
 			return Arrays.stream(values, 0, values.length - 1)
 				.map(Arguments::of);

biz.aQute.bndlib.tests/test/test/component/DSAnnotationTest.java

@@ -676,7 +676,7 @@ public void run() {
 
 	@Component(service = Object.class, configurationPolicy = ConfigurationPolicy.IGNORE, enabled = false, factory = "factory", immediate = false, name = "name", property = {
 		"a=1", "a=2", "b=3"
-	}, properties = "resource.props", servicefactory = false, configurationPid = "configuration-pid", xmlns = "xmlns")
+	}, properties = "resource.props", scope = ServiceScope.SINGLETON, configurationPid = "configuration-pid", xmlns = "xmlns")
 	public static class Explicit_basic implements Serializable, Runnable {
 		private static final long serialVersionUID = 1L;
 

biz.aQute.bndlib.tests/test/test/model/EETest.java

@@ -14,6 +14,7 @@
 import org.junit.jupiter.params.provider.Arguments;
 import org.junit.jupiter.params.provider.ArgumentsProvider;
 import org.junit.jupiter.params.provider.ArgumentsSource;
+import org.junit.jupiter.params.support.ParameterDeclarations;
 
 import aQute.bnd.build.model.EE;
 import aQute.bnd.osgi.Clazz;
@@ -33,7 +34,8 @@ public void highestFromTargetVersion(String label, EE ee) throws Exception {
 
 	static class EEVersionsArgumentsProvider implements ArgumentsProvider {
 		@Override
-		public Stream<? extends Arguments> provideArguments(ExtensionContext context) throws Exception {
+		public Stream<? extends Arguments> provideArguments(ParameterDeclarations parameters, ExtensionContext context)
+			throws Exception {
 			EE[] values = EE.values();
 			return Arrays.stream(values, 0, values.length - 1)
 				.filter(ee -> ee.getCapabilityName()
@@ -161,7 +163,8 @@ public void testEEIsJDKPackage() {
 
 	static class EEsArgumentsProvider implements ArgumentsProvider {
 		@Override
-		public Stream<? extends Arguments> provideArguments(ExtensionContext context) throws Exception {
+		public Stream<? extends Arguments> provideArguments(ParameterDeclarations parameters, ExtensionContext context)
+			throws Exception {
 			EE[] values = EE.values();
 			return Arrays.stream(values, 0, values.length - 1)
 				.filter(ee -> ee.getCapabilityName()
@@ -172,7 +175,8 @@ public Stream<? extends Arguments> provideArguments(ExtensionContext context) th
 
 	static class ModularEEsArgumentsProvider implements ArgumentsProvider {
 		@Override
-		public Stream<? extends Arguments> provideArguments(ExtensionContext context) throws Exception {
+		public Stream<? extends Arguments> provideArguments(ParameterDeclarations parameters, ExtensionContext context)
+			throws Exception {
 			EE[] values = EE.values();
 			return Arrays.stream(values, 0, values.length - 1)
 				.filter(ee -> ee.compareTo(EE.JavaSE_1_8) > 0)

biz.aQute.bndlib/src/aQute/bnd/build/ProjectTester.java

@@ -22,6 +22,7 @@ public abstract class ProjectTester {
 	private boolean					continuous	= true;
 	private boolean					terminate	= true;
 
+	@SuppressWarnings("deprecation")
 	public ProjectTester(Project project) throws Exception {
 		this.project = project;
 		launcher = project.getProjectLauncher();

biz.aQute.repository/src/aQute/bnd/repository/maven/pom/provider/BndPomRepository.java

@@ -106,6 +106,7 @@ public void prepare() {
 		prepared.get(); // start preparation
 	}
 
+	@SuppressWarnings("removal")
 	private Promise<Boolean> preparePromise() {
 		if (configuration.name() == null) {
 			status("Must get a name");

biz.aQute.repository/src/aQute/bnd/repository/maven/provider/Configuration.java

@@ -97,5 +97,6 @@ public interface Configuration {
 	/**
 	 * @return SonatypeMode for this repository none, manual or autopublish
 	 */
+	@SuppressWarnings("removal")
 	SonatypeMode sonatypeMode(String deflt);
 }

biz.aQute.repository/src/aQute/bnd/repository/maven/provider/MavenBndRepository.java

@@ -662,6 +662,7 @@ synchronized boolean init() {
 			List<MavenBackingRepository> snapshot = new ArrayList<MavenBackingRepository>();
 
 			String releaseUrl = configuration.releaseUrl();
+			@SuppressWarnings("removal")
 			SonatypeMode sonatypeMode = configuration.sonatypeMode(SonatypeMode.NONE.name());
 
 			String stagingUrl = configuration.stagingUrl();