Add rebuild trigger policy indicator to explorer toolbar

Adds a visual indicator in the Bndtools Explorer toolbar displaying the current rebuild trigger policy. The indicator updates when preferences change and opens the build preferences page when clicked.

Also reorders and improves the rebuild policy combo box in preferences:
- Reorders items to: Default, Optimized (API-based), Always
- Updates labels and tooltips for better clarity
- Adjusts selection indices to match new order

This makes the rebuild trigger policy setting more discoverable and easier to understand.

Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>

Author: chrisrueger

bndtools.core/src/bndtools/explorer/BndtoolsExplorer.java

@@ -242,6 +242,9 @@ public void linkActivated(HyperlinkEvent e) {
 		toolBarManager.add(HelpButtons.HELP_BTN_BNDTOOLS_EXPLORER);
 		toolBarManager.update(true);
 
+		// Add rebuild trigger policy indicator
+		addRebuildTriggerPolicyIndicator(toolBarManager);
+
 		return header;
 	}
 
@@ -472,6 +475,54 @@ public void run() {
 		return pin;
 	}
 
+	private void addRebuildTriggerPolicyIndicator(ToolBarManager toolBarManager) {
+		// Create a custom action that displays the current rebuild trigger
+		// policy
+		Action rebuildPolicyAction = new Action("Rebuild Trigger Policy") {
+			@Override
+			public void run() {
+				// Optional: Open preferences or show a menu
+				PreferenceDialog dialog = PreferencesUtil.createPreferenceDialogOn(null,
+					BndPreferencePage.PAGE_ID_BUILD, new String[] {}, null);
+				dialog.open();
+			}
+		};
+
+		// Update the action based on preferences
+		Runnable updatePolicyIndicator = () -> {
+			String policy = preferences.getRebuildTriggerPolicy();
+			boolean isDefault = preferences.isRebuildTriggerPolicyDefault();
+
+			if (isDefault) {
+				rebuildPolicyAction.setText("Rebuild: Default");
+				rebuildPolicyAction
+					.setToolTipText("Rebuild Trigger Policy: Using rebuild trigger policy from build.bnd");
+			} else if ("api".equals(policy)) {
+				rebuildPolicyAction.setText("Rebuild: Optimized");
+				rebuildPolicyAction.setToolTipText(
+					"Rebuild Trigger Policy: API-based rebuild optimization enabled - non-API changes just rebuild the current project and won't trigger cascades");
+			} else if ("always".equals(policy)) {
+				rebuildPolicyAction.setText("Rebuild: Always");
+				rebuildPolicyAction.setToolTipText("Rebuild Trigger Policy: All changes trigger downstream rebuilds");
+			} else {
+				rebuildPolicyAction.setText("Rebuild: Unknown");
+				rebuildPolicyAction.setImageDescriptor(Icons.desc("errors"));
+			}
+			toolBarManager.update(true);
+		};
+
+		// Update on preference changes
+		closeables.add(preferences.onString("rebuildTriggerPolicy", (value) -> {
+			updatePolicyIndicator.run();
+		}));
+
+		// Initial update
+		updatePolicyIndicator.run();
+
+		// Add to toolbar
+		toolBarManager.add(rebuildPolicyAction);
+	}
+
 	private void fixupRefactoringPasteAction(FilterPanelPart filterPart) {
 		IActionBars actionBars = getViewSite().getActionBars();
 		IAction originalPaste = actionBars.getGlobalActionHandler(ActionFactory.PASTE.getId());

bndtools.core/src/bndtools/preferences/ui/BndBuildPreferencePage.java

@@ -54,23 +54,23 @@ protected Control createContents(Composite parent) {
 		Label lblRebuildPolicy = new Label(composite, SWT.NONE);
 		lblRebuildPolicy.setText("Rebuild Trigger Policy:");
 		cmbRebuildPolicy = new Combo(composite, SWT.READ_ONLY);
-		cmbRebuildPolicy.setItems("Default (use build.bnd setting)", "Always rebuild",
-			"API-based (skip if API unchanged)");
+		cmbRebuildPolicy.setItems("Default (use build.bnd setting)", "Optimized (skip if API unchanged)",
+			"Always rebuild");
 		cmbRebuildPolicy.setLayoutData(new GridData(SWT.FILL, SWT.CENTER, true, false));
 		cmbRebuildPolicy.setToolTipText(
 			"'Default' uses the value of '-rebuildtriggerpolicy' from build.bnd (or 'always' if not set). "
 				+ "'Always rebuild' triggers a rebuild on every change. "
-				+ "'API-based' skips rebuilds when only non-API changes are detected. "
-				+ "Changes take effect on the next build.");
+				+ "'Optimized' (API-Based) builds just the current project and skips rebuild cascades when only non-API changes are detected. "
+				+ "Changes require a workspace refresh and take effect on the next build.");
 		lblRebuildPolicy.setToolTipText(cmbRebuildPolicy.getToolTipText());
 
 		// Load Data
 		cmbBuildLogging.select(buildLogging);
 		String currentPolicy = prefs.getRebuildTriggerPolicy();
 		if (Constants.REBUILDTRIGGERPOLICY_API.equals(currentPolicy)) {
-			cmbRebuildPolicy.select(2);
-		} else if (Constants.REBUILDTRIGGERPOLICY_ALWAYS.equals(currentPolicy)) {
 			cmbRebuildPolicy.select(1);
+		} else if (Constants.REBUILDTRIGGERPOLICY_ALWAYS.equals(currentPolicy)) {
+			cmbRebuildPolicy.select(2);
 		} else {
 			cmbRebuildPolicy.select(0); // Default
 		}
@@ -92,9 +92,9 @@ public boolean performOk() {
 		prefs.setParallel(parallel.getSelection());
 		String policy;
 		int idx = cmbRebuildPolicy.getSelectionIndex();
-		if (idx == 2) {
+		if (idx == 1) {
 			policy = Constants.REBUILDTRIGGERPOLICY_API;
-		} else if (idx == 1) {
+		} else if (idx == 2) {
 			policy = Constants.REBUILDTRIGGERPOLICY_ALWAYS;
 		} else {
 			policy = ""; // Default: do not override build.bnd

bndtools.core/src/bndtools/preferences/ui/BndPreferencePage.java

@@ -24,6 +24,7 @@ public class BndPreferencePage extends PreferencePage implements IWorkbenchPrefe
 	public BndPreferencePage() {}
 
 	public static final String		PAGE_ID				= "bndtools.prefPages.basic";
+	public static final String		PAGE_ID_BUILD		= "bndtools.prefPages.build";
 
 	private boolean					noCheckCnf			= false;
 	private boolean					warnExistingLaunch	= true;