Skip to content

Remaining DocumentRouter return types should be Optional #374

@thopkins32

Description

@thopkins32

DocumentRouter.event return type should be Optional[Event] not just Event. Similar for DocumentRouter.event_page and DocumentRouter.datum.

Am I missing some context for why these aren't optional?

Acceptance Criteria

  • Return types for the above methods are updated with Optional

Discovered in bluesky/blop#302

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions