feat(checkout): CHECKOUT-10226 Show Placeholder for Extra Dropdown Field#3162
Conversation
There was a problem hiding this comment.
Touching this file in order to support the SDK's interface changes.
| if (isExtraField(field) && field.fieldType === DynamicFormFieldType.DROPDOWN) { | ||
| return language.translate('common.please_select_text'); | ||
| } | ||
|
|
There was a problem hiding this comment.
Do we see any issues in fixing this for custom fields as well?
There was a problem hiding this comment.
Custom fields seem fine as they require a placeholder value(Instructional Text). I must have missed this.
| it('does not render placeholder for custom dropdown field', () => { | ||
| renderAddressFormComponent({ formFields }); | ||
|
|
||
| expect(screen.getByText('Custom dropdown')).toBeInTheDocument(); | ||
| expect(screen.queryByText('Please Select')).not.toBeInTheDocument(); | ||
| }); | ||
|
|
There was a problem hiding this comment.
Should we get rid of this test then?
There was a problem hiding this comment.
I say because this feels like custom dropdown will not have placeholder, while we know it will always have a placeholder regardless, not just this placeholder
|
checkout-js deployed to Integration US |
|
checkout-js deployed to Staging US |
⚡️ Lighthouse results🖥️ Desktop:
📱 Mobile:
|
|
checkout-js deployed to Production US |
3 participants
What/Why?
Add a clear placeholder to help users select an option from the extra-field dropdown.
Rollout/Rollback
Revert.
Testing
Existing B2B checkout
New Extra Dropdown Field on OOPC
Address
Order
Note
Low Risk
UI-only placeholder behavior for B2B dropdowns plus a dependency bump; the payment test change aligns with SDK response shape and does not alter production payment logic in this diff.
Overview
Adds a localized "Please Select" first option for B2B extra-field dropdowns on address forms and order extra fields at payment, via
common.please_select_textandDynamicFormFieldplaceholders inAddressFormandOrderExtraFieldsFieldset.Bumps
@bigcommerce/checkout-sdkto^1.942.2and updates a payment integration test mock so order-submit responses expose B2B address IDs underorder.b2bMetadatainstead ofb2bContext.Reviewed by Cursor Bugbot for commit b78e206. Bugbot is set up for automated code reviews on this repo. Configure here.