feat(checkout): CHECKOUT-10152 skip the standalone billing step for themeV2#3161
Conversation
|
cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 1349cef. Configure here.
bc-maxy
left a comment
bc-maxy
left a comment
There was a problem hiding this comment.
Looks great, thank you for adding the videos with the whole flow! 👏
| const newThemeExperimentEnabled = Boolean( | ||
| config.checkoutSettings.features['CHECKOUT-7962.update_font_style_on_checkout_page'] ?? | ||
| true, | ||
| ); |
There was a problem hiding this comment.
Perhaps use isExperimentEnabled()?
There was a problem hiding this comment.
We cannot actually do that because isExperimentEnabled() is part of core package and using it here will result in circular dependency.
There was a problem hiding this comment.
I see. A separate task, isExperimentEnabled() needs to be out of core. 😂
|
checkout-js deployed to Integration US |
|
checkout-js deployed to Staging US |
⚡️ Lighthouse results🖥️ Desktop:
📱 Mobile:
|
|
checkout-js deployed to Production US |
4 participants
What/Why?
For enhanced checkout theme, skip the standalone billing step since for themV2 the billing step stays in Payment block.
Rollout/Rollback
Revert this PR.
Testing
Enhanced theme setting OFF
CHECKOUT-10152-OldTheme.mov
Enhanced theme setting ON
CHECKOUT-10152.mov
Note
Medium Risk
Changes core checkout step order and post-shipping navigation; mis-gating themeV2 could skip billing or show the wrong flow for some stores.
Overview
For themeV2 checkouts, billing is collected on the payment step instead of a separate step. This PR wires that into step configuration and navigation.
isThemeV2Enabledis extracted fromThemeProviderinto a shared helper (same experiment +checkoutV2Themeflags) and exported from@bigcommerce/checkout/contexts.getCheckoutStepStatusesuses it so the billing step is omitted when themeV2 is on, including with wallet payments.CheckoutPageadvances past shipping straight to the next incomplete step whenthemeV2is true, even if billing is not “same as shipping.” Tests cover the shortened step list (Customer → Shipping → Payment).Reviewed by Cursor Bugbot for commit 1349cef. Bugbot is set up for automated code reviews on this repo. Configure here.