fix(health): treat nil return from Lua health status script as n/a instead of unknown

Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>

Author: snorwin

util/lua/health_test.go

@@ -18,8 +18,8 @@ type TestStructure struct {
 }
 
 type IndividualTest struct {
-	InputPath    string              `yaml:"inputPath"`
-	HealthStatus health.HealthStatus `yaml:"healthStatus"`
+	InputPath    string               `yaml:"inputPath"`
+	HealthStatus *health.HealthStatus `yaml:"healthStatus"`
 }
 
 func getObj(t *testing.T, path string) *unstructured.Unstructured {
@@ -56,7 +56,7 @@ func TestLuaHealthScript(t *testing.T) {
 				require.NoError(t, err)
 				result, err := vm.ExecuteHealthLua(obj, script)
 				require.NoError(t, err)
-				assert.Equal(t, &test.HealthStatus, result)
+				assert.Equal(t, test.HealthStatus, result)
 			})
 		}
 		return nil

util/lua/lua.go

@@ -159,7 +159,7 @@ func (vm VM) ExecuteHealthLua(obj *unstructured.Unstructured, script string) (*h
 
 		return healthStatus, nil
 	} else if returnValue.Type() == lua.LTNil {
-		return &health.HealthStatus{}, nil
+		return nil, nil
 	}
 	return nil, fmt.Errorf(incorrectReturnType, "table", returnValue.Type().String())
 }

util/lua/lua_test.go

@@ -148,8 +148,7 @@ func TestNoReturnHealthStatusStatus(t *testing.T) {
 	vm := VM{}
 	status, err := vm.ExecuteHealthLua(testObj, validReturnNothingHealthStatusStatus)
 	require.NoError(t, err)
-	expectedStatus := &health.HealthStatus{}
-	assert.Equal(t, expectedStatus, status)
+	assert.Nil(t, status)
 }
 
 const validNilHealthStatusStatus = `local healthStatus = {}
@@ -161,8 +160,7 @@ func TestNilHealthStatusStatus(t *testing.T) {
 	vm := VM{}
 	status, err := vm.ExecuteHealthLua(testObj, validNilHealthStatusStatus)
 	require.NoError(t, err)
-	expectedStatus := &health.HealthStatus{}
-	assert.Equal(t, expectedStatus, status)
+	assert.Nil(t, status)
 }
 
 const validEmptyArrayHealthStatusStatus = `local healthStatus = {}