Refactor: use == 0 instead of <= 0 for len(SCMProviders) check in applicationset.go

[coderabbitai]

Summary

In controllers/argocd/applicationset.go, the condition checking whether SCMProviders is empty uses <= 0 instead of the more idiomatic == 0:

if len(appsetsSourceNamespaces) > 0 && (len(cr.Spec.ApplicationSet.SCMProviders) <= 0) {

also:

...fmt.Sprint(strings.Join(appsetsSourceNamespaces, ","))...

Since len() never returns a negative value, the <= 0 check should be replaced with == 0 for clarity and correctness.

Suggested Fix

if len(appsetsSourceNamespaces) > 0 && len(cr.Spec.ApplicationSet.SCMProviders) == 0 {

References

• Raised during review of PR Improve error propagation in ApplicationSet command generation #2124 (comment by @akhilnittala)
• PR Improve error propagation in ApplicationSet command generation #2124: Improve error propagation in ApplicationSet command generation #2124

cc @nmirasch — you may want to pick this up as a small follow-up cleanup.