Skip to content

Commit f2fee24

Browse files
ivolivol
authored andcommitted
refactor: resolve Copilot review findings for SwiftPM target names, nullability crash vector, and Javadoc mismatch
1 parent 64ae8a0 commit f2fee24

3 files changed

Lines changed: 6 additions & 5 deletions

File tree

Package.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ let package = Package(
99
products: [
1010
.library(
1111
name: "approov-service-react-native",
12-
targets: ["approov-service-react-native"]
12+
targets: ["approov_service_react_native"]
1313
),
1414
],
1515
dependencies: [
@@ -20,7 +20,7 @@ let package = Package(
2020
],
2121
targets: [
2222
.target(
23-
name: "approov-service-react-native",
23+
name: "approov_service_react_native",
2424
dependencies: [
2525
.product(name: "Approov", package: "approov-ios-sdk"),
2626
.product(name: "StructuredHeaders", package: "swift-http-structured-headers")

android/src/main/java/io/approov/reactnative/ApproovService.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -675,8 +675,9 @@ public synchronized long getEarliestNetworkRequestTime() {
675675

676676
/**
677677
* Initializes the ApproovService with an account configuration and comment.
678-
* Resets all service-layer state unconditionally before initializing the platform
679-
* SDK. The platform SDK returns true on first initialization or false if it is
678+
* Resets service-layer state if the configuration changes. A same-config
679+
* re-initialization preserves any configuration applied after the first setup.
680+
* The platform SDK returns true on first initialization or false if it is
680681
* already initialized with the same configuration (treated as success). Any other
681682
* failure — such as a different-config conflict — throws and is surfaced as a
682683
* rejected promise.

ios/ApproovService.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ typedef NS_ENUM(NSUInteger, ApproovTrustDecision) {
112112
/// Returns the current exclusion URL regexs.
113113
///
114114
/// @return a set of exclusion URL regexs
115-
+ (NSMutableSet<NSString *> * _Nonnull)sharedExclusionURLRegexs;
115+
+ (NSMutableSet<NSString *> * _Nullable)sharedExclusionURLRegexs;
116116

117117
/// Gets the signature for the given message using the install private key.
118118
///

0 commit comments

Comments
 (0)