Change g:format to accept date, datetime and time

[jamesfredley]

Issue description

Change g:format to take date, datetime and time, instead of single date format

[codeconsole]

@jamesfredley it already does that but the default behavior is to render:

grails-core/grails-gsp/plugin/src/main/groovy/org/grails/plugins/web/taglib/FormatTagLib.groovy

Line 187 in c27742f

format = messageHelper('date.format', { messageHelper('default.date.format', 'yyyy-MM-dd HH:mm:ss z', null, locale) }, null, locale)

otherwise there is a type parameter for date, time, and anything else

grails-core/grails-gsp/plugin/src/main/groovy/org/grails/plugins/web/taglib/FormatTagLib.groovy

Lines 193 to 201 in c27742f

	if (type == 'DATE') {
	dateFormat = grailsTagDateHelper.getDateFormat(dateStyle, timeZone, locale)
	}
	else if (type == 'TIME') {
	dateFormat = grailsTagDateHelper.getTimeFormat(timeStyle, timeZone, locale)
	}
	else { // 'both' or 'datetime'
	dateFormat = grailsTagDateHelper.getDateTimeFormat(dateStyle, timeStyle, timeZone, locale)
	}

[codeconsole]

#15146

grails-core/grails-fields/grails-app/taglib/grails/plugin/formfields/FormFieldsTagLib.groovy

Lines 949 to 973 in c27742f

	switch (model.type) {
	case Boolean.TYPE:
	case Boolean:
	g.formatBoolean(boolean: model.value)
	break
	case LocalDate:
	case java.sql.Date:
	g.formatDate(date: model.value, type: 'DATE')
	break
	case java.sql.Time:
	case LocalTime:
	g.formatDate(date: model.value, type: 'TIME')
	break
	case Calendar:
	case Date:
	case LocalDateTime:
	case java.sql.Timestamp:
	case Instant:
	case ZonedDateTime:
	case OffsetDateTime:
	g.formatDate(date: model.value)
	break
	default:
	g.fieldValue(bean: model.bean, field: model.property)
	}

#15118 - introduces second precision on date picker and time-stamping

Date picker should also be updated to support time only as well as optional millisecond and nanosecond precision for lossless date updating.

[jamesfredley]

@codeconsole @jdaugherty I created this issue during the discussion in the weekly meting today, but it's sounds like we might already have what we need.

[codeconsole]

@jamesfredley yeah, I know, I am just adding context because we need to discuss it more. I still don't think we have a final solution and I am looking for everyones input. I want this issue to start the discussion.

This PR shows what everything looks like using DATETIME
#15165

[codeconsole]

grails:
 databinding:
   dateFormats: # used when parsing posted form fields
     - "yyyy-MM-dd'T'HH:mm:ss.SSSX"
     - "yyyy-MM-dd'T'hh:mm:ss'Z'"
     - "yyyy-MM-dd HH:mm:ss.S z"
     - "yyyy-MM-dd HH:mm:ss.S"
     - "yyyy-MM-dd'T'HH:mm:ssZ"
     - "yyyy-MM-dd'T'HH:mm:ss"
     - "yyyy-MM-dd HH:mm:ss"
     - "yyyy-MM-dd HH:mm"
     - "yyyy-MM-dd"
     - "HH:mm:ssZ"
     - "HH:mm:ss"

and the following from messages.properties

default.date.format=EEE, MMM d, yyyy h:mm:ss a, z
default.date.day.format=EEE, MMM d
default.date.time.format=h:mm a

@jamesfredley can you please describe what you were referring to here #15146 (comment) Are these existing configuration values or a proposal?

[jdaugherty]

I thought we wanted to create this ticket to only have 3 different default date/datetime/time formats. @codeconsole are you saying we already have defaults for these that can be overridden?

[jamesfredley]

@codeconsole I only wanted to make sure we continued to support overriding the default format(s) using the same historical config locations.

default.date.format varies by local in apps generated by shell and forge and I do not have an opinion on changing the default.

• https://github.com/apache/grails-core/tree/7.0.x/grails-forge/grails-forge-core/src/main/resources/i18n
• https://github.com/apache/grails-core/tree/7.0.x/grails-profiles/base/skeleton/grails-app/i18n

I had not had time to look at #15146 in depth, so the databinding config was not relevant.

In general I have found the default list for databinding dateFormats to be missing a few common formats, but I will keep overriding it and would not want to risk breaking other apps to change the default list.

grails-core/grails-databinding/src/main/groovy/org/grails/plugins/databinding/AbstractDataBindingGrailsPlugin.groovy

Lines 50 to 56 in c27742f

	public static final String DEFAULT_JSR310_OFFSET_ZONED_DATE_TIME_FORMAT = "yyyy-MM-dd'T'HH:mm:ssZ"
	public static final String DEFAULT_JSR310_OFFSET_TIME_FORMAT = 'HH:mm:ssZ'
	public static final String DEFAULT_JSR310_LOCAL_DATE_TIME_FORMAT = "yyyy-MM-dd'T'HH:mm:ss"
	public static final String DEFAULT_JSR310_LOCAL_DATE_FORMAT = 'yyyy-MM-dd'
	public static final String DEFAULT_JSR310_LOCAL_TIME_FORMAT = 'HH:mm:ss'
	public static final List<String> DEFAULT_DATE_FORMATS = ['yyyy-MM-dd HH:mm:ss.S', "yyyy-MM-dd'T'HH:mm:ss'Z'", 'yyyy-MM-dd HH:mm:ss.S z', "yyyy-MM-dd'T'HH:mm:ss.SSSX", DEFAULT_JSR310_OFFSET_ZONED_DATE_TIME_FORMAT, DEFAULT_JSR310_OFFSET_TIME_FORMAT, DEFAULT_JSR310_LOCAL_DATE_TIME_FORMAT, DEFAULT_JSR310_LOCAL_DATE_FORMAT, DEFAULT_JSR310_LOCAL_TIME_FORMAT]

[codeconsole]

@jdaugherty I am saying g:dateFormat already supports 3 format types. I haven't dug deep enough to see if they are overridable. At first glance it looked to me like if you don't specify a type, you only get 1 default format which is everything.

I haven't traced this code yet, but it would make sense to be that the fields plugin should use type DATETIME for displaying dates. In 7.1.x, if they are not overridable, we can make them.

grails-core/grails-gsp/plugin/src/main/groovy/org/grails/plugins/web/taglib/FormatTagLib.groovy

Lines 193 to 201 in c27742f

	if (type == 'DATE') {
	dateFormat = grailsTagDateHelper.getDateFormat(dateStyle, timeZone, locale)
	}
	else if (type == 'TIME') {
	dateFormat = grailsTagDateHelper.getTimeFormat(timeStyle, timeZone, locale)
	}
	else { // 'both' or 'datetime'
	dateFormat = grailsTagDateHelper.getDateTimeFormat(dateStyle, timeStyle, timeZone, locale)
	}

[codeconsole]

@jamesfredley where did you get this yml code from?

grails:
 databinding:
   dateFormats: # used when parsing posted form fields
     - "yyyy-MM-dd'T'HH:mm:ss.SSSX"
     - "yyyy-MM-dd'T'hh:mm:ss'Z'"
     - "yyyy-MM-dd HH:mm:ss.S z"
     - "yyyy-MM-dd HH:mm:ss.S"
     - "yyyy-MM-dd'T'HH:mm:ssZ"
     - "yyyy-MM-dd'T'HH:mm:ss"
     - "yyyy-MM-dd HH:mm:ss"
     - "yyyy-MM-dd HH:mm"
     - "yyyy-MM-dd"
     - "HH:mm:ssZ"
     - "HH:mm:ss"

[jamesfredley]

That yml was copied from one of my apps.

https://grails.apache.org/docs/snapshot/guide/theWebLayer.html#_date_formats_for_data_binding pointed me in that direction years and years ago. It needs to be updated with the full list and a yml example.

[codeconsole]

That yml was copied from one of my apps.

https://grails.apache.org/docs/snapshot/guide/theWebLayer.html#_date_formats_for_data_binding pointed me in that direction years and years ago. It needs to be updated with the full list and a yml example.

@jamesfredley ahh, yeah, those are for parsing, not rendering.