Keep only tests that change state across the fix

The raw Map and non-domain cases passed before this change and after it, so
they documented behaviour rather than protecting it, and are dropped.

What is added instead all fails without the fix, each for a distinct reason:

  - a property declared Collection rather than List or Set, so the branch is
    reached through a third declared type,
  - elements arriving as a DataBindingSource rather than a Map, which is the
    other item shape that branch instantiates,
  - deny-by-default enabled with the property allowlisted, which shows the loss
    is not gated by the opt-in: the element is an empty Object there too, and
    the property binds, so the failure is the data being destroyed rather than
    the binding being denied.

Author: codeconsole

grails-test-suite-persistence/src/test/groovy/grails/web/databinding/GrailsWebDataBinderSpec.groovy

@@ -28,6 +28,7 @@ import spock.lang.Unroll
 import org.springframework.context.support.StaticMessageSource
 
 import grails.config.Settings
+import grails.util.Holders
 import grails.databinding.BindUsing
 import grails.databinding.BindingFormat
 import grails.databinding.DataBindingSource
@@ -1982,32 +1983,66 @@ class GrailsWebDataBinderSpec extends Specification implements DataTest {
         obj.rawList[1].param == 'status=pending'
     }
 
-    void 'test binding maps into a raw Map property preserves the map values'() {
+    void 'test binding maps into a raw Set property preserves the map elements'() {
         given:
         def obj = new RawCollectionContainer()
 
         when:
         binder.bind(obj, new SimpleMapDataBindingSource([
-            rawMap: [first: [label: 'Answered', param: 'status=resolved']]
+            rawSet: [[label: 'Answered', param: 'status=resolved']]
         ]))
 
         then:
-        obj.rawMap.first instanceof Map
-        obj.rawMap.first.label == 'Answered'
+        obj.rawSet.every { it instanceof Map }
+        obj.rawSet.first().label == 'Answered'
     }
 
-    void 'test binding maps into a raw Set property preserves the map elements'() {
+    void 'test binding maps into a raw Collection-typed property'() {
+        given:
+        def obj = new RawCollectionContainer()
+
+        when:
+        binder.bind(obj, new SimpleMapDataBindingSource([rawCollection: [[label: 'Answered']]]))
+
+        then:
+        obj.rawCollection.every { it instanceof Map }
+        obj.rawCollection[0].label == 'Answered'
+    }
+
+    void 'test binding DataBindingSource items into a raw collection'() {
         given:
         def obj = new RawCollectionContainer()
 
         when:
         binder.bind(obj, new SimpleMapDataBindingSource([
-            rawSet: [[label: 'Answered', param: 'status=resolved']]
+            rawList: [new SimpleMapDataBindingSource([label: 'Answered'])]
         ]))
 
         then:
-        obj.rawSet.every { it instanceof Map }
-        obj.rawSet.first().label == 'Answered'
+        obj.rawList.size() == 1
+        obj.rawList[0].getClass() != Object
+    }
+
+    void 'test binding maps into a raw collection with deny-by-default enabled'() {
+        given: 'the opt-in hardening turned on, and the property explicitly allowlisted'
+        def originalConfig = Holders.config
+        Holders.setConfig(new PropertySourcesConfig([(Settings.DATABINDING_DENY_BY_DEFAULT): true]))
+        DataBindingUtils.clearBindingCaches()
+        def obj = new RawCollectionContainer()
+
+        when:
+        binder.bind(obj, new SimpleMapDataBindingSource([
+            rawList: [[label: 'Answered', param: 'status=resolved']]
+        ]), null, ['rawList'], null, null)
+
+        then: 'the elements are still maps, as they are with the hardening off'
+        obj.rawList.size() == 1
+        obj.rawList[0] instanceof Map
+        obj.rawList[0].label == 'Answered'
+
+        cleanup:
+        Holders.setConfig(originalConfig)
+        DataBindingUtils.clearBindingCaches()
     }
 }
 
@@ -2017,6 +2052,7 @@ class RawCollectionContainer {
     List rawList = []
     Map rawMap = [:]
     Set rawSet = []
+    Collection rawCollection = []
 }
 
 @Entity