Run the isolated tests in the uber suite

Some classes here pollute static state that the rest of the fork would inherit,
so each is given a Test task of its own and excluded from `test`. A Test task
that is registered rather than the one the java plugin creates has neither
testClassesDirs nor classpath, which makes it NO-SOURCE: it reports success
having run nothing. Since `test` excludes those same classes, all forty ran in
no task at all.

This is older than it looks. b156214 rewrote `task x(type: Test)` as
`tasks.register(x, Test)` in November 2023, but both forms are NO-SOURCE -- the
java plugin wires source onto its own `test` task only -- so that commit
inherited the problem rather than causing it. The sharding plugin picks these
tasks up through tasks.withType(Test) and has been distributing empty tasks
across shards ever since.

Two things kept it quiet, and both are fixed here. The tasks ran nothing, and
grails-test-report matches phases by task name, so their results were invisible
to the aggregate reports even when they did run.

What ran for the first time in years mostly passed. Four did not:
RestfulControllerSpec and ResourceAnnotationRestfulControllerSpec assert that
save, update and patch render the create or edit view again for an instance with
errors, and built that instance with an empty title. Binding an empty string
stores null, and a persistent property is nullable by default in Grails 8, so
the instance was valid and the controller redirected instead. Their domains say
`title blank: false`, which meant required under the old default; it now says
`nullable: false` as well, which is what it always meant.

Author: jdaugherty

grails-test-report/build.gradle

@@ -24,12 +24,25 @@ plugins {
 // the cli tier runs its tests in dedicated source sets (test-cli / integration-test-cli), so those
 // phases are aggregated alongside the ordinary ones - otherwise their results would be invisible
 // to the aggregate reports and to CI
+//
+// the test-suite projects also run some classes in their own Test tasks, to keep a class that
+// pollutes static state away from the rest of the fork. A phase is matched by task name, so those
+// task names have to be named here too, or their results are invisible in exactly the same way -
+// which is how they came to run nothing at all without anyone noticing.
+def isolatedUnitTestPhases = [
+        'isolatedTestsOne',
+        'isolatedTestsTwo',
+        'isolatedRestRendererTests',
+        'isolatedPersonTests',
+        'isolatedRestfulControllerTests',
+]
+
 def reportVariants = [
         test           : [
                 taskName    : 'testAggregateTestReport',
                 markdownTask: 'markdownAggregateTestReport',
                 title       : 'Grails Unit Test Report',
-                phases      : ['test', 'testCli'],
+                phases      : ['test', 'testCli'] + isolatedUnitTestPhases,
                 reportDir   : 'reports/tests/test',
                 markdownFile: 'reports/tests/test.md',
         ],
@@ -45,7 +58,7 @@ def reportVariants = [
                 taskName    : 'combinedAggregateTestReport',
                 markdownTask: 'markdownCombinedAggregateTestReport',
                 title       : 'Grails Combined Test Report',
-                phases      : ['test', 'testCli', 'integrationTest', 'integrationTestCli'],
+                phases      : ['test', 'testCli', 'integrationTest', 'integrationTestCli'] + isolatedUnitTestPhases,
                 reportDir   : 'reports/tests/combined',
                 markdownFile: 'reports/tests/combined.md',
         ],

grails-test-suite-uber/build.gradle

@@ -118,6 +118,11 @@ def testSkippingProperties = [
 isolatedTestPatterns.keySet().each { taskName ->
     tasks.register(taskName, Test) {
         group = 'verification'
+        // A Test task registered rather than inherited has neither of these, which makes it
+        // NO-SOURCE: it reports success having run nothing. These classes are excluded from
+        // `test` below, so without this they run in no task at all.
+        testClassesDirs = sourceSets.test.output.classesDirs
+        classpath = sourceSets.test.runtimeClasspath
         filter.includePatterns = isolatedTestPatterns[taskName]
     }
 }

grails-test-suite-uber/src/test/groovy/grails/test/mixin/ResourceAnnotationRestfulControllerSpec.groovy

@@ -50,7 +50,7 @@ import grails.rest.*
 class Video {
     String title
     static constraints = {
-        title blank:false
+        title blank: false, nullable: false
     }
 }
 ''')

grails-test-suite-uber/src/test/groovy/grails/test/mixin/RestfulControllerSpec.groovy

@@ -215,7 +215,7 @@ class Video {
     String title
     Integer numberOfMinutes
     static constraints = {
-        title blank:false
+        title blank: false, nullable: false
         numberOfMinutes nullable: true
     }
 }