GH-50172: [Doc][Format] Clarify that variadic buffers can also be null#50255
Merged
pitrou merged 1 commit intoJun 29, 2026
Merged
Conversation
|
|
github-actions
Bot
added
Component: Documentation
awaiting review
Member
Author
|
@alamb @paleolimbot @CurtHagenlocher Does this look ok? |
alamb
approved these changes
Jun 25, 2026
alamb
left a comment
alamb
left a comment
Contributor
There was a problem hiding this comment.
makes sense to me -- thank you @pitrou
FYI @andishgar
github-actions
Bot
added
awaiting merge
CurtHagenlocher
approved these changes
Jun 25, 2026
pitrou
force-pushed
the
gh50172-c-data-interface-null-variadic-buffers
branch
from
25ab02c to
f5fb4e6
Compare
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 6b4c524. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Some implementations are known to produce null variadic buffers in BinaryView arrays, and expose them on the C Data Interface.
Since Arrow C++, and perhaps other implementations, make the wrong assumption that imported variadic buffers cannot be null, clarify the docs.
Are these changes tested?
N/A.
Are there any user-facing changes?
No.