Skip to content

Detect FLAC bit depth in mka container#3261

Merged
copybara-service[bot] merged 2 commits into
androidx:mainfrom
nift4:flacinmka
Jun 9, 2026
Merged

Detect FLAC bit depth in mka container#3261
copybara-service[bot] merged 2 commits into
androidx:mainfrom
nift4:flacinmka

Conversation

@nift4

@nift4 nift4 commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@icbaker icbaker self-assigned this Jun 4, 2026
copybara-service Bot pushed a commit that referenced this pull request Jun 4, 2026
This is a precursor to merging Issue: #3261

PiperOrigin-RevId: 926623920
@icbaker

icbaker commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator

Thanks for this, it prompted me to do a couple of test-related changes first:

  1. Run the existing FLAC-in-MKA assets through MatroskaExtractorTest (so we can see the impact of this change in the dumps): c92d88e
  2. Re-write the pcmEncoding test dump value to be human-readable: 1effe5b

I'll rebase this on top of those, update the test dumps, and send it for internal review.

@copybara-service copybara-service Bot merged commit 6b50863 into androidx:main Jun 9, 2026
1 check passed
@nift4

nift4 commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

Thanks! :)

@nift4 nift4 deleted the flacinmka branch June 9, 2026 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants