Skip to content

Thread safety issue in the logger #11

Description

@cagrikymk

Hello,
Probably I got unlucky and hit a weird bug when I was running vllm with TP 8. I got the following error from the quark library:

FileExistsError: [Errno 17] File exists: 'quark_logs'

From quark/shares/utils/log.py:20

        if not os.path.exists(debug_file_dir):
            os.makedirs(debug_file_dir)

I think this part is not multi-threading safe (potential race condition).

I think multiple threads passed the if guard and tried to create the folder which led to the error.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions