Merge pull request #1138 from alphagov/2128-rm-feedback

2128: Remove report issue UI

Author: ahernp

accessibility_monitoring_platform/apps/common/forms.py

@@ -415,26 +415,6 @@ class PlatformCheckingForm(forms.Form):
     message = AMPCharFieldWide(label="Message", initial="Test log message")
 
 
-class AMPIssueReportForm(forms.ModelForm):
-    """
-    Form used to record issue reported by user in database.
-    """
-
-    page_url = forms.CharField(widget=forms.HiddenInput())
-    page_title = AMPCharFieldWide(label="Page where the problem occurred")
-    goal_description = AMPTextField(label="What were you doing?")
-    issue_description = AMPTextField(label="What went wrong?")
-
-    class Meta:
-        model = IssueReport
-        fields = [
-            "page_url",
-            "page_title",
-            "goal_description",
-            "issue_description",
-        ]
-
-
 class AMPTopMenuForm(forms.Form):
     """
     Form for searching for cases in the top menu bar

accessibility_monitoring_platform/apps/common/sitemap.py

@@ -1847,7 +1847,6 @@ def __init__(self, type=PlatformPageGroup.Type.MOBILE_CASE_NAV, **kwargs):
                 DetailedCasePlatformPage(
                     name="Detailed case history", url_name="detailed:case-history"
                 ),
-                PlatformPage(name="Issue reports", url_name="tech:issue-reports-list"),
                 PlatformPage(
                     name="Reference implementation",
                     url_name="tech:reference-implementation",
@@ -1897,7 +1896,6 @@ def __init__(self, type=PlatformPageGroup.Type.MOBILE_CASE_NAV, **kwargs):
                     name="Accessibility statement",
                     url_name="common:accessibility-statement",
                 ),
-                PlatformPage(name="Report an issue", url_name="common:issue-report"),
                 PlatformPage(name="Contact admin", url_name="common:contact-admin"),
                 PlatformPage(name="Dashboard", url_name="dashboard:home"),
                 PlatformPage(name="Tasks", url_name="notifications:task-list"),

accessibility_monitoring_platform/apps/common/templates/common/issue_report.html

@@ -1,6 +1,7 @@
 """
 Test urls of common app
 """
+
 import pytest
 from django.http.response import HttpResponse
 from django.urls import reverse
@@ -12,7 +13,6 @@
         "common:contact-admin",
         "common:edit-active-qa-auditor",
         "common:platform-history",
-        "common:issue-report",
         "common:markdown-cheatsheet",
     ],
 )

accessibility_monitoring_platform/apps/common/tests/test_urls.py

@@ -34,8 +34,6 @@
 FOUND_DOMAIN: str = "found"
 EMAIL_SUBJECT: str = "Email subject"
 EMAIL_MESSAGE: str = "Email message"
-ISSUE_REPORT_LINK: str = """<a class="govuk-footer__link" href="/common/report-issue/?page_url=/&page_title=Dashboard"
-target="_blank">Report an issue</a>"""
 METRIC_OVER_LAST_30_DAYS: str = """<p id="{metric_id}" class="govuk-body-m">
     <span class="govuk-!-font-size-48"><b>{number_last_30_days}</b></span>
     <?xml version="1.0" encoding="UTF-8" standalone="no"?>
@@ -165,7 +163,6 @@
         ("common:contact-admin", "Contact admin"),
         ("common:edit-active-qa-auditor", ">Active QA auditor</h1>"),
         ("common:platform-history", ">Platform version history</h1>"),
-        ("common:issue-report", ">Report an issue</h1>"),
         ("common:accessibility-statement", ">Accessibility statement</h1>"),
         ("common:privacy-notice", ">Privacy notice</h1>"),
         ("common:markdown-cheatsheet", ">Markdown cheatsheet</h1>"),
@@ -278,29 +275,6 @@ def test_view_privacy_notice(client):
     )
 
 
-@pytest.mark.parametrize(
-    "prototype_name,issue_report_link_expected",
-    [
-        ("", True),
-        ("TEST", True),
-        ("anything-else", False),
-    ],
-)
-def test_issue_report_link(prototype_name, issue_report_link_expected, admin_client):
-    """
-    Test issue report link is rendered on live and test platforms
-    but not on prototypes.
-    """
-    settings.AMP_PROTOTYPE_NAME = prototype_name
-    response: HttpResponse = admin_client.get(reverse("dashboard:home"))
-
-    assert response.status_code == 200
-    if issue_report_link_expected:
-        assertContains(response, ISSUE_REPORT_LINK, html=True)
-    else:
-        assertNotContains(response, ISSUE_REPORT_LINK, html=True)
-
-
 @pytest.mark.parametrize(
     "case_field, metric_id, lowercase_label",
     [
@@ -1399,30 +1373,3 @@ def test_navbar_tasks_emboldened(admin_client, admin_user):
         </li>""",
         html=True,
     )
-
-
-@pytest.mark.parametrize(
-    "url, expected_page_name",
-    [
-        ("/", "Your cases"),
-        ("/cases/1/edit-case-metadata/", "Case metadata"),
-        ("/audits/1/edit-audit-metadata/", "Initial test metadata"),
-    ],
-)
-def test_page_name(url, expected_page_name, admin_client):
-    """
-    Test that the page renders and problem page's url and name are populated
-    as expected.
-    """
-    simplified_case: SimplifiedCase = SimplifiedCase.objects.create()
-    Audit.objects.create(simplified_case=simplified_case)
-
-    response: HttpResponse = admin_client.get(
-        f"/common/report-issue/?page_url={url}&page_title={expected_page_name}"
-    )
-
-    assert response.status_code == 200
-
-    assertContains(response, "Report an issue")
-    assertContains(response, url)
-    assertContains(response, expected_page_name)

accessibility_monitoring_platform/apps/common/tests/test_views.py

@@ -14,7 +14,6 @@
     ContactAdminView,
     FooterLinkFormsetTemplateView,
     FrequentlyUsedLinkFormsetTemplateView,
-    IssueReportView,
     MarkdownCheatsheetTemplateView,
     MetricsCaseTemplateView,
     MetricsPolicyTemplateView,
@@ -36,9 +35,6 @@
         login_required(ChangeToPlatformListView.as_view()),
         name="platform-history",
     ),
-    path(
-        "report-issue/", login_required(IssueReportView.as_view()), name="issue-report"
-    ),
     path(
         "accessibility-statement/",
         AccessibilityStatementTemplateView.as_view(),

accessibility_monitoring_platform/apps/common/urls.py

@@ -9,9 +9,7 @@
 from django.contrib import messages
 from django.core.mail import EmailMessage
 from django.db.models.query import QuerySet
-from django.forms.models import ModelForm
 from django.http import HttpRequest, HttpResponse, HttpResponseRedirect
-from django.shortcuts import redirect
 from django.urls import reverse_lazy
 from django.views.generic import TemplateView
 from django.views.generic.edit import FormView, UpdateView
@@ -26,7 +24,6 @@
 from .forms import (
     ActiveQAAuditorUpdateForm,
     AMPContactAdminForm,
-    AMPIssueReportForm,
     BulkURLSearchForm,
     FooterLinkFormset,
     FooterLinkOneExtraFormset,
@@ -44,13 +41,7 @@
     get_report_progress_metrics,
     get_report_yearly_metrics,
 )
-from .models import (
-    ChangeToPlatform,
-    FooterLink,
-    FrequentlyUsedLink,
-    IssueReport,
-    Platform,
-)
+from .models import ChangeToPlatform, FooterLink, FrequentlyUsedLink, Platform
 from .platform_template_view import PlatformTemplateView
 from .utils import extract_domain_from_url, get_platform_settings, sanitise_domain
 
@@ -135,63 +126,6 @@ def send_mail(self, cleaned_data: dict[str, str]) -> None:
             email.send()
 
 
-class IssueReportView(FormView):
-    """
-    Save user feedback
-    """
-
-    form_class: type[AMPIssueReportForm] = AMPIssueReportForm
-    template_name: str = "common/issue_report.html"
-    success_url: str = reverse_lazy("dashboard:home")
-
-    def get(self, request, *args, **kwargs):
-        """Populate form"""
-        target_page_url: str = self.request.GET.get("page_url", "")
-        target_page_title: str = self.request.GET.get("page_title", "Unknown page")
-
-        goal_description: str = self.request.GET.get("goal_description", "")
-        issue_description: str = self.request.GET.get("issue_description", "")
-        self.form: AMPIssueReportForm = self.form_class(
-            {
-                "page_url": target_page_url,
-                "page_title": target_page_title,
-                "goal_description": goal_description,
-                "issue_description": issue_description,
-            }
-        )
-        self.form.is_valid()
-        return super().get(request, *args, **kwargs)
-
-    def get_context_data(self, **kwargs) -> dict[str, Any]:
-        """Add field values into context"""
-        context: dict[str, Any] = super().get_context_data(**kwargs)
-        context["form"] = self.form
-        return context
-
-    def form_valid(self, form: ModelForm):
-        """Process contents of valid form"""
-        issue_report: IssueReport = form.save(commit=False)
-        issue_report.created_by = self.request.user
-        issue_report.save()
-        self.send_mail(issue_report)
-        return redirect(issue_report.page_url)
-
-    def send_mail(self, issue_report: IssueReport) -> None:
-        email: EmailMessage = EmailMessage(
-            subject=f"Platform issue on {issue_report.page_title}",
-            body=f"""Reported by: {issue_report.created_by}
-
-URL: https://{self.request.get_host()}{issue_report.page_url}
-
-Goal: {issue_report.goal_description}
-
-Issue: {issue_report.issue_description}""",
-            from_email=self.request.user.email,
-            to=[settings.CONTACT_ADMIN_EMAIL],
-        )
-        email.send()
-
-
 class ActiveQAAuditorUpdateView(UpdateView):
     """
     Update active QA auditor

accessibility_monitoring_platform/apps/common/views.py

@@ -44,16 +44,3 @@ class ImportTrelloCommentsForm(forms.Form):
         choices=Boolean.choices,
         widget=AMPChoiceCheckboxWidget(attrs={"label": "Delete existing data"}),
     )
-
-
-class IssueReportSearchForm(forms.Form):
-    """Form for searching for issue reports"""
-
-    issue_report_search = AMPCharFieldWide(
-        widget=forms.TextInput(
-            attrs={
-                "class": "govuk-input",
-                "placeholder": "Search term",
-            }
-        )
-    )