Add accessibility IDs to calendar legend

Expose accessibility identifiers for CalendarLegendView and its LegendItem labels to improve UI test reliability and accessibility. Refactor LegendItem to accept a labelIdentifier and mark the view as an accessibility element; convert labelKey init to LocalizedStringKey. Update LocalizationUITests by adding assertLegendPeriodLabel helper and using it in the language switch test, with additional tab bar existence checks and more robust lookup logic.

Author: VoxDroid

CycleOne/Views/Calendar/CalendarLegendView.swift

@@ -7,46 +7,73 @@ import SwiftUI
 
 struct CalendarLegendView: View {
     @EnvironmentObject private var themeManager: ThemeManager
+
     var body: some View {
         VStack(alignment: .leading, spacing: 10) {
             Text("calendar.legend.title")
                 .font(.caption)
                 .fontWeight(.semibold)
                 .foregroundColor(.secondary)
+                .accessibilityIdentifier("CalendarLegend_TitleLabel")
 
             HStack(spacing: 0) {
-                LegendItem(color: .systemPink, labelKey: "calendar.legend.period", isCustomView: true)
+                LegendItem(
+                    color: .systemPink,
+                    labelKey: "calendar.legend.period",
+                    isCustomView: true,
+                    labelIdentifier: "CalendarLegend_PeriodLabel"
+                )
                 Spacer()
-                LegendItem(color: .systemGray, labelKey: "calendar.legend.predicted")
+                LegendItem(
+                    color: .systemGray,
+                    labelKey: "calendar.legend.predicted",
+                    labelIdentifier: "CalendarLegend_PredictedLabel"
+                )
                 Spacer()
-                LegendItem(color: .systemTeal, labelKey: "calendar.legend.ovulation")
+                LegendItem(
+                    color: .systemTeal,
+                    labelKey: "calendar.legend.ovulation",
+                    labelIdentifier: "CalendarLegend_OvulationLabel"
+                )
                 Spacer()
-                LegendItem(color: .systemTeal.withAlphaComponent(0.3), labelKey: "calendar.legend.fertile")
+                LegendItem(
+                    color: .systemTeal.withAlphaComponent(0.3),
+                    labelKey: "calendar.legend.fertile",
+                    labelIdentifier: "CalendarLegend_FertileLabel"
+                )
                 Spacer()
-                LegendItem(color: .secondaryLabel, labelKey: "calendar.legend.logged")
+                LegendItem(
+                    color: .secondaryLabel,
+                    labelKey: "calendar.legend.logged",
+                    labelIdentifier: "CalendarLegend_LoggedLabel"
+                )
             }
         }
         .padding(14)
         .background(
             RoundedRectangle(cornerRadius: 14)
                 .fill(Color(.secondarySystemBackground).opacity(0.6))
         )
+        .accessibilityIdentifier("CalendarLegendView")
     }
 }
 
 struct LegendItem: View {
     let color: UIColor
     let labelKey: LocalizedStringKey
     var isCustomView: Bool = false
+    let labelIdentifier: String
 
     init(
         color: UIColor,
         labelKey: String,
-        isCustomView: Bool = false
+        isCustomView: Bool = false,
+        labelIdentifier: String
     ) {
         self.color = color
         self.labelKey = LocalizedStringKey(labelKey)
         self.isCustomView = isCustomView
+        self.labelIdentifier = labelIdentifier
     }
 
     var body: some View {
@@ -58,6 +85,8 @@ struct LegendItem: View {
                 .font(.caption2)
                 .foregroundColor(.primary)
         }
+        .accessibilityElement(children: .combine)
+        .accessibilityIdentifier(labelIdentifier)
     }
 }
 

CycleOneUITests/Tests/LocalizationUITests.swift

@@ -63,6 +63,59 @@ final class LocalizationUITests: XCTestCase {
         return settingsList
     }
 
+    @MainActor
+    private func assertLegendPeriodLabel(
+        in app: XCUIApplication,
+        expected: String,
+        timeout: TimeInterval = 15
+    ) {
+        UITestAppHarness.openTab(at: 0, in: app)
+
+        let legendRoot = UITestAppHarness.element(
+            withIdentifier: "CalendarLegendView",
+            in: app
+        )
+        XCTAssertTrue(legendRoot.waitForExistence(timeout: timeout))
+
+        let periodLabel = UITestAppHarness.element(
+            withIdentifier: "CalendarLegend_PeriodLabel",
+            in: app
+        )
+
+        let deadline = Date().addingTimeInterval(timeout)
+        var foundLocalizedLabel = false
+
+        while Date() < deadline {
+            if app.staticTexts[expected].exists {
+                foundLocalizedLabel = true
+                break
+            }
+
+            if periodLabel.exists, periodLabel.label.contains(expected) {
+                foundLocalizedLabel = true
+                break
+            }
+
+            if legendRoot.label.contains(expected) {
+                foundLocalizedLabel = true
+                break
+            }
+
+            let scrollView = app.scrollViews.firstMatch
+            if scrollView.exists {
+                scrollView.swipeUp()
+                scrollView.swipeDown()
+            }
+            _ = app.staticTexts[expected].waitForExistence(timeout: 0.2)
+        }
+
+        XCTAssertTrue(
+            foundLocalizedLabel,
+            "Expected legend period label '\(expected)' not found. Legend root label: '\(legendRoot.label)'"
+        )
+        XCTAssertFalse(app.staticTexts["calendar.legend.period"].exists)
+    }
+
     @MainActor
     func testSettingsLanguageSwitchToJapanese_updatesVisibleStrings() {
         let app = UITestAppHarness.launch(
@@ -101,17 +154,15 @@ final class LocalizationUITests: XCTestCase {
 
         let settingsList = openSettingsList(in: app)
         selectLanguage(in: app, settingsList: settingsList, candidates: ["Japanese", "日本語"])
+        XCTAssertTrue(app.tabBars.buttons["設定"].waitForExistence(timeout: 12))
 
-        UITestAppHarness.openTab(at: 0, in: app)
-        XCTAssertTrue(app.staticTexts["生理"].waitForExistence(timeout: 10))
-        XCTAssertFalse(app.staticTexts["calendar.legend.period"].exists)
+        assertLegendPeriodLabel(in: app, expected: "生理")
 
         let settingsListJapanese = openSettingsList(in: app)
         selectLanguage(in: app, settingsList: settingsListJapanese, candidates: ["English", "英語"])
+        XCTAssertTrue(app.tabBars.buttons["Settings"].waitForExistence(timeout: 12))
 
-        UITestAppHarness.openTab(at: 0, in: app)
-        XCTAssertTrue(app.staticTexts["Period"].waitForExistence(timeout: 10))
-        XCTAssertFalse(app.staticTexts["calendar.legend.period"].exists)
+        assertLegendPeriodLabel(in: app, expected: "Period")
     }
 
     @MainActor