refactor: remove imageDirectory from PrankLockerConfig and related tests

Author: SlashGordon

README.md

@@ -122,7 +122,6 @@ Settings are stored in `~/.prank-locker/config.json` (created on first run):
 {
     "activationShortcut": { "modifiers": ["control", "option", "command"], "keyCode": 37 },
     "deactivationSequence": "unlock",
-    "imageDirectory": "~/.prank-locker/images/",
     "imageIntervalSeconds": 3.0,
     "maxSimultaneousImages": 15,
     "failsafeTimeoutMinutes": 30,

Sources/ScreenPrankLocker/ConfigView.swift

@@ -5,6 +5,33 @@
 import SwiftUI
 import AppKit
 
+// A reusable component that encapsulates styling and hover logic
+struct HoverLink: View {
+    let title: String
+    let urlString: String
+
+    var body: some View {
+        // Safely unwrap the URL
+        if let url = URL(string: urlString) {
+            Link(destination: url) {
+                Text(title)
+                    .font(.system(size: 11, weight: .medium, design: .rounded))
+                    .foregroundColor(.blue)
+                    .underline()
+            }
+            .onHover { isHovered in
+                if isHovered {
+                    // Push the hand cursor onto the system cursor stack
+                    NSCursor.pointingHand.push()
+                } else {
+                    // Pop it off when the mouse leaves
+                    NSCursor.pop()
+                }
+            }
+        }
+    }
+}
+
 // MARK: - Theme
 
 private enum Theme {
@@ -531,24 +558,21 @@ private struct AboutView: View {
 
             VStack(spacing: 6) {
                 HStack(spacing: 12) {
-                    Link(destination: URL(string: "https://github.com/SlashGordon")!) {
-                        Text("SlashGordon")
-                            .font(.system(size: 11, weight: .medium, design: .rounded))
-                            .foregroundColor(Theme.subtleText)
-                    }
+                    HoverLink(
+                        title: "SlashGordon", 
+                        urlString: "https://github.com/SlashGordon"
+                    )
 
-                    Link(destination: URL(string: "https://www.slashgordon.link/")!) {
-                        Text("slashgordon.link")
-                            .font(.system(size: 11, weight: .medium, design: .rounded))
-                            .foregroundColor(Theme.subtleText)
-                    }
+                    HoverLink(
+                        title: "slashgordon.link", 
+                        urlString: "https://www.slashgordon.link/"
+                    )
                 }
 
-                Link(destination: URL(string: "mailto:slash.gordon.dev@gmail.com")!) {
-                    Text("slash.gordon.dev@gmail.com")
-                        .font(.system(size: 11, weight: .medium, design: .rounded))
-                        .foregroundColor(Theme.subtleText)
-                }
+                HoverLink(
+                    title: "slash.gordon.dev@gmail.com", 
+                    urlString: "mailto:slash.gordon.dev@gmail.com"
+                )
             }
 
             Button("Close") {

Sources/ScreenPrankLocker/Models.swift

@@ -126,7 +126,6 @@ enum ProtectionMode: String, Codable {
 struct PrankLockerConfig: Codable {
     var activationShortcut: KeyCombo
     var deactivationSequence: String
-    var imageDirectory: String
     var imageIntervalSeconds: TimeInterval
     var maxSimultaneousImages: Int
     var failsafeTimeoutMinutes: Int
@@ -147,7 +146,6 @@ struct PrankLockerConfig: Codable {
         let container = try decoder.container(keyedBy: CodingKeys.self)
         activationShortcut = try container.decode(KeyCombo.self, forKey: .activationShortcut)
         deactivationSequence = try container.decode(String.self, forKey: .deactivationSequence)
-        imageDirectory = try container.decode(String.self, forKey: .imageDirectory)
         imageIntervalSeconds = try container.decode(TimeInterval.self, forKey: .imageIntervalSeconds)
         maxSimultaneousImages = try container.decode(Int.self, forKey: .maxSimultaneousImages)
         failsafeTimeoutMinutes = try container.decode(Int.self, forKey: .failsafeTimeoutMinutes)
@@ -168,7 +166,6 @@ struct PrankLockerConfig: Codable {
 
     init(activationShortcut: KeyCombo,
          deactivationSequence: String,
-         imageDirectory: String,
          imageIntervalSeconds: TimeInterval,
          maxSimultaneousImages: Int,
          failsafeTimeoutMinutes: Int,
@@ -186,7 +183,6 @@ struct PrankLockerConfig: Codable {
          telegramChatID: String? = nil) {
         self.activationShortcut = activationShortcut
         self.deactivationSequence = deactivationSequence
-        self.imageDirectory = imageDirectory
         self.imageIntervalSeconds = imageIntervalSeconds
         self.maxSimultaneousImages = maxSimultaneousImages
         self.failsafeTimeoutMinutes = failsafeTimeoutMinutes
@@ -210,7 +206,6 @@ struct PrankLockerConfig: Codable {
             keyCode: 37  // 'L' key
         ),
         deactivationSequence: "unlock",
-        imageDirectory: "~/.prank-locker/images/",
         imageIntervalSeconds: 3.0,
         maxSimultaneousImages: 15,
         failsafeTimeoutMinutes: 30,

Tests/ScreenPrankLockerTests/PropertyTests/ConfigUIPropertyTests.swift

@@ -34,7 +34,7 @@ final class ConfigUIPropertyTests: XCTestCase {
         return PrankLockerConfig(
             activationShortcut: KeyCombo(modifiers: [.maskCommand], keyCode: 37),
             deactivationSequence: deactivationSequence,
-            imageDirectory: "~/.prank-locker/images/",
+
             imageIntervalSeconds: 3.0,
             maxSimultaneousImages: 15,
             failsafeTimeoutMinutes: failsafeTimeoutMinutes,

Tests/ScreenPrankLockerTests/UnitTests/ConfigurationManagerTests.swift

@@ -27,7 +27,6 @@ final class ConfigurationManagerTests: XCTestCase {
 
         let config = manager.config
         XCTAssertEqual(config.deactivationSequence, "unlock")
-        XCTAssertEqual(config.imageDirectory, "~/.prank-locker/images/")
         XCTAssertEqual(config.imageIntervalSeconds, 3.0)
         XCTAssertEqual(config.maxSimultaneousImages, 15)
         XCTAssertEqual(config.failsafeTimeoutMinutes, 30)
@@ -50,7 +49,6 @@ final class ConfigurationManagerTests: XCTestCase {
                 "keyCode": 12
             },
             "deactivationSequence": "opensesame",
-            "imageDirectory": "/tmp/my-images/",
             "imageIntervalSeconds": 5.0,
             "maxSimultaneousImages": 10,
             "failsafeTimeoutMinutes": 60
@@ -64,7 +62,7 @@ final class ConfigurationManagerTests: XCTestCase {
 
         let config = manager.config
         XCTAssertEqual(config.deactivationSequence, "opensesame")
-        XCTAssertEqual(config.imageDirectory, "/tmp/my-images/")
+
         XCTAssertEqual(config.imageIntervalSeconds, 5.0)
         XCTAssertEqual(config.maxSimultaneousImages, 10)
         XCTAssertEqual(config.failsafeTimeoutMinutes, 60)