Merge branch 'trunk' into mri-rbe

Author: titusfortner

.bazelrc

@@ -20,12 +20,16 @@ build --enable_runfiles
 build --flag_alias=pin_browsers=//common:pin_browsers
 build --flag_alias=headless=//common:headless
 
-# Set the default java toolchain
+# Set the default java toolchain.
+# When bumping these, also update java_runtime in //common/remote-build/java to match.
 build --java_language_version=25
 build --java_runtime_version=remotejdk_25
 build --tool_java_language_version=25
 build --tool_java_runtime_version=remotejdk_25
 
+# Silence protobuf sun.misc.Unsafe warnings from the JDK 25 Java compile workers.
+build --extra_toolchains=//common/remote-build/java:java-toolchain_definition
+
 # We target java 11 by default
 build --javacopt="--release 11"
 

.github/workflows/bazel.yml

@@ -171,8 +171,14 @@ jobs:
       - name: Setup Fluxbox and Xvfb
         if: inputs.needs-display && inputs.os == 'ubuntu'
         run: |
-          sudo apt-get update && sudo apt-get -y install fluxbox
+          sudo apt-get update && sudo apt-get -y install fluxbox x11-utils
           Xvfb :99 &
+          # X server must start before fluxbox
+          for _ in $(seq 1 30); do
+            xdpyinfo -display :99 >/dev/null 2>&1 && break
+            sleep 0.5
+          done
+          xdpyinfo -display :99 >/dev/null 2>&1 || { echo "::error::X server :99 failed to start"; exit 1; }
           fluxbox -display :99 &
           echo "DISPLAY=:99" >> "$GITHUB_ENV"
       - name: Set resolution
@@ -196,7 +202,7 @@ jobs:
       - name: Delete browsers and drivers
         if: inputs.os == 'ubuntu' || inputs.os == 'macos'
         run: ./scripts/github-actions/delete-browsers-drivers.sh
-      - name: Delete browsers and drivers (Windows)
+      - name: Delete drivers (Windows)
         if: inputs.os == 'windows'
         shell: pwsh
         run: ./scripts/github-actions/delete-browsers-drivers.ps1

.github/workflows/ci-python.yml

@@ -85,3 +85,19 @@ jobs:
       rerun-with-debug: true
       run: |
         bazel test --local_test_jobs 1 --flaky_test_attempts 3 //py:test-${{ matrix.browser }}
+
+  selenium-manager-tests:
+    name: Selenium Manager Tests
+    needs: build
+    uses: ./.github/workflows/bazel.yml
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [ubuntu, windows, macos]
+    with:
+      name: Integration Tests Selenium Manager (${{ matrix.os }})
+      needs-display: true
+      os: ${{ matrix.os }}
+      rerun-with-debug: true
+      run: |
+        bazel test --local_test_jobs 1 --flaky_test_attempts 3 --pin_browsers=false --build_tests_only --test_tag_filters=se-manager //py/...

Rakefile

@@ -143,13 +143,17 @@ task :format do |_task, arguments|
   Rake::Task['all:format'].invoke(*args)
 end
 
-desc 'Run linters (may auto-fix some issues; stricter checks than :format)'
-task :lint do
-  puts 'Linting shell scripts and GitHub Actions...'
+def lint_actions
   shellcheck = Bazel.execute('build', [], '@multitool//tools/shellcheck')
   Bazel.execute('run', ['--', '-shellcheck', shellcheck], '@multitool//tools/actionlint:cwd')
+end
 
-  Rake::Task['all:lint'].invoke
+desc 'Run linters (may auto-fix some issues; stricter checks than :format)'
+task :lint do
+  SeleniumRake.aggregate_errors(
+    shellcheck_and_actionlint: -> { lint_actions },
+    all: -> { Rake::Task['all:lint'].invoke }
+  )
 end
 
 # Legacy aliases - call namespaced tasks
@@ -215,24 +219,18 @@ namespace :all do
   desc 'Validate release credentials for all languages'
   task :check_credentials do |_task, arguments|
     args = arguments.to_a
-    failures = []
-    %w[java py rb dotnet node].each do |lang|
-      Rake::Task["#{lang}:check_credentials"].invoke(*args)
-    rescue StandardError => e
-      failures << "#{lang}: #{e.message}"
+    steps = %w[java py rb dotnet node].to_h do |lang|
+      [lang.to_sym, -> { Rake::Task["#{lang}:check_credentials"].invoke(*args) }]
     end
-    raise "Credential check failed:\n#{failures.join("\n")}" unless failures.empty?
+    SeleniumRake.aggregate_errors(**steps)
   end
 
   desc 'Verify all packages are published to their registries'
   task :verify do
-    failures = []
-    %w[java py rb dotnet node].each do |lang|
-      Rake::Task["#{lang}:verify"].invoke
-    rescue StandardError => e
-      failures << "#{lang}: #{e.message}"
+    steps = %w[java py rb dotnet node].to_h do |lang|
+      [lang.to_sym, -> { Rake::Task["#{lang}:verify"].invoke }]
     end
-    raise "Verification failed:\n#{failures.join("\n")}" unless failures.empty?
+    SeleniumRake.aggregate_errors(**steps)
   end
 
   desc 'Release all artifacts for all language bindings'
@@ -257,15 +255,10 @@ namespace :all do
 
   desc 'Run linters for all language bindings'
   task :lint do
-    all_langs = %w[java py rb dotnet node]
-    failures = []
-    all_langs.each do |lang|
-      puts "Linting #{lang}..."
-      Rake::Task["#{lang}:lint"].invoke
-    rescue StandardError => e
-      failures << "#{lang}: #{e.message}"
+    steps = %w[java py rb dotnet node].to_h do |lang|
+      [lang.to_sym, -> { Rake::Task["#{lang}:lint"].invoke }]
     end
-    raise "Lint failed:\n#{failures.join("\n")}" unless failures.empty?
+    SeleniumRake.aggregate_errors(**steps)
   end
 
   desc 'Update versions for all language bindings'

common/remote-build/java/BUILD.bazel

@@ -0,0 +1,23 @@
+load("@rules_java//toolchains:default_java_toolchain.bzl", "DEFAULT_TOOLCHAIN_CONFIGURATION", "default_java_toolchain")
+
+package(default_visibility = ["//visibility:public"])
+
+# Quiet protobuf's sun.misc.Unsafe warnings spammed by the JDK 25 compile workers.
+_SILENCE_UNSAFE_WARNING = ["--sun-misc-unsafe-memory-access=allow"]
+
+default_java_toolchain(
+    name = "java-toolchain",
+    configuration = DEFAULT_TOOLCHAIN_CONFIGURATION | {
+        "java_runtime": "@rules_java//toolchains:remotejdk_25",
+        "jvm_opts": DEFAULT_TOOLCHAIN_CONFIGURATION["jvm_opts"] + _SILENCE_UNSAFE_WARNING,
+        "turbine_jvm_opts": DEFAULT_TOOLCHAIN_CONFIGURATION["turbine_jvm_opts"] + _SILENCE_UNSAFE_WARNING,
+    },
+    toolchain_definition = False,
+)
+
+# No version target_setting, so it applies regardless of --java_language_version.
+toolchain(
+    name = "java-toolchain_definition",
+    toolchain = ":java-toolchain",
+    toolchain_type = "@bazel_tools//tools/jdk:toolchain_type",
+)

common/repositories.bzl

@@ -11,8 +11,8 @@ def pin_browsers():
 
     http_archive(
         name = "linux_firefox",
-        url = "https://ftp.mozilla.org/pub/firefox/releases/151.0.2/linux-x86_64/en-US/firefox-151.0.2.tar.xz",
-        sha256 = "1f77a1aacc2a0ccbb36998875f04a9c22229103dc35cb4bbb89784f0809161e0",
+        url = "https://ftp.mozilla.org/pub/firefox/releases/151.0.3/linux-x86_64/en-US/firefox-151.0.3.tar.xz",
+        sha256 = "b2405272cc3a8dde0fadeb5cea2b1fb03fc0a181b3015bd60985a63b04e70ed7",
         build_file_content = """
 load("@aspect_rules_js//js:defs.bzl", "js_library")
 package(default_visibility = ["//visibility:public"])
@@ -33,8 +33,8 @@ js_library(
 
     dmg_archive(
         name = "mac_firefox",
-        url = "https://ftp.mozilla.org/pub/firefox/releases/151.0.2/mac/en-US/Firefox%20151.0.2.dmg",
-        sha256 = "232631dd169b8a4fc661a7a6756da3910cc669ba34b81858b7915ca138752e79",
+        url = "https://ftp.mozilla.org/pub/firefox/releases/151.0.3/mac/en-US/Firefox%20151.0.3.dmg",
+        sha256 = "60d5cb29412b161c76ecc58f3f8a960cd0048081cf84c6fe91579f1957564277",
         build_file_content = """
 load("@aspect_rules_js//js:defs.bzl", "js_library")
 package(default_visibility = ["//visibility:public"])
@@ -50,8 +50,8 @@ js_library(
 
     http_archive(
         name = "linux_beta_firefox",
-        url = "https://ftp.mozilla.org/pub/firefox/releases/152.0b5/linux-x86_64/en-US/firefox-152.0b5.tar.xz",
-        sha256 = "c9215e26c5ee9d08ab7afbd04b7605f18a77beba062d3c013629c27860d5c106",
+        url = "https://ftp.mozilla.org/pub/firefox/releases/152.0b8/linux-x86_64/en-US/firefox-152.0b8.tar.xz",
+        sha256 = "930f7979bee3b06962fc0d468ee96ff3d5cdaa8c6d48d204e324fdd55315b18c",
         build_file_content = """
 load("@aspect_rules_js//js:defs.bzl", "js_library")
 package(default_visibility = ["//visibility:public"])
@@ -72,8 +72,8 @@ js_library(
 
     dmg_archive(
         name = "mac_beta_firefox",
-        url = "https://ftp.mozilla.org/pub/firefox/releases/152.0b5/mac/en-US/Firefox%20152.0b5.dmg",
-        sha256 = "595f550d5e7c6230ec783777a6b4de287a73ea87b8fad739ad9c301f2d899ca0",
+        url = "https://ftp.mozilla.org/pub/firefox/releases/152.0b8/mac/en-US/Firefox%20152.0b8.dmg",
+        sha256 = "ac32904e4db06c9476b0fffc54ed86a9415911619b971f3bd9b45c4eab4f4e00",
         build_file_content = """
 load("@aspect_rules_js//js:defs.bzl", "js_library")
 package(default_visibility = ["//visibility:public"])
@@ -89,8 +89,8 @@ js_library(
 
     http_archive(
         name = "linux_geckodriver",
-        url = "https://github.com/mozilla/geckodriver/releases/download/v0.36.0/geckodriver-v0.36.0-linux64.tar.gz",
-        sha256 = "0bde38707eb0a686a20c6bd50f4adcc7d60d4f73c60eb83ee9e0db8f65823e04",
+        url = "https://github.com/mozilla/geckodriver/releases/download/v0.37.0/geckodriver-v0.37.0-linux64.tar.gz",
+        sha256 = "90d4e33bd9816684400c160d1309aaffec23a3f65103511d5a62d8501062e548",
         build_file_content = """
 load("@aspect_rules_js//js:defs.bzl", "js_library")
 package(default_visibility = ["//visibility:public"])
@@ -106,8 +106,8 @@ js_library(
 
     http_archive(
         name = "mac_geckodriver",
-        url = "https://github.com/mozilla/geckodriver/releases/download/v0.36.0/geckodriver-v0.36.0-macos-aarch64.tar.gz",
-        sha256 = "c045c8c0d859e6045defbb1c31b37ebeb3c942fc61daaf11e21fc634f2d71c52",
+        url = "https://github.com/mozilla/geckodriver/releases/download/v0.37.0/geckodriver-v0.37.0-macos-aarch64.tar.gz",
+        sha256 = "369165b614164f8adc43d8e017f55fe1ced208afe474be2f0cc1c01fc6529725",
         build_file_content = """
 load("@aspect_rules_js//js:defs.bzl", "js_library")
 package(default_visibility = ["//visibility:public"])
@@ -123,10 +123,10 @@ js_library(
 
     pkg_archive(
         name = "mac_edge",
-        url = "https://msedge.sf.dl.delivery.mp.microsoft.com/filestreamingservice/files/eff0de67-2c4d-45ce-b8e2-f1ce8c69c595/MicrosoftEdge-148.0.3967.96.pkg",
-        sha256 = "d2056a5eb9972b7d7a3cb34fbfa313b43c2ddcd9c7282b1bbba7a48b55028087",
+        url = "https://msedge.sf.dl.delivery.mp.microsoft.com/filestreamingservice/files/20523184-11bb-436b-a567-0e33fcaff5f2/MicrosoftEdge-149.0.4022.52.pkg",
+        sha256 = "d5c2e2616d8f397bda51b13fbcb87497cbc988662add896ffac4a093dd144195",
         move = {
-            "MicrosoftEdge-148.0.3967.96.pkg/Payload/Microsoft Edge.app": "Edge.app",
+            "MicrosoftEdge-149.0.4022.52.pkg/Payload/Microsoft Edge.app": "Edge.app",
         },
         build_file_content = """
 load("@aspect_rules_js//js:defs.bzl", "js_library")
@@ -143,8 +143,8 @@ js_library(
 
     deb_archive(
         name = "linux_edge",
-        url = "https://packages.microsoft.com/repos/edge/pool/main/m/microsoft-edge-stable/microsoft-edge-stable_148.0.3967.96-1_amd64.deb",
-        sha256 = "ff447b27cb72767e033d38c5814709bd3b1eccadb32ac2a45f0fffdea8a5af49",
+        url = "https://packages.microsoft.com/repos/edge/pool/main/m/microsoft-edge-stable/microsoft-edge-stable_149.0.4022.52-1_amd64.deb",
+        sha256 = "de51617f1912f343f9f5d934d25a41a7ef0820552f4842551864df020871c388",
         build_file_content = """
 load("@aspect_rules_js//js:defs.bzl", "js_library")
 package(default_visibility = ["//visibility:public"])
@@ -165,8 +165,8 @@ js_library(
 
     http_archive(
         name = "linux_edgedriver",
-        url = "https://msedgedriver.microsoft.com/148.0.3967.96/edgedriver_linux64.zip",
-        sha256 = "b4f53b446acd6801396117eee46bdd100ea8a6110e6c1d8d3bb421d8dff4d5b8",
+        url = "https://msedgedriver.microsoft.com/149.0.4022.52/edgedriver_linux64.zip",
+        sha256 = "edf675b58fd133c0a36d9575f37a2b71ca6bf9e299c188bce89245a96dd3648b",
         build_file_content = """
 load("@aspect_rules_js//js:defs.bzl", "js_library")
 package(default_visibility = ["//visibility:public"])
@@ -182,8 +182,8 @@ js_library(
 
     http_archive(
         name = "mac_edgedriver",
-        url = "https://msedgedriver.microsoft.com/148.0.3967.96/edgedriver_mac64_m1.zip",
-        sha256 = "934a9aa94bd3faa60773507e65c3ea75f45d571bf24a229256638f9c88bf97aa",
+        url = "https://msedgedriver.microsoft.com/149.0.4022.52/edgedriver_mac64_m1.zip",
+        sha256 = "1433027e3ef2bb847ca1ad77cb5235d7ef215fea287827ecdd644d0c69435fb3",
         build_file_content = """
 load("@aspect_rules_js//js:defs.bzl", "js_library")
 package(default_visibility = ["//visibility:public"])
@@ -199,8 +199,8 @@ js_library(
 
     http_archive(
         name = "linux_chrome",
-        url = "https://storage.googleapis.com/chrome-for-testing-public/148.0.7778.178/linux64/chrome-linux64.zip",
-        sha256 = "05b6843867b4ee40f280327b748397a158b84ccbe20b94c3e89740d15422988f",
+        url = "https://storage.googleapis.com/chrome-for-testing-public/149.0.7827.54/linux64/chrome-linux64.zip",
+        sha256 = "a77e3ba8fa8cf299a1a980313a162ea1a5d33297f632d5d3c7f553f7cf6780d4",
         build_file_content = """
 load("@aspect_rules_js//js:defs.bzl", "js_library")
 package(default_visibility = ["//visibility:public"])
@@ -220,8 +220,8 @@ js_library(
     )
     http_archive(
         name = "mac_chrome",
-        url = "https://storage.googleapis.com/chrome-for-testing-public/148.0.7778.178/mac-arm64/chrome-mac-arm64.zip",
-        sha256 = "2d6a26edcbdd39d38ddfe7a0f11cb315eea7d0c5bbf2e3200ecdaa2855bc2bf5",
+        url = "https://storage.googleapis.com/chrome-for-testing-public/149.0.7827.54/mac-arm64/chrome-mac-arm64.zip",
+        sha256 = "376b22526a92345db188f8750be8a5abc45d1c8dda3805bfe89bf3327a10062f",
         strip_prefix = "chrome-mac-arm64",
         patch_cmds = [
             "mv 'Google Chrome for Testing.app' Chrome.app",
@@ -241,8 +241,8 @@ js_library(
     )
     http_archive(
         name = "linux_chromedriver",
-        url = "https://storage.googleapis.com/chrome-for-testing-public/148.0.7778.178/linux64/chromedriver-linux64.zip",
-        sha256 = "8fd9b1efe5c97191690d1e90f5d61eb323d82b44e38da09e65fecf9bbed86730",
+        url = "https://storage.googleapis.com/chrome-for-testing-public/149.0.7827.54/linux64/chromedriver-linux64.zip",
+        sha256 = "27a25d270195552a75e72c86d425b39e4bd1da51d7a6df9fc9071629e3a0acbf",
         strip_prefix = "chromedriver-linux64",
         build_file_content = """
 load("@aspect_rules_js//js:defs.bzl", "js_library")
@@ -259,8 +259,8 @@ js_library(
 
     http_archive(
         name = "mac_chromedriver",
-        url = "https://storage.googleapis.com/chrome-for-testing-public/148.0.7778.178/mac-arm64/chromedriver-mac-arm64.zip",
-        sha256 = "7be431042c78b6452ee0684afa2e3f0838653266503557513613362aeea7a4b8",
+        url = "https://storage.googleapis.com/chrome-for-testing-public/149.0.7827.54/mac-arm64/chromedriver-mac-arm64.zip",
+        sha256 = "58cb81188172ecf2db41f7704538942017ebc9e1bdb822151f9721c7066849c2",
         strip_prefix = "chromedriver-mac-arm64",
         build_file_content = """
 load("@aspect_rules_js//js:defs.bzl", "js_library")
@@ -277,8 +277,8 @@ js_library(
 
     http_archive(
         name = "linux_beta_chrome",
-        url = "https://storage.googleapis.com/chrome-for-testing-public/149.0.7827.54/linux64/chrome-linux64.zip",
-        sha256 = "a77e3ba8fa8cf299a1a980313a162ea1a5d33297f632d5d3c7f553f7cf6780d4",
+        url = "https://storage.googleapis.com/chrome-for-testing-public/150.0.7871.5/linux64/chrome-linux64.zip",
+        sha256 = "71b143f17eb6eeefb07bcee867f42d39942940b8e6bb57072410235a5fd7215c",
         build_file_content = """
 load("@aspect_rules_js//js:defs.bzl", "js_library")
 package(default_visibility = ["//visibility:public"])
@@ -298,8 +298,8 @@ js_library(
     )
     http_archive(
         name = "mac_beta_chrome",
-        url = "https://storage.googleapis.com/chrome-for-testing-public/149.0.7827.54/mac-arm64/chrome-mac-arm64.zip",
-        sha256 = "376b22526a92345db188f8750be8a5abc45d1c8dda3805bfe89bf3327a10062f",
+        url = "https://storage.googleapis.com/chrome-for-testing-public/150.0.7871.5/mac-arm64/chrome-mac-arm64.zip",
+        sha256 = "24975dcc97ede4093437e84d8a05d270a7cc176e86d9fd64ad91fc705694d20e",
         strip_prefix = "chrome-mac-arm64",
         patch_cmds = [
             "mv 'Google Chrome for Testing.app' Chrome.app",
@@ -319,8 +319,8 @@ js_library(
     )
     http_archive(
         name = "linux_beta_chromedriver",
-        url = "https://storage.googleapis.com/chrome-for-testing-public/149.0.7827.54/linux64/chromedriver-linux64.zip",
-        sha256 = "27a25d270195552a75e72c86d425b39e4bd1da51d7a6df9fc9071629e3a0acbf",
+        url = "https://storage.googleapis.com/chrome-for-testing-public/150.0.7871.5/linux64/chromedriver-linux64.zip",
+        sha256 = "98552d432041578e922d91065fcee2536ececa6b3c3b8a9a01686636bca8763a",
         strip_prefix = "chromedriver-linux64",
         build_file_content = """
 load("@aspect_rules_js//js:defs.bzl", "js_library")
@@ -337,8 +337,8 @@ js_library(
 
     http_archive(
         name = "mac_beta_chromedriver",
-        url = "https://storage.googleapis.com/chrome-for-testing-public/149.0.7827.54/mac-arm64/chromedriver-mac-arm64.zip",
-        sha256 = "58cb81188172ecf2db41f7704538942017ebc9e1bdb822151f9721c7066849c2",
+        url = "https://storage.googleapis.com/chrome-for-testing-public/150.0.7871.5/mac-arm64/chromedriver-mac-arm64.zip",
+        sha256 = "144c0245b33c58b62b31a120b008a677977400c7982729a86823b22580510710",
         strip_prefix = "chromedriver-mac-arm64",
         build_file_content = """
 load("@aspect_rules_js//js:defs.bzl", "js_library")

dotnet/src/webdriver/BiDi/Broker.cs

@@ -263,7 +263,7 @@ private void ProcessReceivedMessage(ReadOnlySpan<byte> data)
                 var propName = reader.GetString()!;
                 reader.Read();
                 additionalMessageData ??= [];
-                additionalMessageData[propName] = JsonSerializer.Deserialize<JsonElement>(ref reader);
+                additionalMessageData[propName] = JsonElement.ParseValue(ref reader);
             }
 
             reader.Skip();

dotnet/src/webdriver/BiDi/Input/SourceActions.cs

@@ -41,14 +41,7 @@ public interface ISourceAction;
 public interface IKeySourceAction : ISourceAction;
 
 public sealed record KeySourceActions(string Id, ImmutableArray<IKeySourceAction> Actions)
-    : SourceActions<IKeySourceAction>(Id, Actions)
-{
-    [Obsolete("This helper method will be removed in a future version. Use KeyDownAction and KeyUpAction directly instead.")]
-    public KeySourceActions Type(string text) => this with
-    {
-        Actions = [.. Actions, .. text.SelectMany<char, IKeySourceAction>(c => [new KeyDownAction(c), new KeyUpAction(c)])]
-    };
-}
+    : SourceActions<IKeySourceAction>(Id, Actions);
 
 [JsonPolymorphic(TypeDiscriminatorPropertyName = "type")]
 [JsonDerivedType(typeof(PauseAction), "pause")]