Fix clicking book from translations page (#3394)

* fix(get text): fix typo: params -> param

* fix(translation api): fix old (pre rtl) ven param by the new format.

* refactor(translations api): refactor building the url and use urlencode and Ref url method to ensure url encoding.

Author: YishaiGlasner

reader/views.py

@@ -4674,7 +4674,7 @@ def translations_api(request, lang=None):
         aggregation_query.append({"$match": {"vstate.flags.enComplete": True}})
 
     aggregation_query.extend([{"$project": {"index.dependence": 1, "index.order": 1, "index.collective_title": 1,
-                                            "index.title": 1, "index.order": 1,
+                                            "index.title": 1, "index.order": 1, "languageFamilyName": 1,
                                             "versionTitle": 1, "language": 1, "title": 1, "index.categories": 1,
                                             "priority": 1, "vstate.first_section_ref": 1}},
                               {"$sort": {"index.order.0": 1, "index.order.1": 1, "priority": -1}}])
@@ -4722,7 +4722,10 @@ def translations_api(request, lang=None):
                             continue
                 else:
                     to_add["title"] = my_index_info["title"]
-                    to_add["url"] = f'/{my_index["vstate"][0]["first_section_ref"].replace(":", ".")}?{"ven=" + my_index["versionTitle"] if my_index["language"] == "en" else "vhe=" + my_index["versionTitle"]}&lang=bi'
+                    ref = Ref(my_index["vstate"][0]["first_section_ref"]).url()
+                    version_param = f'{my_index["languageFamilyName"]}|{my_index["versionTitle"]}'
+                    params = urllib.parse.urlencode({'ven': version_param, "lang": "bi"})
+                    to_add["url"] = f'/{ref}?{params}'
 
                 if "order" in my_index["index"][0]:
                     to_add["order"] = my_index["index"][0]["order"]

static/js/sefaria/util.js

@@ -62,7 +62,7 @@ class Util {
       }
     }
     static getObjectFromUrlParam(param) {
-      const params = (params) ? param.split('|') : '';
+      const params = param ? param.split('|') : '';
       return {languageFamilyName: params[0], versionTitle: params[1]};
     }
     static decodeVtitle(vtitle) {