migrate co2 budgets feature from pypsa-at#2186
Draft
pworschischek-aggmag wants to merge 3 commits into
Draft
Conversation
| """ | ||
| from scripts.prepare_sector_network import determine_emission_sectors | ||
|
|
||
| national_co2_budgets = snakemake.config["solving"]["constraints"][ |
Contributor
Author
There was a problem hiding this comment.
use rule param instead
| links = n.links | ||
|
|
||
| for ct, yearly_percent in national_co2_budgets.items(): | ||
| if investment_year in yearly_percent: |
Contributor
Author
There was a problem hiding this comment.
- logic flip?
- missing interpolation logic?
| ] | ||
| aviation_total = aviation_domestic + aviation_international | ||
| domestic_aviation_factor = ( | ||
| aviation_domestic / aviation_total if aviation_total else 0.0 |
Contributor
Author
There was a problem hiding this comment.
simplify to result=0.0; if aviation_total > 0: results=divide
| n.model["Link-p"] | ||
| .loc[:, aviation_links.index] | ||
| # 'co2 atmosphere' is assumed to be at bus2 for aviation links | ||
| .mul(aviation_links["efficiency2"]) |
Contributor
Author
There was a problem hiding this comment.
untested assumption
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
Migrates the PyPSA-AT CO2 budget constraint to open a PR in PyPSA-Eur upstream.
Checklist
Required:
doc/release_notes.rst.scripts/lib/validation.doc/*.rstfiles.