Skip to content

Fix estimation for sequestration potentials #2086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
toniseibold wants to merge 3 commits into
base: master
Choose a base branch
from
+7 −2
Open

Fix estimation for sequestration potentials #2086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
77af95a
remove 'conservative estimate Mt from config to avoid double counting…
toniseibold Feb 19, 2026
191e9a3
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 19, 2026
debca38
change schema defaults
toniseibold Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion config/config.default.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -851,7 +851,6 @@ sector:
regional_co2_sequestration_potential:
enable: true
attribute:
- conservative estimate Mt
- conservative estimate GAS Mt
- conservative estimate OIL Mt
- conservative estimate aquifer Mt
Expand Down
7 changes: 7 additions & 0 deletions scripts/build_co2_sequestration_potentials.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,4 +320,11 @@ def merge_maps(

gdf = merge_maps(traps_map, storage_map)

types = [" OIL", " GAS", " aquifer", ""]

@lisazeyen lisazeyen May 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be either just the high-density storage or the conservative storage potential

Suggested change
types = [" OIL", " GAS", " aquifer", ""]
types = [" OIL", " GAS", " aquifer"]

@fneum fneum May 12, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @lisazeyen! I agree with the change.

for t in types:
opt_col = f"optimistic estimate{t} Mt"
neu_col = f"neutral estimate{t} Mt"

gdf[opt_col] = gdf[[opt_col, neu_col]].max(axis=1)
Comment on lines +324 to +328

@fneum fneum May 12, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still necessary one @lisazeyen 's suggested changes are implemented? I would avoid that "correction" and work with the actual values in the dataset if possible.


gdf.to_file(snakemake.output[0])
1 change: 0 additions & 1 deletion scripts/lib/validation/config/sector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -706,7 +706,6 @@ class SectorConfig(BaseModel):
default_factory=lambda: {
"enable": True,
"attribute": [
"conservative estimate Mt",
"conservative estimate GAS Mt",
"conservative estimate OIL Mt",
"conservative estimate aquifer Mt",
Expand Down