test: log warning when url-use-legacy-target-names is enabled

Author: laurenceisla

src/PostgREST/Logger.hs

@@ -86,7 +86,7 @@ observationLogger loggerState logLevel obs = case obs of
     when (shouldLogResponse logLevel status) $
       logWithZTime loggerState $ observationMessages o
   o@LegacyTargetNameWarningObs {} ->
-    when (logLevel >= LogWarn) $ do
+    when (logLevel >= LogError) $ do
       logWithZTime loggerState $ observationMessages o
   o@PoolRequest ->
     when (logLevel >= LogDebug) $ do

test/io/__snapshots__/test_cli/test_schema_cache_snapshot[dbRelationships].yaml

@@ -1,7 +1,59 @@
+- - - qiName: awards
+      qiSchema: public
+    - public
+  - - relCardinality:
+        relColumns:
+        - - director_id
+          - id
+        relCons: awards_director_id_fkey
+        tag: M2O
+      relFTableIsView: false
+      relForeignTable:
+        qiName: directors
+        qiSchema: public
+      relIsSelf: false
+      relTable:
+        qiName: awards
+        qiSchema: public
+      relTableIsView: false
+      tag: Relationship
+    - relCardinality:
+        relColumns:
+        - - film_id
+          - id
+        relCons: awards_film_id_fkey
+        tag: M2O
+      relFTableIsView: false
+      relForeignTable:
+        qiName: films
+        qiSchema: public
+      relIsSelf: false
+      relTable:
+        qiName: awards
+        qiSchema: public
+      relTableIsView: false
+      tag: Relationship
+
 - - - qiName: directors
       qiSchema: public
     - public
   - - relCardinality:
+        relColumns:
+        - - id
+          - director_id
+        relCons: awards_director_id_fkey
+        tag: O2M
+      relFTableIsView: false
+      relForeignTable:
+        qiName: awards
+        qiSchema: public
+      relIsSelf: false
+      relTable:
+        qiName: directors
+        qiSchema: public
+      relTableIsView: false
+      tag: Relationship
+    - relCardinality:
         relColumns:
         - - id
           - director_id
@@ -22,6 +74,22 @@
       qiSchema: public
     - public
   - - relCardinality:
+        relColumns:
+        - - id
+          - film_id
+        relCons: awards_film_id_fkey
+        tag: O2M
+      relFTableIsView: false
+      relForeignTable:
+        qiName: awards
+        qiSchema: public
+      relIsSelf: false
+      relTable:
+        qiName: films
+        qiSchema: public
+      relTableIsView: false
+      tag: Relationship
+    - relCardinality:
         relColumns:
         - - director_id
           - id

test/io/__snapshots__/test_cli/test_schema_cache_snapshot[dbTables].yaml

@@ -126,6 +126,64 @@
     tableSchema: public
     tableUpdatable: false
 
+- - qiName: awards
+    qiSchema: public
+  - tableColumns:
+      director_id:
+        colDefault: null
+        colDescription: null
+        colEnum: []
+        colMaxLen: null
+        colName: director_id
+        colNominalType: integer
+        colNullable: true
+        colType: integer
+      film_id:
+        colDefault: null
+        colDescription: null
+        colEnum: []
+        colMaxLen: null
+        colName: film_id
+        colNominalType: integer
+        colNullable: true
+        colType: integer
+      id:
+        colDefault: null
+        colDescription: null
+        colEnum: []
+        colMaxLen: null
+        colName: id
+        colNominalType: integer
+        colNullable: false
+        colType: integer
+      name:
+        colDefault: null
+        colDescription: null
+        colEnum: []
+        colMaxLen: null
+        colName: name
+        colNominalType: text
+        colNullable: true
+        colType: text
+      year:
+        colDefault: null
+        colDescription: null
+        colEnum: []
+        colMaxLen: null
+        colName: year
+        colNominalType: integer
+        colNullable: true
+        colType: integer
+    tableDeletable: true
+    tableDescription: null
+    tableInsertable: true
+    tableIsView: false
+    tableName: awards
+    tablePKCols:
+    - id
+    tableSchema: public
+    tableUpdatable: true
+
 - - qiName: films
     qiSchema: public
   - tableColumns:

test/io/fixtures/privileges.sql

@@ -3,7 +3,7 @@ GRANT USAGE ON SCHEMA test TO postgrest_test_anonymous;
 
 GRANT SELECT ON authors_only TO postgrest_test_author;
 GRANT SELECT ON projects TO postgrest_test_anonymous, postgrest_test_w_superuser_settings;
-GRANT SELECT ON directors, films TO postgrest_test_anonymous, postgrest_test_w_superuser_settings;
+GRANT SELECT ON directors, films, awards TO postgrest_test_anonymous, postgrest_test_w_superuser_settings;
 
 GRANT ALL ON cats TO postgrest_test_anonymous;
 GRANT ALL ON items_w_isolation_level TO postgrest_test_anonymous, postgrest_test_repeatable_read, postgrest_test_serializable;

test/io/fixtures/schema.sql

@@ -25,6 +25,14 @@ CREATE TABLE films (
     on delete cascade
 );
 
+CREATE TABLE awards (
+  id int primary key,
+  name text,
+  year int,
+  film_id int references films(id),
+  director_id int references directors(id)
+);
+
 -- data to test resource embedding
 TRUNCATE TABLE directors CASCADE;
 INSERT INTO directors

test/io/test_io.py

@@ -2178,3 +2178,27 @@ def test_positive_pool_metric(defaultenv):
                 ).group(1)
             )
             assert metrics >= 0
+
+
+@pytest.mark.parametrize("enabled", ["true", "false"])
+def test_use_legacy_target_names(enabled, defaultenv):
+    "Show a warning when a target name is used instead of an alias, only when config is enabled"
+
+    env = {**defaultenv, "PGRST_URL_USE_LEGACY_TARGET_NAMES": enabled}
+
+    with run(env=env) as postgrest:
+        response = postgrest.session.get(
+            "/directors?select=name,all_films:films(title),awards_2026:awards(name)&films.order=title&awards.year=eq.2026"
+        )
+
+        output = postgrest.read_stdout(nlines=2)
+
+        log_err_warning = "WARNING: Embedded resource was referenced by relation name even though it has an alias. This is deprecated and will stop working in a future release."
+        log_err_hint = "Please update the filters that use `films` to `all_films`, `awards` to `awards_2026` in `GET /directors?select=name,all_films:films(title),awards_2026:awards(name)&films.order=title&awards.year=eq.2026`"
+
+        if enabled == "false":
+            assert response.status_code == 400
+            assert any(log_err_warning and log_err_hint not in line for line in output)
+        else:
+            assert response.status_code == 200
+            assert any(log_err_warning and log_err_hint in line for line in output)