Skip to content

Commit c23ac09

Browse files
committed
Use Fast Float instead of std charconv
1 parent cbc0022 commit c23ac09

3 files changed

Lines changed: 4933 additions & 3 deletions

File tree

.github/workflows/build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ jobs:
5656
key: ${{ matrix.os }}-${{ matrix.compiler }}-${{ matrix.config }}-build-${{ secrets.VCACHE}}
5757

5858
- name: Configure
59-
run: cmake -GNinja -S . -B Build -DCMAKE_BUILD_TYPE=${{ matrix.config }} -DCMAKE_OSX_DEPLOYMENT_TARGET=13.3 # FIX: Enable convchar library on macos
59+
run: cmake -GNinja -S . -B Build -DCMAKE_BUILD_TYPE=${{ matrix.config }}
6060

6161
- name: Build
6262
run: cmake --build Build --config ${{ matrix.config }}

Src/Core/StringView.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
#include "Pipe/Core/StringView.h"
44

5-
#include <charconv>
5+
#include "Pipe/Extern/fast_float.h"
66

77

88
namespace p::Strings
@@ -11,7 +11,7 @@ namespace p::Strings
1111
TOptional<T> InternalToNumber(StringView str)
1212
{
1313
T val;
14-
if (std::from_chars(str.data(), str.data() + str.size(), val).ec == std::errc{})
14+
if (fast_float::from_chars(str.data(), str.data() + str.size(), val).ec == std::errc{})
1515
{
1616
return val;
1717
}

0 commit comments

Comments
 (0)