refactor: improve code quality and add more control

Author: Ghass-M

.github/workflows/trigger-PR-pipeline.yml

@@ -1,5 +1,7 @@
 name: Pipeline PR push
-
+permissions:
+  contents: read
+  pull-requests: write
 on:
   pull_request:
 

src/ByteSync.ServerCommon/Commands/Authentication/AuthenticateCommandHandler.cs

@@ -74,7 +74,7 @@ public async Task<InitialAuthenticationResponse> Handle(AuthenticateRequest requ
             return client;
         });
 
-        BindSerialResponse bindSerialResponse = await BindSerial(result.Element!, request.LoginData);
+        BindSerialResponse bindSerialResponse = await BindSerial(result.Element!);
 
         var endPoint = _byteSyncEndpointFactory.BuildByteSyncEndpoint(result.Element!, bindSerialResponse.ProductSerialDescription);
 
@@ -84,38 +84,13 @@ public async Task<InitialAuthenticationResponse> Handle(AuthenticateRequest requ
         return authenticationResponse;
     }
 
-    private Task<BindSerialResponse> BindSerial(Client _, LoginData loginData)
+    private Task<BindSerialResponse> BindSerial(Client _)
     {
         BindSerialResponseStatus bindSerialResponseStatus;
-        ProductSerial? productSerial;
 
         bindSerialResponseStatus = BindSerialResponseStatus.NotSupplied;
-        productSerial = null;
 
         ProductSerialDescription? productSerialDescription = null;
-        if (productSerial != null)
-        {
-            SerialStatus serialStatus;
-            if (productSerial.IsExpired)
-            {
-                serialStatus = SerialStatus.Expired;
-            }
-            else
-            {
-                bool bindOK = true;
-
-                if (bindOK)
-                {
-                    serialStatus = SerialStatus.OK;
-                }
-                else
-                {
-                    serialStatus = SerialStatus.NoAvailableSlot;
-                }
-            }
-
-            productSerialDescription = BuildProductSerialDescription(productSerial, serialStatus);
-        }
 
         BindSerialResponse response = new BindSerialResponse(bindSerialResponseStatus, productSerialDescription);