-
Notifications
You must be signed in to change notification settings - Fork 10
Expand file tree
/
Copy pathFileUploadWorker.cs
More file actions
522 lines (465 loc) · 19.7 KB
/
Copy pathFileUploadWorker.cs
File metadata and controls
522 lines (465 loc) · 19.7 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
using System.Diagnostics;
using System.Threading;
using System.Threading.Channels;
using Autofac.Features.Indexed;
using ByteSync.Business.Communications.Transfers;
using ByteSync.Common.Business.Communications.Transfers;
using ByteSync.Common.Business.SharedFiles;
using ByteSync.Interfaces;
using ByteSync.Interfaces.Controls.Communications;
using ByteSync.Interfaces.Controls.Communications.Http;
using Polly.Retry;
namespace ByteSync.Services.Communications.Transfers.Uploading;
public class FileUploadWorker : IFileUploadWorker
{
private readonly IPolicyFactory _policyFactory;
private readonly IFileTransferApiClient _fileTransferApiClient;
private readonly ILogger<FileUploadWorker> _logger;
private readonly SharedFileDefinition _sharedFileDefinition;
private readonly ManualResetEvent _exceptionOccurred;
private readonly ManualResetEvent _uploadingIsFinished;
private readonly IIndex<StorageProvider, IUploadStrategy> _strategies;
private readonly SemaphoreSlim _semaphoreSlim;
private readonly IAdaptiveUploadController _adaptiveUploadController;
private readonly SemaphoreSlim _uploadSlots;
private CancellationTokenSource CancellationTokenSource { get; }
private static int _workerTaskCounter;
private int _remainingSlicesDrained;
public FileUploadWorker(
IPolicyFactory policyFactory,
IFileTransferApiClient fileTransferApiClient,
SharedFileDefinition sharedFileDefinition,
SemaphoreSlim semaphoreSlim,
ManualResetEvent exceptionOccurred,
IIndex<StorageProvider, IUploadStrategy> strategies,
ManualResetEvent uploadingIsFinished,
ILogger<FileUploadWorker> logger,
IAdaptiveUploadController adaptiveUploadController,
SemaphoreSlim uploadSlots)
{
_policyFactory = policyFactory;
_fileTransferApiClient = fileTransferApiClient;
_sharedFileDefinition = sharedFileDefinition;
_semaphoreSlim = semaphoreSlim;
_exceptionOccurred = exceptionOccurred;
_uploadingIsFinished = uploadingIsFinished;
_strategies = strategies;
_logger = logger;
_adaptiveUploadController = adaptiveUploadController;
_uploadSlots = uploadSlots;
CancellationTokenSource = new CancellationTokenSource();
}
// Backward-compatible overload for tests and callers not providing uploadSlots
public FileUploadWorker(
IPolicyFactory policyFactory,
IFileTransferApiClient fileTransferApiClient,
SharedFileDefinition sharedFileDefinition,
SemaphoreSlim semaphoreSlim,
ManualResetEvent exceptionOccurred,
IIndex<StorageProvider, IUploadStrategy> strategies,
ManualResetEvent uploadingIsFinished,
ILogger<FileUploadWorker> logger,
IAdaptiveUploadController adaptiveUploadController)
: this(
policyFactory,
fileTransferApiClient,
sharedFileDefinition,
semaphoreSlim,
exceptionOccurred,
strategies,
uploadingIsFinished,
logger,
adaptiveUploadController,
new SemaphoreSlim(Math.Min(Math.Max(1, adaptiveUploadController.CurrentParallelism), 4), 4))
{
}
public async Task UploadAvailableSlicesAdaptiveAsync(Channel<FileUploaderSlice> availableSlices, UploadProgressState progressState)
{
var workerId = Interlocked.Increment(ref _workerTaskCounter);
try
{
while (await availableSlices.Reader.WaitToReadAsync(CancellationTokenSource.Token))
{
if (_exceptionOccurred.WaitOne(0))
{
return;
}
if (!availableSlices.Reader.TryRead(out var slice))
{
continue;
}
try
{
var sliceStart = Stopwatch.StartNew();
await IncrementConcurrentAsync(progressState);
var policy = _policyFactory.BuildFileUploadPolicy();
var attempt = 0;
var response = await policy.ExecuteAsync(async () =>
{
attempt++;
return await ExecuteUploadAttemptAsync(slice, workerId, attempt, CancellationTokenSource.Token);
});
if (!response.IsSuccess && CancellationTokenSource.IsCancellationRequested && _exceptionOccurred.WaitOne(0))
{
return;
}
EnsureSuccessOrThrow(response);
var fileName = _sharedFileDefinition.GetFileName(slice.PartNumber);
var assertSw = Stopwatch.StartNew();
_logger.LogDebug("UploadAvailableSlice: worker {WorkerId} start asserting slice {Number} for {FileName}",
workerId, slice.PartNumber, fileName);
var transferParameters = new TransferParameters
{
SessionId = _sharedFileDefinition.SessionId,
SharedFileDefinition = _sharedFileDefinition,
PartNumber = slice.PartNumber,
PartSizeInBytes = slice.MemoryStream.Length
};
await AssertSliceUploadedAsync(policy, transferParameters, workerId, slice.PartNumber, fileName, assertSw);
assertSw.Stop();
_logger.LogDebug(
"UploadAvailableSlice: worker {WorkerId} finished asserting slice {Number} for {FileName} in {ElapsedMs} ms",
workerId, slice.PartNumber, fileName, assertSw.ElapsedMilliseconds);
await UpdateProgressOnSuccessAsync(progressState, slice, sliceStart);
}
catch (OperationCanceledException) when (CancellationTokenSource.IsCancellationRequested && _exceptionOccurred.WaitOne(0))
{
return;
}
catch (Exception ex)
{
await HandleUploadExceptionAsync(progressState, availableSlices, ex, workerId);
return;
}
finally
{
DisposeSlice(slice);
await DecrementConcurrentAsync(progressState);
}
}
}
catch (OperationCanceledException) when (CancellationTokenSource.IsCancellationRequested)
{
return;
}
await CompleteIfFinishedAsync(progressState);
}
private async Task<UploadFileResponse> ExecuteUploadAttemptAsync(FileUploaderSlice slice, int workerId, int attempt,
CancellationToken globalToken)
{
var attemptStart = DateTime.UtcNow;
var currentChunkSizeBytes = _adaptiveUploadController.CurrentChunkSizeBytes;
var timeoutSec = UploadAttemptTimeoutPolicy.ComputeTimeoutSeconds(
slice.MemoryStream.Length,
attempt,
currentChunkSizeBytes);
var chunkRatio = currentChunkSizeBytes > 0
? slice.MemoryStream.Length / (double)currentChunkSizeBytes
: 0d;
using var attemptCts = CancellationTokenSource.CreateLinkedTokenSource(globalToken);
attemptCts.CancelAfter(TimeSpan.FromSeconds(timeoutSec));
var beforeWait = _uploadSlots.CurrentCount;
_logger.LogDebug(
"UploadAvailableSlice: worker {WorkerId} waiting for upload slot (available {Available}), attempt {Attempt}, timeout {TimeoutSec}s, slice {SliceKb} KB, currentChunk {CurrentChunkKb} KB, chunkRatio {ChunkRatio}",
workerId,
beforeWait,
attempt,
timeoutSec,
Math.Round(slice.MemoryStream.Length / 1024d),
Math.Round(currentChunkSizeBytes / 1024d),
Math.Round(chunkRatio, 2));
var acquired = false;
try
{
await _uploadSlots.WaitAsync(attemptCts.Token);
acquired = true;
var afterWait = _uploadSlots.CurrentCount;
_logger.LogDebug("UploadAvailableSlice: worker {WorkerId} acquired upload slot (available now {Available}), attempt {Attempt}",
workerId, afterWait, attempt);
var uploadTask = DoUpload(slice, workerId, attemptCts.Token);
var heartbeat = TimeSpan.FromSeconds(30);
while (!uploadTask.IsCompleted)
{
var completed = await Task.WhenAny(uploadTask, Task.Delay(heartbeat, attemptCts.Token));
if (completed == uploadTask)
{
break;
}
var fileNameHb = _sharedFileDefinition.GetFileName(slice.PartNumber);
_logger.LogDebug(
"UploadAvailableSlice: worker {WorkerId} uploading slice {Number} for {FileName}... attempt {Attempt}, elapsed {ElapsedMs} ms",
workerId, slice.PartNumber, fileNameHb, attempt, (DateTime.UtcNow - attemptStart).TotalMilliseconds);
if (attemptCts.IsCancellationRequested)
{
_logger.LogWarning(
"UploadAvailableSlice: worker {WorkerId} upload attempt {Attempt} timed out after ~{TimeoutSec}s; waiting for cancellation...",
workerId, attempt, timeoutSec);
break;
}
}
var attemptResponse = await uploadTask;
var elapsed = DateTime.UtcNow - attemptStart;
var refinedKind = RefineFailureKind(attemptResponse.FailureKind, attemptCts, globalToken);
_adaptiveUploadController.RecordUploadResult(new UploadResult(
elapsed,
attemptResponse.IsSuccess,
slice.PartNumber,
attemptResponse.StatusCode,
FileId: _sharedFileDefinition.Id,
ActualBytes: slice.MemoryStream.Length,
FailureKind: refinedKind));
return attemptResponse;
}
catch (OperationCanceledException oce)
{
var elapsed = DateTime.UtcNow - attemptStart;
var kind = DetermineCancellationKind(attemptCts, globalToken);
_adaptiveUploadController.RecordUploadResult(new UploadResult(
elapsed,
false,
slice.PartNumber,
Exception: oce,
FileId: _sharedFileDefinition.Id,
ActualBytes: slice.MemoryStream.Length,
FailureKind: kind));
throw new TaskCanceledException("Upload attempt canceled during slot wait or upload.", oce);
}
catch (Exception ex)
{
var elapsed = DateTime.UtcNow - attemptStart;
_adaptiveUploadController.RecordUploadResult(new UploadResult(
elapsed,
false,
slice.PartNumber,
500,
ex,
_sharedFileDefinition.Id,
slice.MemoryStream.Length,
UploadFailureKind.ServerError));
throw;
}
finally
{
try
{
if (acquired)
{
var beforeRelease = _uploadSlots.CurrentCount;
_uploadSlots.Release();
var afterRelease = _uploadSlots.CurrentCount;
_logger.LogDebug(
"UploadAvailableSlice: worker {WorkerId} released upload slot after attempt {Attempt} (available {Before}->{After})",
workerId, attempt, beforeRelease, afterRelease);
}
else
{
_logger.LogDebug(
"UploadAvailableSlice: worker {WorkerId} did not acquire upload slot (canceled before acquire) for attempt {Attempt}",
workerId, attempt);
}
}
catch (Exception ex)
{
_logger.LogWarning(ex, "UploadAvailableSlice: worker {WorkerId} error releasing upload slot after attempt {Attempt}",
workerId, attempt);
}
}
}
private static UploadFailureKind RefineFailureKind(UploadFailureKind kind, CancellationTokenSource attemptCts,
CancellationToken globalToken)
{
if (kind != UploadFailureKind.ClientCancellation)
{
return kind;
}
return DetermineCancellationKind(attemptCts, globalToken);
}
private static UploadFailureKind DetermineCancellationKind(CancellationTokenSource attemptCts, CancellationToken globalToken)
{
if (globalToken.IsCancellationRequested)
{
return UploadFailureKind.ClientCancellation;
}
if (attemptCts.IsCancellationRequested)
{
return UploadFailureKind.ClientTimeout;
}
return UploadFailureKind.ClientCancellation;
}
private async Task AssertSliceUploadedAsync(
AsyncRetryPolicy<UploadFileResponse> policy,
TransferParameters transferParameters,
int workerId,
int partNumber,
string fileName,
Stopwatch assertSw)
{
var assertTask = policy.ExecuteAsync(async () =>
{
await _fileTransferApiClient.AssertFilePartIsUploaded(transferParameters);
return UploadFileResponse.Success(200);
});
while (!assertTask.IsCompleted)
{
var completed = await Task.WhenAny(assertTask, Task.Delay(TimeSpan.FromSeconds(30)));
if (completed != assertTask)
{
_logger.LogDebug(
"UploadAvailableSlice: worker {WorkerId} asserting slice {Number} for {FileName}... elapsed {ElapsedMs} ms",
workerId, partNumber, fileName, assertSw.ElapsedMilliseconds);
}
}
await assertTask;
}
private async Task IncrementConcurrentAsync(UploadProgressState progressState)
{
await _semaphoreSlim.WaitAsync();
try
{
progressState.ConcurrentUploads += 1;
if (progressState.ConcurrentUploads > progressState.MaxConcurrentUploads)
{
progressState.MaxConcurrentUploads = progressState.ConcurrentUploads;
}
}
finally
{
_semaphoreSlim.Release();
}
}
private async Task DecrementConcurrentAsync(UploadProgressState progressState)
{
await _semaphoreSlim.WaitAsync();
try
{
if (progressState.ConcurrentUploads > 0)
{
progressState.ConcurrentUploads -= 1;
}
}
finally
{
_semaphoreSlim.Release();
}
}
private static void EnsureSuccessOrThrow(UploadFileResponse? response)
{
if (response == null || !response.IsSuccess)
{
throw new InvalidOperationException(
$"UploadAvailableSlice: upload attempt failed. Status: {response?.StatusCode}, Error: {response?.ErrorMessage}");
}
}
private async Task UpdateProgressOnSuccessAsync(UploadProgressState progressState, FileUploaderSlice slice, Stopwatch? sliceStart)
{
await _semaphoreSlim.WaitAsync();
try
{
progressState.TotalUploadedSlices += 1;
var sliceBytes = slice.MemoryStream.Length;
progressState.TotalUploadedBytes += sliceBytes;
if (sliceStart != null)
{
progressState.LastSliceUploadDurationMs = sliceStart.ElapsedMilliseconds;
progressState.LastSliceUploadedBytes = sliceBytes;
}
}
finally
{
_semaphoreSlim.Release();
}
}
private async Task HandleUploadExceptionAsync(
UploadProgressState progressState,
Channel<FileUploaderSlice> availableSlices,
Exception ex,
int workerId)
{
_logger.LogError(ex, "UploadAvailableSlice: worker {WorkerId} error", workerId);
await _semaphoreSlim.WaitAsync();
try
{
progressState.Exceptions.Add(ex);
}
finally
{
_semaphoreSlim.Release();
}
_exceptionOccurred.Set();
availableSlices.Writer.TryComplete(ex);
await CancellationTokenSource.CancelAsync();
DrainRemainingSlices(availableSlices.Reader);
}
private void DrainRemainingSlices(ChannelReader<FileUploaderSlice> reader)
{
if (Interlocked.Exchange(ref _remainingSlicesDrained, 1) == 1)
{
return;
}
while (reader.TryRead(out var slice))
{
DisposeSlice(slice);
}
}
private void DisposeSlice(FileUploaderSlice slice)
{
try
{
slice.MemoryStream.Dispose();
}
catch (Exception ex)
{
_logger.LogWarning(ex, "Error disposing slice {Number} memory stream", slice.PartNumber);
}
}
private async Task CompleteIfFinishedAsync(UploadProgressState progressState)
{
await _semaphoreSlim.WaitAsync();
try
{
if (progressState.TotalUploadedSlices == progressState.TotalCreatedSlices)
{
_uploadingIsFinished.Set();
_logger.LogDebug("UploadAvailableSlice: all slices uploaded ({Uploaded}/{Created}) - signaling completion",
progressState.TotalUploadedSlices, progressState.TotalCreatedSlices);
}
}
finally
{
_semaphoreSlim.Release();
}
}
private async Task<UploadFileResponse> DoUpload(FileUploaderSlice slice, int workerId, CancellationToken cancellationToken)
{
try
{
var transferParameters = new TransferParameters
{
SessionId = _sharedFileDefinition.SessionId,
SharedFileDefinition = _sharedFileDefinition,
PartNumber = slice.PartNumber
};
var uploadLocation = await _fileTransferApiClient.GetUploadFileStorageLocation(transferParameters);
var lengthKbRounded = (long)Math.Round((slice.MemoryStream.Length) / 1024d);
var fileName = _sharedFileDefinition.GetFileName(slice.PartNumber);
_logger.LogDebug("UploadAvailableSlice: worker {WorkerId} start uploading slice {Number} for {FileName} ({LengthKb} KB)",
workerId, slice.PartNumber, fileName, lengthKbRounded);
var uploadStrategy = _strategies[uploadLocation.StorageProvider];
var sw = Stopwatch.StartNew();
var response = await uploadStrategy.UploadAsync(slice, uploadLocation, cancellationToken);
sw.Stop();
_logger.LogDebug(
"UploadAvailableSlice: worker {WorkerId} finished uploading slice {Number} for {FileName} ({LengthKb} KB) in {ElapsedMs} ms (status {Status})",
workerId, slice.PartNumber, fileName, lengthKbRounded, sw.ElapsedMilliseconds, response.StatusCode);
return response;
}
catch (Exception ex)
{
var fileName = _sharedFileDefinition.GetFileName(slice.PartNumber);
_logger.LogError(ex,
"Error while uploading slice {Number} for {FileName} (worker {WorkerId}), SharedFileDefinitionId:{SharedFileDefinitionId} ",
slice.PartNumber, fileName, workerId, _sharedFileDefinition.Id);
throw;
}
}
}