chore(deps): bump modernc.org/sqlite from 1.55.0 to 1.56.0 in /endpoints - #1692
Merged
windcbf merged 2 commits intoAug 10, 2026
Merged
Conversation
Bumps [modernc.org/sqlite](https://gitlab.com/cznic/sqlite) from 1.55.0 to 1.56.0. - [Changelog](https://gitlab.com/cznic/sqlite/blob/master/CHANGELOG.md) - [Commits](https://gitlab.com/cznic/sqlite/compare/v1.55.0...v1.56.0) --- updated-dependencies: - dependency-name: modernc.org/sqlite dependency-version: 1.56.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
The modernc.org/sqlite 1.56.0 bump pulled github.com/mattn/go-isatty to v0.0.24 in endpoints/go.mod, drifting from the v0.0.20 pinned in the server plugin modules. Go's plugin loader fingerprints shared package versions, so this mismatch failed check-plugin-deps in CI. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014RJVbPvTH59wGnk7ZxVZnP
There was a problem hiding this comment.
✅ Looks Good - Code looks good (2 minor, non-blocking observations)
Dependency-only change (go.mod/go.sum); no Go source is touched. Reviewed the upgrade for correctness, plugin ABI impact, and supply-chain consistency.
What this actually changes
modernc.org/sqlite1.55.0 → 1.56.0 inendpoints/go.mod:20. Per the upstream changelog this re-vendors the transpiled SQLite sources to pick up a fix for an upstream data-corruption bug in SQLite 3.53.3 journal rollback (readSuperJournal()/pager_playback()can delete a hot journal without replaying it after a crash). Desirable, robustness-positive bump forendpoints/server/keystore.go, the only sqlite consumer in the tree (sql.Open("sqlite", dbPath+"?_journal_mode=WAL&_busy_timeout=5000"),endpoints/server/keystore.go:40).modernc.org/libc1.74.1 → 1.74.4 (endpoints/go.mod:168). ✔ Correct and required:modernc.org/sqlitemandates that downstream modules pin the exact libc version it pins, and 1.74.4 is what 1.56.0 pins. It also correctly skips the upstream-retracted 1.74.2/1.74.3 (freeaddrinfo lock leak that deadlocks name resolution).- No API surface used by this repo changed. The new
_defensiveDSN parameter and the_defensive+_journal_mode=OFFrejection landed in 1.57.0, not 1.56.0, so the DSN inkeystore.gois unaffected. The_journal_mode/_busy_timeoutshorthands it relies on were already present in 1.55.0. github.com/mattn/go-isatty0.0.20 → 0.0.24 inendpoints/go.mod:98and all threeexamples/server_plugin/*/go.mod. Bumping these in lockstep is the right call and worth calling out: server plugins are loaded as Goplugin.sofiles, andplugin.Openrejects a plugin whose shared dependency package hashes differ from the host binary. Had only/endpointsbeen bumped, plugin loading would have broken at runtime. Post-PR both sides resolve 0.0.24, so ABI compatibility is preserved.
No security, correctness, or breaking-change issues found.
Minor (non-blocking)
- Stale
go.sumentries in the example modules.examples/server_plugin/{authenticator,basic,oidc}/go.sumadd the v0.0.24 lines while keeping the v0.0.20h1:line, whereasendpoints/go.sumcorrectly replaces them (and drops the now-unneededgolang.org/x/sys v0.6.0/go.modline). Extrago.sumentries are harmless — builds andgo mod verifystill pass, and no CI job runs ago mod tidydiff check — but it does meango mod tidywas not run in those three modules. Running it there would prune them. - Version skew with the
nhpmodule.nhp/go.mod:38still pinsgo-isatty v0.0.20. Becauseendpointsandexamples/*bothreplacenhpwith the local directory and MVS selects the higher version, every real build resolves 0.0.24, so this is cosmetic. It should resolve itself on the next dependabot run for/nhp.
Verification note
CI (build, Analyze (go)) was still pending at review time — make compiles both the daemons and the example plugins, so it will exercise the sqlite/libc pin and the plugin-side go-isatty bump. Worth confirming green before merge.
windcbf
deleted the
dependabot/go_modules/endpoints/modernc.org/sqlite-1.56.0
branch
August 10, 2026 22:59
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1692 +/- ##
=======================================
Coverage 13.08% 13.08%
=======================================
Files 96 96
Lines 15005 15005
=======================================
Hits 1964 1964
Misses 12844 12844
Partials 197 197
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps modernc.org/sqlite from 1.55.0 to 1.56.0.
Changelog
Sourced from modernc.org/sqlite's changelog.
... (truncated)
Commits
cc920f9lib, vec: re-vendor, bump libc to v1.74.4, sweep the docs581eb45sqlite: validate the connector dsn with getVFSName, not a bare ParseQuerye7a39d2sqlite: document that a constructed Driver is not the registered one2c7e3ebsqlite: add NewConnector, a driver.Connector for sql.OpenDBDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)