Skip to content

Move _run_solvent_analysis and _run_complex_analysis in BaseSepTopAnalysis class to relevant parent class #2041

Description

@IAlibay

Only just saw this now, it's a bit confusing for someone deriving that base class to suddenly have the machinery to run an analysis that doesn't belog to that leg (e.g. ComplexSolventAnalysisUnit probably shouldn't see how to analyze a complex).

We probably should move the methods into child classes and just have base have a placeholder method (e.g. _run_structural_analysis).

At the same time, plotting probably should get moved to the children classes if there's "leg specific" things.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions