Skip to content

fix: warning xml tag on description#615

Open
barkat-matthias wants to merge 1 commit into
OCA:17.0from
barkat-matthias:fix/warning-xml-tag-in-description
Open

fix: warning xml tag on description#615
barkat-matthias wants to merge 1 commit into
OCA:17.0from
barkat-matthias:fix/warning-xml-tag-in-description

Conversation

@barkat-matthias

@barkat-matthias barkat-matthias commented Jun 1, 2026

Copy link
Copy Markdown

No description provided.

@OCA-git-bot

OCA-git-bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Hi @mmequignon,
some modules you are maintaining are being modified, check this out!

@OCA-git-bot OCA-git-bot added mod:fastapi_auth_api_key Module fastapi_auth_api_key series:17.0 labels Jun 1, 2026
@florentx

florentx commented Jul 2, 2026

Copy link
Copy Markdown

@lmignon
Can we merge it? Thanks

@OCA-git-bot

OCA-git-bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

lmignon
lmignon requested changes Jul 2, 2026
View reviewed changes

@lmignon lmignon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is generated. This change will be overridden on the next generate

@florentx

florentx commented Jul 2, 2026

Copy link
Copy Markdown

This file is generated. This change will be overridden on the next generate

I understand.
Problem is that file was not re-generated when the PR was merged (October 2025):

And it produces warnings in log file on every build:

  • DeprecationWarning: XML declarations in HTML module descriptions are deprecated since Odoo 17, fastapi_auth_api_key can just have a UTF8 description with not need for a declaration.
2026-07-02 07:47:17,054 62 WARNING odoodb py.warnings: /odoo/src/odoo/addons/base/models/ir_module.py:185: DeprecationWarning: XML declarations in HTML module descriptions are deprecated since Odoo 17, fastapi_auth_api_key can just have a UTF8 description with not need for a declaration.
  File "/usr/local/bin/odoo", line 8, in <module>
    odoo.cli.main()
  File "/odoo/src/odoo/cli/command.py", line 66, in main
    o.run(args)
  File "/odoo/src/odoo/cli/server.py", line 184, in run
    main(args)
  File "/odoo/src/odoo/cli/server.py", line 177, in main
    rc = odoo.service.server.start(preload=preload, stop=stop)
  File "/odoo/src/odoo/service/server.py", line 1414, in start
    rc = server.run(preload, stop)
  File "/odoo/src/odoo/service/server.py", line 590, in run
    rc = preload_registries(preload)
  File "/odoo/src/odoo/service/server.py", line 1314, in preload_registries
    registry = Registry.new(dbname, update_module=update_module)
  File "/usr/local/lib/python3.12/site-packages/decorator.py", line 232, in fun
    return caller(func, *(extras + args), **kw)
  File "/odoo/src/odoo/tools/func.py", line 87, in locked
    return func(inst, *args, **kwargs)
  File "/odoo/src/odoo/modules/registry.py", line 110, in new
    odoo.modules.load_modules(registry, force_demo, status, update_module)
  File "/odoo/src/odoo/modules/loading.py", line 481, in load_modules
    processed_modules += load_marked_modules(env, graph,
  File "/odoo/src/odoo/modules/loading.py", line 365, in load_marked_modules
    loaded, processed = load_module_graph(
  File "/odoo/src/odoo/modules/loading.py", line 223, in load_module_graph
    module._check()
  File "/odoo/src/odoo/addons/base/models/ir_module.py", line 850, in _check
    if not module.description_html:
  File "/odoo/src/odoo/fields.py", line 1207, in __get__
    self.compute_value(recs)
  File "/odoo/src/odoo/fields.py", line 1389, in compute_value
    records._compute_field_value(self)
  File "/odoo/src/odoo/models.py", line 4894, in _compute_field_value
    fields.determine(field.compute, self)
  File "/odoo/src/odoo/fields.py", line 102, in determine
    return needle(*args)
  File "/odoo/src/odoo/addons/base/models/ir_module.py", line 185, in _get_desc
    warnings.warn(

How can we fix it?

@florentx

florentx commented Jul 2, 2026

Copy link
Copy Markdown

@lmignon

It seems that the file was never generated for this add-on. Content is empty (both 17.0 and 18.0 branches, I didn't check others).

So I suggest that we merge this PR, just to avoid the noisy DeprecationWarning for the Op and other devs/customers.

And there should be a 2nd issue opened to investigate/fix why the HTML is not generated correctly.

https://github.com/OCA/rest-framework/blob/17.0/fastapi_auth_api_key/static/description/index.html#L363-L367

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmignon lmignon lmignon requested changes
+2 more reviewers
@florentx florentx florentx approved these changes
@damdam-s damdam-s damdam-s approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

mod:fastapi_auth_api_key Module fastapi_auth_api_key series:17.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@barkat-matthias @OCA-git-bot @florentx @lmignon @damdam-s