Skip to content

Commit 819dd6b

Browse files
authored
fix: retain peer dependencies in docker images (#7059)
Surfacing docker logs when running server docker image fails <!-- This is an auto-generated description by cubic. --> <a href="https://cubic.dev/pr/NangoHQ/nango/pull/7059?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="Review in cubic" src="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"></picture></a> <!-- End of auto-generated description by cubic. -->
1 parent c0ac951 commit 819dd6b

3 files changed

Lines changed: 4 additions & 2 deletions

File tree

.github/workflows/docker.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,13 +72,15 @@ jobs:
7272
SERVER=$(docker ps -q -f status=running -f name=^/${CONTAINER_NAME}$)
7373
if [ ! "${SERVER}" ]; then
7474
echo "Server container doesn't exist"
75+
docker compose logs --no-color
7576
exit 1
7677
fi
7778
7879
CONTAINER_NAME=nango-db
7980
DB=$(docker ps -q -f status=running -f name=^/${CONTAINER_NAME}$)
8081
if [ ! "${DB}" ]; then
8182
echo "DB container doesn't exist"
83+
docker compose logs --no-color
8284
exit 1
8385
fi
8486
shell: bash

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ RUN true \
7979

8080
# Clean dev dependencies
8181
RUN true \
82-
&& npm prune --omit=dev --omit=peer --omit=optional
82+
&& npm prune --omit=dev --omit=optional
8383

8484
# ---- Web ----
8585
# Resulting new, minimal image

packages/lambda-runner/Dockerfile.lambda

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ RUN true \
7575

7676
# Clean dev dependencies
7777
RUN true \
78-
&& npm prune --omit=dev --omit=peer --omit=optional
78+
&& npm prune --omit=dev --omit=optional
7979

8080
RUN npm install -g npm@11.10.1
8181

0 commit comments

Comments
 (0)