Merge branch 'master' into feat/integrations-agentline

Author: Sameersribot

.github/workflows/docker.yaml

@@ -72,13 +72,15 @@ jobs:
                   SERVER=$(docker ps -q -f status=running -f name=^/${CONTAINER_NAME}$)
                   if [ ! "${SERVER}" ]; then
                     echo "Server container doesn't exist"
+                    docker compose logs --no-color
                     exit 1
                   fi
 
                   CONTAINER_NAME=nango-db
                   DB=$(docker ps -q -f status=running -f name=^/${CONTAINER_NAME}$)
                   if [ ! "${DB}" ]; then
                     echo "DB container doesn't exist"
+                    docker compose logs --no-color
                     exit 1
                   fi
               shell: bash

Dockerfile

@@ -79,7 +79,7 @@ RUN true \
 
 # Clean dev dependencies
 RUN true \
-  && npm prune --omit=dev --omit=peer --omit=optional
+  && npm prune --omit=dev --omit=optional
 
 # ---- Web ----
 # Resulting new, minimal image

docs/api-integrations/ninjaone-rmm-oauth2/how-to-register-your-own-ninjaone-rmm-api-oauth-app.mdx

@@ -8,7 +8,7 @@ This guide shows you how to register your own app with NinjaOne RMM to obtain yo
 
 <Steps>
   <Step title="Navigate to the API settings">
-    1. Log in to your NinjaOne instance at [app.ninjarmm.com](https://app.ninjarmm.com).
+    1. Log in to your NinjaOne instance (e.g. [app.ninjarmm.com](https://app.ninjarmm.com) for North America, `us2.ninjarmm.com`, `eu.ninjarmm.com`, `ca.ninjarmm.com`, or `oc.ninjarmm.com` depending on where your tenant is hosted).
     2. Navigate to **Administration** > **Apps** > **API**.
     3. Click on the **Client App IDs** tab.
   </Step>
@@ -37,4 +37,5 @@ For more details, see [NinjaOne's Authorization Code Flow documentation](https:/
 
 - The **Client Secret** is only displayed once after creation. If you lose it, you'll need to create a new application.
 - NinjaOne access tokens expire within approximately 1 hour. Include the `offline_access` scope to ensure refresh tokens are issued for automatic token renewal.
+- NinjaOne tenants are hosted on regional instances (`app.ninjarmm.com`, `us2.ninjarmm.com`, `eu.ninjarmm.com`, `ca.ninjarmm.com`, `oc.ninjarmm.com`). OAuth credentials and API access only work against the tenant's own instance. Set the `instance` connection config to the tenant's hostname when creating a connection; existing connections without an `instance` fall back to `app.ninjarmm.com`.
 - This OAuth2 Authorization Code provider supports endpoints that require user-context authorization (e.g., running scripts on devices). If you only need machine-to-machine access, see the [NinjaOne RMM (Client Credentials)](/integrations/all/ninjaone-rmm) integration instead.

docs/api-integrations/zendesk/how-to-register-your-own-zendesk-api-oauth-app.mdx

@@ -11,7 +11,7 @@ Zendesk has two kinds of OAuth apps:
 - Helpdesk/support apps
 - CRM apps
 
-Nango currently only supports OAuth for the Helpdesk apps. If you need CRM, reach out or contribute it :)
+This guide is for the Helpdesk app, used by this `zendesk` integration. For Zendesk's CRM product, use the [Zendesk Sell](/integrations/all/zendesk-sell) integration instead.
 </Note>
 
 ## Creating a Zendesk OAuth Client
@@ -35,8 +35,8 @@ Nango currently only supports OAuth for the Helpdesk apps. If you need CRM, reac
 
 <Note>
 Important considerations when creating your OAuth client:
-- Make sure to create a Zendesk OAuth app (`https://<USER-SUBDOMAIN>.zendesk.com/admin/apps-integrations/apis/zendesk-api/settings`), _not_ a Zendesk Sales CRM OAuth app.
-- The subdomain is a critical part of the OAuth flow and API calls. It's the unique identifier in the Zendesk URL: `https://<subdomain>.zendesk.com`.
+- Make sure to create a Zendesk OAuth app (`https://<USER-SUBDOMAIN>.zendesk.com/admin/apps-integrations/apis/oauth-clients`), _not_ a Zendesk Sales CRM OAuth app.
+- The client you create is scoped to whichever Zendesk subdomain you're logged into (`https://<subdomain>.zendesk.com`). It'll only work for that subdomain unless you request a global client (see below).
 - When creating an OAuth client, make sure to fill out all fields, even those marked as "optional", especially if you plan to request a **global OAuth client** later.
 </Note>
 
@@ -66,7 +66,7 @@ For security reasons, Zendesk doesn't allow developers to create their own globa
 ## Additional Resources
 
 Zendesk has [rate limits](https://developer.zendesk.com/api-reference/introduction/rate-limits/) that vary by plan. For more details on Zendesk's OAuth implementation, see:
-- [OAuth authentication guide](https://developer.zendesk.com/api-reference/sales-crm/authentication/reference/)
+- [OAuth authentication guide](https://developer.zendesk.com/documentation/authentication/using-oauth-to-authenticate-zendesk-api-requests-in-a-web-app/)
 - [OAuth client setup](https://support.zendesk.com/hc/en-us/articles/4408845965210-Using-OAuth-authentication-with-your-application#topic_s21_lfs_qk)
 - [OAuth scopes](https://support.zendesk.com/hc/en-us/articles/4408845965210-Using-OAuth-authentication-with-your-application#topic_qkc_dcm_dcc)
 - [Global OAuth client setup](https://developer.zendesk.com/documentation/marketplace/building-a-marketplace-app/set-up-a-global-oauth-client/)

docs/integrations/all/ninjaone-rmm/connect.mdx

@@ -6,8 +6,9 @@ sidebarTitle: NinjaOne RMM
 # Overview
 
 To authenticate with NinjaOne RMM, you need:
-1. **Client ID** – Your OAuth application's Client ID
-2. **Client Secret** – Your OAuth application's Client Secret
+1. **Instance** – The hostname of the NinjaOne instance hosting your tenant (`app.ninjarmm.com` for North America, `us2.ninjarmm.com` for US2, `eu.ninjarmm.com` for EU, `ca.ninjarmm.com` for Canada, `oc.ninjarmm.com` for Oceania)
+2. **Client ID** – Your OAuth application's Client ID
+3. **Client Secret** – Your OAuth application's Client Secret
 
 This guide walks you through creating an OAuth Client Application in NinjaOne RMM.
 
@@ -19,7 +20,7 @@ This guide walks you through creating an OAuth Client Application in NinjaOne RM
 
 #### Step 1: Create an OAuth Client Application
 
-1. Log in to your NinjaOne instance at `https://app.ninjarmm.com`.
+1. Log in to your NinjaOne instance (`app.ninjarmm.com` for North America, `us2.ninjarmm.com` for US2, `eu.ninjarmm.com` for EU, `ca.ninjarmm.com` for Canada, or `oc.ninjarmm.com` for Oceania, depending on where your tenant is hosted).
 2. Navigate to **Administration** > **Apps** > **API**.
 <img src="/integrations/all/ninjaone-rmm/ninjaone_rmm_api_menu.png"/>
 3. Click on the **Client App IDs** tab.
@@ -41,8 +42,9 @@ This guide walks you through creating an OAuth Client Application in NinjaOne RM
 
 Once you have your **Client ID** and **Client Secret**:
 1. Open the form where you need to authenticate with NinjaOne RMM.
-2. Enter your **Client ID** and **Client Secret** in their respective fields.
-3. Submit the form, and you should be successfully authenticated.
+2. Select the **Instance** hosting your NinjaOne tenant.
+3. Enter your **Client ID** and **Client Secret** in their respective fields.
+4. Submit the form, and you should be successfully authenticated.
 
 <img src="/integrations/all/ninjaone-rmm/ninjaone_rmm_connect_form.png"/>
 

docs/integrations/all/ninjaone-rmm/ninjaone_rmm_connect_form.png

@@ -13,7 +13,7 @@
 <Accordion title="✅ Read & write data">
 | Tools | Status |
 | - | - |
-| Pre-built integrations | 🚫 (time to contribute: &lt;48h) |
+| Pre-built integrations | ✅ |
 | API unification | ✅ |
 | 2-way sync | ✅ |
 | Webhooks from Nango on data modifications | ✅ |