Skip to content

Commit fa78a16

Browse files
committed
[None][infra] Use /mnt instead of /tmp for bind mounts
install_base.sh cleans /tmp/* during build, which conflicts with bind mounts placed under /tmp. Move all bind mount targets to /mnt to avoid this. Signed-off-by: jbernloehr <jbernloehr@nvidia.com>
1 parent 4010bef commit fa78a16

1 file changed

Lines changed: 31 additions & 31 deletions

File tree

docker/Dockerfile.multi

Lines changed: 31 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@ ARG NCCL_VER
3535
ARG CUBLAS_VER
3636
ARG TORCH_INSTALL_TYPE="skip"
3737
RUN --mount=type=cache,target=/root/.cache/pip \
38-
--mount=source=docker/common,target=/tmp/docker/common \
39-
--mount=source=constraints.txt,target=/tmp/constraints.txt \
38+
--mount=source=docker/common,target=/mnt/docker/common \
39+
--mount=source=constraints.txt,target=/mnt/constraints.txt \
4040
GITHUB_MIRROR=${GITHUB_MIRROR} \
4141
PYTHON_VERSION=${PYTHON_VERSION} \
4242
TRT_VER=${TRT_VER} \
@@ -47,17 +47,17 @@ RUN --mount=type=cache,target=/root/.cache/pip \
4747
TORCH_INSTALL_TYPE=${TORCH_INSTALL_TYPE} \
4848
echo "Using GitHub mirror: $GITHUB_MIRROR" && \
4949
echo "Using Python version: $PYTHON_VERSION" && \
50-
bash /tmp/docker/common/install.sh --base --cmake --ccache --cuda_toolkit --tensorrt --polygraphy --mpi4py --pytorch --opencv && \
51-
pip3 install --no-cache-dir -r /tmp/constraints.txt && \
50+
bash /mnt/docker/common/install.sh --base --cmake --ccache --cuda_toolkit --tensorrt --polygraphy --mpi4py --pytorch --opencv && \
51+
pip3 install --no-cache-dir -r /mnt/constraints.txt && \
5252
# Remove nbconvert to avoid https://github.com/advisories/GHSA-xm59-rqc7-hhvf in the base NGC PyTorch image.
5353
(pip3 uninstall -y nbconvert || true)
5454

5555
# Install UCX, NIXL, etcd
5656
RUN --mount=type=cache,target=/root/.cache/pip \
57-
--mount=source=docker/common,target=/tmp/docker/common \
58-
GITHUB_MIRROR=${GITHUB_MIRROR} bash /tmp/docker/common/install_ucx.sh && \
59-
GITHUB_MIRROR=${GITHUB_MIRROR} bash /tmp/docker/common/install_nixl.sh && \
60-
bash /tmp/docker/common/install_etcd.sh && \
57+
--mount=source=docker/common,target=/mnt/docker/common \
58+
GITHUB_MIRROR=${GITHUB_MIRROR} bash /mnt/docker/common/install_ucx.sh && \
59+
GITHUB_MIRROR=${GITHUB_MIRROR} bash /mnt/docker/common/install_nixl.sh && \
60+
bash /mnt/docker/common/install_etcd.sh && \
6161
rm -rf /root/.cache/uv/archive-v0 && \
6262
# WAR against https://github.com/advisories/GHSA-58pv-8j8x-9vj2
6363
rm -rf /usr/local/lib/python3.12/dist-packages/setuptools/_vendor/jaraco.context-5.3.0.dist-info && \
@@ -67,8 +67,8 @@ RUN --mount=type=cache,target=/root/.cache/pip \
6767
# Generate OSS attribution file for devel image
6868
ARG TRT_LLM_VER
6969
ARG TARGETARCH
70-
RUN --mount=source=scripts/generate_container_oss_attribution.sh,target=/tmp/generate_container_oss_attribution.sh \
71-
bash /tmp/generate_container_oss_attribution.sh "devel" "${TRT_LLM_VER}" "${TARGETARCH}"
70+
RUN --mount=source=scripts/generate_container_oss_attribution.sh,target=/mnt/generate_container_oss_attribution.sh \
71+
bash /mnt/generate_container_oss_attribution.sh "devel" "${TRT_LLM_VER}" "${TARGETARCH}"
7272

7373
FROM ${TRITON_IMAGE}:${TRITON_BASE_TAG} AS triton
7474

@@ -82,12 +82,12 @@ COPY --from=triton /opt/tritonserver/bin /opt/tritonserver/bin
8282
COPY --from=triton /opt/tritonserver/caches /opt/tritonserver/caches
8383

8484
# Install Triton and Mooncake
85-
RUN --mount=source=docker/common,target=/tmp/docker/common \
86-
GITHUB_MIRROR=${GITHUB_MIRROR} bash /tmp/docker/common/install_triton.sh && \
85+
RUN --mount=source=docker/common,target=/mnt/docker/common \
86+
GITHUB_MIRROR=${GITHUB_MIRROR} bash /mnt/docker/common/install_triton.sh && \
8787
if [ -f /etc/redhat-release ]; then \
8888
echo "Rocky8 detected, skipping mooncake installation"; \
8989
else \
90-
bash /tmp/docker/common/install_mooncake.sh; \
90+
bash /mnt/docker/common/install_mooncake.sh; \
9191
fi
9292

9393
FROM ${DEVEL_IMAGE} AS wheel
@@ -116,26 +116,26 @@ WORKDIR /app/tensorrt_llm
116116
RUN --mount=type=cache,target=/root/.cache/pip --mount=type=bind,from=wheel,source=/src/tensorrt_llm/build,target=/tmp/wheel \
117117
pip install /tmp/wheel/tensorrt_llm*.whl
118118

119-
RUN --mount=source=README.md,target=/tmp/ctx/README.md \
120-
--mount=source=docs,target=/tmp/ctx/docs \
121-
--mount=source=cpp/include,target=/tmp/ctx/include \
122-
--mount=source=examples,target=/tmp/ctx/examples \
123-
--mount=type=bind,from=wheel,source=/src/tensorrt_llm/build,target=/tmp/wheel \
124-
--mount=type=bind,from=wheel,source=/src/tensorrt_llm/benchmarks,target=/tmp/benchmarks \
125-
--mount=type=bind,from=wheel,source=/src/tensorrt_llm/cpp/build/benchmarks,target=/tmp/cpp_benchmarks \
119+
RUN --mount=source=README.md,target=/mnt/ctx/README.md \
120+
--mount=source=docs,target=/mnt/ctx/docs \
121+
--mount=source=cpp/include,target=/mnt/ctx/include \
122+
--mount=source=examples,target=/mnt/ctx/examples \
123+
--mount=type=bind,from=wheel,source=/src/tensorrt_llm/build,target=/mnt/wheel \
124+
--mount=type=bind,from=wheel,source=/src/tensorrt_llm/benchmarks,target=/mnt/benchmarks \
125+
--mount=type=bind,from=wheel,source=/src/tensorrt_llm/cpp/build/benchmarks,target=/mnt/cpp_benchmarks \
126126
# Copy build context files
127-
cp /tmp/ctx/README.md ./ && \
128-
cp -r /tmp/ctx/docs ./docs && \
129-
cp -r /tmp/ctx/include ./include && \
130-
cp -r /tmp/ctx/examples ./examples && \
127+
cp /mnt/ctx/README.md ./ && \
128+
cp -r /mnt/ctx/docs ./docs && \
129+
cp -r /mnt/ctx/include ./include && \
130+
cp -r /mnt/ctx/examples ./examples && \
131131
chmod -R a+w examples && \
132132
# Copy wheel stage outputs
133-
cp /tmp/wheel/tensorrt_llm*.whl ./ && \
134-
cp -r /tmp/benchmarks ./benchmarks && \
133+
cp /mnt/wheel/tensorrt_llm*.whl ./ && \
134+
cp -r /mnt/benchmarks ./benchmarks && \
135135
mkdir -p benchmarks/cpp && \
136-
cp /tmp/cpp_benchmarks/bertBenchmark \
137-
/tmp/cpp_benchmarks/gptManagerBenchmark \
138-
/tmp/cpp_benchmarks/disaggServerBenchmark \
136+
cp /mnt/cpp_benchmarks/bertBenchmark \
137+
/mnt/cpp_benchmarks/gptManagerBenchmark \
138+
/mnt/cpp_benchmarks/disaggServerBenchmark \
139139
benchmarks/cpp/ && \
140140
rm -v \
141141
benchmarks/cpp/bertBenchmark.cpp \
@@ -164,8 +164,8 @@ ENV TRT_LLM_GIT_COMMIT=${GIT_COMMIT} \
164164
TRT_LLM_VERSION=${TRT_LLM_VER}
165165

166166
# Generate OSS attribution file for release image
167-
RUN --mount=source=scripts/generate_container_oss_attribution.sh,target=/tmp/generate_container_oss_attribution.sh \
168-
bash /tmp/generate_container_oss_attribution.sh "release" "${TRT_LLM_VER}" "${TARGETARCH}"
167+
RUN --mount=source=scripts/generate_container_oss_attribution.sh,target=/mnt/generate_container_oss_attribution.sh \
168+
bash /mnt/generate_container_oss_attribution.sh "release" "${TRT_LLM_VER}" "${TARGETARCH}"
169169

170170
FROM wheel AS tritonbuild
171171

0 commit comments

Comments
 (0)