Merge pull request #385 from LossyDragon/buildcommand-test

Add test for recent pr

Author: LossyDragon

src/main/java/in/dragonbra/javasteam/steam/cdn/Client.kt

@@ -38,7 +38,8 @@ class Client(steamClient: SteamClient) : Closeable {
 
         private val logger: Logger = LogManager.getLogger(Client::class.java)
 
-        private fun buildCommand(
+        @JvmStatic
+        fun buildCommand(
             server: Server,
             command: String,
             query: String? = null,

src/test/java/in/dragonbra/javasteam/steam/cdn/CDNClientTest.java

@@ -176,4 +176,21 @@ public void testPrivateIPv6Addresses(String ipAddress, boolean expected) throws
         boolean result = ClientLancache.isPrivateAddress(address);
         Assertions.assertEquals(expected, result);
     }
+
+    @ParameterizedTest
+    @CsvSource({
+            "token=abc,          token,  ",          // normal, no change
+            "?token=abc,         token,  ?token",    // leading ? stripped
+            "??token=abc,        token,  ??token",   // multiple leading ? stripped
+            "?token=abc&foo=bar, token,  ?token",    // leading ? with multiple params
+    })
+    public void buildCommandStripsLeadingQuestionMarkFromQueryString(String query, String expectedKey, String unexpectedKey) {
+        var server = Server.fromHostAndPort("localhost", 80);
+        HttpUrl url = Client.buildCommand(server, "depot/731/manifest", query, null);
+
+        Assertions.assertNotNull(url.queryParameter(expectedKey));
+        if (unexpectedKey != null) {
+            Assertions.assertNull(url.queryParameter(unexpectedKey));
+        }
+    }
 }