Merge remote-tracking branch 'cgal/6.2.x-branch' into 'cgal/main'

Author: sloriot

Surface_mesh_simplification/include/CGAL/internal/robust_cross_product.h

@@ -76,7 +76,7 @@ typename GeomTraits::Vector_3 similar_coordinates_cross_product(const typename G
   const FT& vy = v.y();
   const FT& vz = v.z();
 
-  auto minor = [](const FT& ui, const FT& vi, const FT& uj, const FT& vj)
+  auto compute_minor = [](const FT& ui, const FT& vi, const FT& uj, const FT& vj)
   {
     // The main idea is that we expect ai and bi (and aj and bj) to have roughly the same magnitude
     // since this function is used to compute the cross product of two vectors that are defined
@@ -87,9 +87,9 @@ typename GeomTraits::Vector_3 similar_coordinates_cross_product(const typename G
   };
 
   // ay*
-  FT x = minor(uy, vy, uz, vz);
-  FT y = minor(uz, vz, ux, vx);
-  FT z = minor(ux, vx, uy, vy);
+  FT x = compute_minor(uy, vy, uz, vz);
+  FT y = compute_minor(uz, vz, ux, vx);
+  FT z = compute_minor(ux, vx, uy, vy);
 
   return Vector(x, y, z);
 }

Tetrahedral_remeshing/include/CGAL/Tetrahedral_remeshing/internal/collapse_short_edges.h

@@ -1206,21 +1206,28 @@ auto can_be_collapsed(const typename C3T3::Edge& e,
     bool on_boundary;
   };
 
-  const bool boundary = c3t3.is_in_complex(e)
-                     || is_boundary(c3t3, e, cell_selector);
+  const bool in_cx = c3t3.is_in_complex(e);
+  if(in_cx && protect_boundaries)
+    return Collapsible{false, true /*boundary*/};
 
-  if (protect_boundaries)
-  {
-    if (boundary)
-      return Collapsible{false, boundary};
+  const bool boundary = is_boundary(c3t3, e, cell_selector);
+  if(boundary && protect_boundaries)
+    return Collapsible{false, boundary};
 
-    return Collapsible{ is_internal(e, c3t3, cell_selector), boundary};
-  }
-  else
+  if(!is_selected(e, c3t3.triangulation(), cell_selector))
+    return Collapsible{false, boundary};
+
+  if(!boundary && !in_cx)
   {
-    return Collapsible{ is_selected(e, c3t3.triangulation(), cell_selector),
-                        boundary };
+    auto patch_v0 = surface_patch_index(e.first->vertex(e.second), c3t3);
+    auto patch_v1 = surface_patch_index(e.first->vertex(e.third), c3t3);
+
+    if(patch_v0 != std::nullopt && patch_v1 != std::nullopt && patch_v0 != patch_v1)
+      return Collapsible{false, boundary};
   }
+
+//   if(!is_internal(e, c3t3, cell_selector))
+  return Collapsible {true, boundary};
 }
 
 template<typename C3T3,

Tetrahedral_remeshing/include/CGAL/Tetrahedral_remeshing/internal/tetrahedral_remeshing_helpers.h

@@ -806,10 +806,10 @@ bool is_boundary_vertex(const typename C3t3::Vertex_handle& v,
 }
 
 template<typename C3t3>
-typename C3t3::Surface_patch_index surface_patch_index(const typename C3t3::Vertex_handle v,
-    const C3t3& c3t3)
+std::optional<typename C3t3::Surface_patch_index>
+surface_patch_index(const typename C3t3::Vertex_handle v,
+                    const C3t3& c3t3)
 {
-  typedef typename C3t3::Surface_patch_index Surface_patch_index;
   typedef typename C3t3::Facet Facet;
   std::vector<Facet> facets;
   c3t3.triangulation().incident_facets(v, std::back_inserter(facets));
@@ -819,7 +819,7 @@ typename C3t3::Surface_patch_index surface_patch_index(const typename C3t3::Vert
     if (c3t3.is_in_complex(f))
       return c3t3.surface_patch_index(f);
   }
-  return Surface_patch_index();
+  return std::nullopt;
 }
 
 template<typename C3t3>
@@ -833,7 +833,7 @@ void set_index(typename C3t3::Vertex_handle v, const C3t3& c3t3)
   case 2:
     CGAL_expensive_assertion(surface_patch_index(v, c3t3)
                   != typename C3t3::Surface_patch_index());
-    v->set_index(surface_patch_index(v, c3t3));
+    v->set_index(surface_patch_index(v, c3t3).value());
     break;
   case 1:
     v->set_index(typename C3t3::Curve_index(1));