Implement a SmugglerDisplay

[fredrikekre]

diff --git a/ext/JETExt.jl b/ext/JETExt.jl
index 52bd409..9a81774 100644
--- a/ext/JETExt.jl
+++ b/ext/JETExt.jl
diff --git a/ext/JETExt.jl b/ext/JETExt.jl
diff --git a/ext/JETExt.jl b/ext/JETExt.jl
index 52bd409..9a81774 100644
--- a/ext/JETExt.jl
+++ b/ext/JETExt.jl
@@ -37,4 +37,8 @@ function REPLSmuggler.smuggle(result::JET.JETCallResult)
     end
 end

+function Base.display(::REPLSmuggler.SmugglerDisplay, x::JET.JETCallResult)
+    return REPLSmuggler.smuggle(x)
+end
+
 end
diff --git a/src/REPLSmuggler.jl b/src/REPLSmuggler.jl
index eb4900e..864786c 100644
--- a/src/REPLSmuggler.jl
+++ b/src/REPLSmuggler.jl
@@ -35,6 +35,10 @@ using .Protocols
 include("Server.jl")
 using .Server

+struct SmugglerDisplay <: Base.AbstractDisplay end
+function Base.display(::SmugglerDisplay, x::Base.ExceptionStack)
+    return smuggle(x)
+end

 """
 Store the current server.
@@ -44,6 +48,7 @@ CURRENT_SMUGGLER = nothing
 function smuggle(specific_smuggler, serializer)
     global CURRENT_SMUGGLER
     CURRENT_SMUGGLER = Smuggler(specific_smuggler, serializer, Set{Session}())
+    Base.pushdisplay(SmugglerDisplay())
     serve_repl(CURRENT_SMUGGLER)
 end

Adding something like this enables automatic smuggling. It doesn't work for errors though because errors doesn't go through the display system.

Perhaps still useful?

[Klafyvel]

I think it is. I don't know if it should go in the package or if it simply should be mentioned in the doc.

…

On Tue, Aug 6, 2024, 13:31 Fredrik Ekre ***@***.***> wrote: diff --git a/ext/JETExt.jl b/ext/JETExt.jl index 52bd409..9a81774 100644--- a/ext/JETExt.jl+++ b/ext/JETExt.jldiff --git a/ext/JETExt.jl b/ext/JETExt.jldiff --git a/ext/JETExt.jl b/ext/JETExt.jl index 52bd409..9a81774 100644--- a/ext/JETExt.jl+++ b/ext/JETExt.jl@@ -37,4 +37,8 @@ function REPLSmuggler.smuggle(result::JET.JETCallResult) end end +function Base.display(::REPLSmuggler.SmugglerDisplay, x::JET.JETCallResult)+ return REPLSmuggler.smuggle(x)+end+ enddiff --git a/src/REPLSmuggler.jl b/src/REPLSmuggler.jl index eb4900e..864786c 100644--- a/src/REPLSmuggler.jl+++ b/src/REPLSmuggler.jl@@ -35,6 +35,10 @@ using .Protocols include("Server.jl") using .Server +struct SmugglerDisplay <: Base.AbstractDisplay end+function Base.display(::SmugglerDisplay, x::Base.ExceptionStack)+ return smuggle(x)+end """ Store the current server.@@ -44,6 +48,7 @@ CURRENT_SMUGGLER = nothing function smuggle(specific_smuggler, serializer) global CURRENT_SMUGGLER CURRENT_SMUGGLER = Smuggler(specific_smuggler, serializer, Set{Session}())+ Base.pushdisplay(SmugglerDisplay()) serve_repl(CURRENT_SMUGGLER) end Adding something like this enables automatic smuggling. It doesn't work for errors though because errors doesn't go through the display system. Perhaps still useful? — Reply to this email directly, view it on GitHub <#33>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABPL4L2KBLKU3O72UCYFWSTZQCXZRAVCNFSM6AAAAABMCEHPL2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ2TANRVGMYDAMQ> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[fredrikekre]

This should also be trivial to extend to show "inline results" as e.g. virtual text in neovim similarly to what the VS Code extension do.

I don't think it should be enabled by default perhaps, but could be a configurable option (like in VS code I believe).

[Klafyvel]

yes, I'm planning to have that. But I was thinking of doing it from the evaluation result (since I can access it directly) rather than hacking into Base.show. With the ongoing work on displaying images in neovim we could display plots etc, essentially turning neovim into a notebook runner.

…

On Tue, Aug 6, 2024, 13:53 Fredrik Ekre ***@***.***> wrote: This should also be trivial to extend to show "inline results" as e.g. virtual text in neovim similarly to what the VS Code extension do. I don't think it should be enabled by default perhaps, but could be a configurable option (like in VS code I believe). — Reply to this email directly, view it on GitHub <#33 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABPL4LYCWZFIZUBDRP3S26DZQC2MPAVCNFSM6AAAAABMCEHPL2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZRGEYDONJXGE> . You are receiving this because you commented.Message ID: ***@***.***>