Fix #365: Remove unnecessary ForageConnectionFactory wrapper

The ForageConnectionFactory wrapper was serving as unnecessary indirection
in the JMS module. It was a simple record that wrapped ConnectionFactory,
which was immediately unwrapped at every usage point.

Author: JiriOndrusek

library/jms/forage-jms-common/src/main/java/io/kaoto/forage/jms/common/ForageConnectionFactory.java

@@ -25,7 +25,6 @@
 import io.kaoto.forage.core.util.config.ConfigStore;
 import io.kaoto.forage.jms.common.ConnectionFactoryCommonExportHelper;
 import io.kaoto.forage.jms.common.ConnectionFactoryConfig;
-import io.kaoto.forage.jms.common.ForageConnectionFactory;
 
 @ForageFactory(
         value = "JMS Connection",
@@ -130,8 +129,8 @@ public void configure() {
             for (String name : prefixes) {
                 if (camelContext.getRegistry().lookupByNameAndType(name, ConnectionFactory.class) == null) {
                     ConnectionFactoryConfig cfConfig = new ConnectionFactoryConfig(name);
-                    ForageConnectionFactory forageConnectionFactory = newConnectionFactory(cfConfig, name);
-                    camelContext.getRegistry().bind(name, forageConnectionFactory.connectionFactory());
+                    ConnectionFactory connectionFactory = newConnectionFactory(cfConfig, name);
+                    camelContext.getRegistry().bind(name, connectionFactory);
                 }
             }
         } else {
@@ -141,11 +140,8 @@ public void configure() {
                     final List<ServiceLoader.Provider<ConnectionFactoryProvider>> providers =
                             findProviders(ConnectionFactoryProvider.class);
                     if (providers.size() == 1) {
-                        ForageConnectionFactory forageConnectionFactory =
-                                doCreateConnectionFactory(providers.get(0), null);
-                        camelContext
-                                .getRegistry()
-                                .bind(DEFAULT_CONNECTION_FACTORY, forageConnectionFactory.connectionFactory());
+                        ConnectionFactory connectionFactory = doCreateConnectionFactory(providers.get(0), null);
+                        camelContext.getRegistry().bind(DEFAULT_CONNECTION_FACTORY, connectionFactory);
                     } else {
                         throw new IllegalArgumentException(
                                 "No ConnectionFactory implementation is present in the classpath");
@@ -157,7 +153,7 @@ public void configure() {
         }
     }
 
-    private synchronized ForageConnectionFactory newConnectionFactory(
+    private synchronized ConnectionFactory newConnectionFactory(
             ConnectionFactoryConfig connectionFactoryConfig, String name) {
         final String connectionFactoryProviderClass =
                 ConnectionFactoryCommonExportHelper.transformJmsKindIntoProviderClass(
@@ -178,10 +174,10 @@ private synchronized ForageConnectionFactory newConnectionFactory(
         return doCreateConnectionFactory(connectionFactoryProvider, name);
     }
 
-    private ForageConnectionFactory doCreateConnectionFactory(
+    private ConnectionFactory doCreateConnectionFactory(
             ServiceLoader.Provider<ConnectionFactoryProvider> provider, String name) {
         final ConnectionFactoryProvider connectionFactoryProvider = provider.get();
-        return new ForageConnectionFactory(connectionFactoryProvider.create(name));
+        return connectionFactoryProvider.create(name);
     }
 
     @Override