Integration for Node release 11.1 - #1221
Merged
Merged
Conversation
f-f
force-pushed
the
f-f/prepare-11.1
branch
3 times, most recently
from
June 2, 2026 12:19
e966ff5 to
8fd1b1a
Compare
f-f
changed the title
f-f
marked this pull request as ready for review
June 23, 2026 12:47
f-f
requested review from
CarlosLopezDeLara,
Jimbo4350,
carbolymer,
disassembler,
erikd and
palas
as code owners
June 23, 2026 12:47
f-f
changed the title
carbolymer
reviewed
Jul 3, 2026
carbolymer
reviewed
Jul 3, 2026
Jimbo4350
requested changes
Jul 6, 2026
Contributor
Author
|
@Jimbo4350 @carbolymer thanks for having a look! The commit history is garbage because I didn't want to break previous refs all the time, will squash everything into a single commit |
f-f
force-pushed
the
f-f/prepare-11.1
branch
2 times, most recently
from
July 21, 2026 16:06
f3941cb to
856e3c7
Compare
f-f
force-pushed
the
f-f/prepare-11.1
branch
5 times, most recently
from
August 4, 2026 07:24
19910ea to
4136bb8
Compare
Contributor
Author
|
@Jimbo4350 I've got too many breaking changes coming from upstream so untangling them in different commits is not really possible. Most of it is mechanical though so it should be pretty reviewable. For context, most of the changes are brought in by a few upstream changes:
|
Jimbo4350
reviewed
Aug 5, 2026
Jimbo4350
left a comment
Jimbo4350
left a comment
Contributor
There was a problem hiding this comment.
LGTM, couple of minor changes.
Jimbo4350
approved these changes
Aug 6, 2026
4 tasks
palas
added a commit
that referenced
this pull request
Aug 8, 2026
Since the node-11.1 integration (#1221) the generated haddocks contain cross-package links to fs-api, and the "Update github pages" workflow fails because scripts/fix-haddock-links.sh cannot resolve a doc site for it: fs-api lives in the fs-sim repository, which publishes its Haddocks from gh-pages of the input-output-hk organisation (the repo was never migrated to IntersectMBO), so the *.cardano.intersectmbo.org name-suffix heuristic cannot derive the URL. Add https://input-output-hk.github.io/fs-sim to IOG_DOC_BASES. The site serves doc-index.html and module pages for both fs-api and fs-sim, so cross-package links resolve instead of failing the build. Fixes #1279
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Integration for release 11.1 - here we update to the latest
base/network/ledger/consensusChecklist
.changes/