Skip to content

Commit 8dbbf1e

Browse files
authored
Merge pull request #903 from HaoboGu/fix/user-build-esp-bin-artifacts
ci: upload bin artifacts for RISC-V esp32 chips in user build
2 parents 9a74076 + cb75251 commit 8dbbf1e

1 file changed

Lines changed: 11 additions & 0 deletions

File tree

.github/workflows/user_build.yml

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,8 @@ jobs:
8181
build:
8282
runs-on: ubuntu-latest
8383
needs: get_chip_name
84+
# Only esp32s3 (Xtensa) needs the espup toolchain in build_esp;
85+
# RISC-V esp32 chips build here with the standard toolchain.
8486
if: needs.get_chip_name.outputs.chip_name != 'esp32s3'
8587
steps:
8688
- uses: cargo-bins/cargo-binstall@main
@@ -111,15 +113,24 @@ jobs:
111113
working-directory: ./rmk
112114
run: cargo make uf2 --release
113115
- name: Upload uf2 artifacts
116+
if: ${{ !startsWith(needs.get_chip_name.outputs.chip_name, 'esp32') }}
114117
uses: actions/upload-artifact@v7
115118
with:
116119
name: ${{ needs.get_chip_name.outputs.artifact_prefix }}${{ needs.get_chip_name.outputs.project_name }}-firmware_uf2
117120
path: rmk/*.uf2
118121
- name: Upload hex artifacts
122+
if: ${{ !startsWith(needs.get_chip_name.outputs.chip_name, 'esp32') }}
119123
uses: actions/upload-artifact@v7
120124
with:
121125
name: ${{ needs.get_chip_name.outputs.artifact_prefix }}${{ needs.get_chip_name.outputs.project_name }}-firmware_hex
122126
path: rmk/*.hex
127+
- name: Upload bin artifacts
128+
# espflash produces .bin images for esp32 chips instead of uf2/hex
129+
if: ${{ startsWith(needs.get_chip_name.outputs.chip_name, 'esp32') }}
130+
uses: actions/upload-artifact@v7
131+
with:
132+
name: ${{ needs.get_chip_name.outputs.artifact_prefix }}${{ needs.get_chip_name.outputs.project_name }}-firmware_bin
133+
path: rmk/*.bin
123134
build_esp:
124135
runs-on: ubuntu-latest
125136
needs: get_chip_name

0 commit comments

Comments
 (0)