Skip to content

Commit 274377f

Browse files
committed
CurvesInterpolationUI : Fix DocumentationTest failures
Treating OptionalValuePlug as a terminal is consistent with the way we treat NameValuePlug. With that done, promoting the documentation from the `value` plug fixes the test failure, but also makes the tooltip available more easily in the UI, without having to turn the `enabled` switch on.
1 parent 2c86aac commit 274377f

2 files changed

Lines changed: 11 additions & 2 deletions

File tree

python/GafferSceneUI/CurvesInterpolationUI.py

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@
5656

5757
plugs = {
5858

59-
"basis.value" : {
59+
"basis" : {
6060

6161
"description" :
6262
"""
@@ -71,6 +71,10 @@
7171
to the end vertices.
7272
""",
7373

74+
},
75+
76+
"basis.value" : {
77+
7478
"plugValueWidget:type" : "GafferUI.PresetsPlugValueWidget",
7579
# We only expose the basis types which have a step of 1.
7680
# We can safely convert between any of these without them
@@ -81,7 +85,7 @@
8185

8286
},
8387

84-
"wrap.value" : {
88+
"wrap" : {
8589

8690
"description" :
8791
"""
@@ -95,6 +99,10 @@
9599
phantom endpoints. Generally inferior to the other options.
96100
""",
97101

102+
},
103+
104+
"wrap.value" : {
105+
98106
"plugValueWidget:type" : "GafferUI.PresetsPlugValueWidget",
99107
"preset:Pinned" : IECoreScene.CurvesPrimitive.Wrap.Pinned,
100108
"preset:Periodic" : IECoreScene.CurvesPrimitive.Wrap.Periodic,

python/GafferTest/TestCase.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -308,6 +308,7 @@ def __undocumentedPlugs( self, node, additionalTerminalPlugTypes = () ) :
308308
Gaffer.Box2fPlug, Gaffer.Box3fPlug,
309309
Gaffer.TransformPlug, Gaffer.Transform2DPlug,
310310
Gaffer.CompoundDataPlug.MemberPlug,
311+
Gaffer.OptionalValuePlug,
311312
additionalTerminalPlugTypes
312313
)
313314

0 commit comments

Comments
 (0)