Prefer explicit env key for OrbPro plugin decryption

Author: TJKoury

sdn-server/internal/node/node.go

@@ -433,12 +433,6 @@ func (n *Node) loadPluginRegistry() (*license.PluginRegistry, error) {
 }
 
 func (n *Node) findPluginDecryptPrivateKey() ([]byte, error) {
-	if n.identity != nil && len(n.identity.EncryptionKey) == 32 {
-		key := make([]byte, len(n.identity.EncryptionKey))
-		copy(key, n.identity.EncryptionKey)
-		return key, nil
-	}
-
 	envNames := []string{
 		"SDN_PLUGIN_DECRYPT_KEY",
 		"SDN_PLUGIN_KEY",
@@ -457,6 +451,12 @@ func (n *Node) findPluginDecryptPrivateKey() ([]byte, error) {
 		}
 	}
 
+	if n.identity != nil && len(n.identity.EncryptionKey) == 32 {
+		key := make([]byte, len(n.identity.EncryptionKey))
+		copy(key, n.identity.EncryptionKey)
+		return key, nil
+	}
+
 	return nil, nil
 }