refactor: remove dead code and update error handling in movie search

Author: DiegoFleitas

src/client/src/__tests__/noticeFunctions.test.ts

@@ -0,0 +1,17 @@
+import { afterEach, describe, expect, it, vi } from "vitest";
+import { hideNotice, setNoticeImpl } from "../noticeFunctions";
+
+describe("noticeFunctions", () => {
+  afterEach(() => {
+    setNoticeImpl(null);
+  });
+
+  it("hideNotice clears React notice when setter is registered", () => {
+    const setter = vi.fn();
+    setNoticeImpl(setter);
+
+    hideNotice();
+
+    expect(setter).toHaveBeenCalledWith(null);
+  });
+});

src/client/src/__tests__/useMovieSearch.test.tsx

@@ -0,0 +1,35 @@
+// @vitest-environment jsdom
+import { describe, it, expect, vi, beforeEach } from "vitest";
+import { act, renderHook, waitFor } from "@testing-library/react";
+import { useMovieSearch } from "../useMovieSearch";
+import { showError } from "../showError";
+
+vi.mock("../showMessage", () => ({
+  showMessage: vi.fn(),
+}));
+
+vi.mock("../showError", () => ({
+  showError: vi.fn(),
+}));
+
+describe("useMovieSearch", () => {
+  beforeEach(() => {
+    vi.clearAllMocks();
+  });
+
+  it("shows an error toast when network request fails", async () => {
+    globalThis.fetch = vi.fn().mockRejectedValue(new TypeError("Failed to fetch"));
+
+    const { result } = renderHook(() => useMovieSearch());
+
+    await act(async () => {
+      result.current({ title: "The Matrix", year: "1999", country: "US" });
+    });
+
+    await waitFor(() => {
+      expect(showError).toHaveBeenCalledWith(
+        "Movie search failed. Check your connection and try again.",
+      );
+    });
+  });
+});

src/client/src/movieTiles.ts

@@ -64,10 +64,7 @@ export function classifyListReportSymptom(
 }
 
 export function normalizeId(title: string, year: string | number | null): string {
-  return `${year}-${title
-    .toUpperCase()
-    .replace(/ /g, "-")
-    .replace(/[^A-Z0-9]/g, "")}`;
+  return `${year}-${title.toUpperCase().replace(/[^A-Z0-9]/g, "")}`;
 }
 
 /** Letterboxd list entries often use root-relative paths; keep absolute URLs for consumers. */
@@ -195,13 +192,3 @@ export function mergeTileStateForTab(
 export function getTileProviderNames(tileData: TileData | null | undefined): string[] {
   return (tileData?.movieProviders ?? []).map((p) => p.name);
 }
-
-export function tileMatchesFilter(
-  tileData: TileData | null | undefined,
-  activeProviderNames: string[] | null | undefined,
-): boolean {
-  if (!activeProviderNames?.length) return true;
-  const names = getTileProviderNames(tileData);
-  if (!names.length) return false;
-  return activeProviderNames.some((n) => names.includes(n));
-}

src/client/src/noticeFunctions.ts

@@ -49,6 +49,10 @@ export const toggleNotice = (msg: string | null | undefined): void => {
 };
 
 export const hideNotice = (): void => {
+  if (noticeSetter) {
+    noticeSetter(null);
+    return;
+  }
   const impl = getToastImpl();
   if (impl?.dismissLoading && noticeId != null) {
     impl.dismissLoading(noticeId);

src/client/src/useMovieSearch.ts

@@ -1,5 +1,6 @@
 import { useCallback, useRef } from "react";
 import { showMessage } from "./showMessage";
+import { showError } from "./showError";
 import { PLACEHOLDER_POSTER, normalizePosterPath, type MergeData } from "./movieTiles";
 import { captureFrontendException, captureFrontendMessage } from "./sentry";
 import { SafeJsonResponseError, safeJsonResponse } from "./safeJsonResponse";
@@ -93,6 +94,8 @@ export function useMovieSearch(
                 country: data.country,
               },
             });
+          } else {
+            showError("Movie search failed. Check your connection and try again.");
           }
           captureFrontendException(err, {
             tags: { source: "api", endpoint: HTTP_API_PATHS.searchMovie },

tests/stateTileManagement.test.ts

@@ -21,10 +21,7 @@ const lakeMungoSearch = searchMovieData.find(
 )?.response;
 
 function generateTileId(title: string, year: string | null): string {
-  return `${year}-${title
-    .toUpperCase()
-    .replace(/ /g, "-")
-    .replace(/[^A-Z0-9]/g, "")}`;
+  return `${year}-${title.toUpperCase().replace(/[^A-Z0-9]/g, "")}`;
 }
 
 interface TileData {
@@ -71,6 +68,10 @@ describe("state tile ID management", () => {
     );
   });
 
+  it("strips spaces instead of preserving hyphens", () => {
+    expect(generateTileId("A  Space Heavy Title", "2024")).toBe("2024-ASPACEHEAVYTITLE");
+  });
+
   it("handles null year", () => {
     expect(generateTileId("Her Private Hell", null)).toBe("null-HERPRIVATEHELL");
   });