refactor(openai-embedding): apply code quality improvements, exception handling and empty validation from 1.md

Author: Rat0323

astrbot/core/provider/sources/openai_embedding_source.py

@@ -1,6 +1,7 @@
 from urllib.parse import urlparse
 
 import httpx
+import openai
 from openai import AsyncOpenAI
 
 from astrbot import logger
@@ -20,12 +21,29 @@ def __init__(self, provider_config: dict, provider_settings: dict) -> None:
         super().__init__(provider_config, provider_settings)
         self.provider_config = provider_config
         self.provider_settings = provider_settings
-        proxy = provider_config.get("proxy", "")
+
         provider_id = provider_config.get("id", "unknown_id")
+
+        # 1. 强制校验 API Key (Fail-Fast)
+        api_key: str = provider_config.get("embedding_api_key", "")
+        if not api_key:
+            raise ValueError(
+                f"OpenAI embedding provider [{provider_id}] 配置错误: 缺少必需的 'embedding_api_key'"
+            )
+
+        # 2. 安全获取并转换 timeout 避免空字符串导致 int() 崩溃
+        raw_timeout = provider_config.get("timeout", 20)
+        try:
+            timeout_val = int(raw_timeout) if raw_timeout else 20
+        except (ValueError, TypeError):
+            timeout_val = 20
+
+        proxy = provider_config.get("proxy", "")
         http_client = None
         if proxy:
             logger.info(f"[OpenAI Embedding] {provider_id} Using proxy: {proxy}")
             http_client = httpx.AsyncClient(proxy=proxy)
+
         api_base = (
             provider_config.get("embedding_api_base", "https://api.openai.com/v1")
             .strip()
@@ -35,34 +53,56 @@ def __init__(self, provider_config: dict, provider_settings: dict) -> None:
         if api_base and not api_base.endswith("/v1") and not api_base.endswith("/v4"):
             # /v4 see #5699
             api_base = api_base + "/v1"
+
         logger.info(f"[OpenAI Embedding] {provider_id} Using API Base: {api_base}")
+
         self.client = AsyncOpenAI(
-            api_key=provider_config.get("embedding_api_key"),
+            api_key=api_key,
             base_url=api_base,
-            timeout=int(provider_config.get("timeout", 20)),
+            timeout=timeout_val,
             http_client=http_client,
         )
         self.model = provider_config.get("embedding_model", "text-embedding-3-small")
 
     async def get_embedding(self, text: str) -> list[float]:
         """获取文本的嵌入"""
+        # 3. 拦截空文本防 400 报错
+        if not text or not text.strip():
+            raise ValueError("输入文本不能为空")
+
         kwargs = self._embedding_kwargs()
-        embedding = await self.client.embeddings.create(
-            input=text,
-            model=self.model,
-            **kwargs,
-        )
-        return embedding.data[0].embedding
+
+        try:
+            embedding = await self.client.embeddings.create(
+                input=text,
+                model=self.model,
+                **kwargs,
+            )
+            return embedding.data[0].embedding
+        except openai.OpenAIError as e:
+            # 4. 包装规范异常
+            raise Exception(f"OpenAI Embedding API 请求失败: {str(e)}") from e
 
     async def get_embeddings(self, text: list[str]) -> list[list[float]]:
         """批量获取文本的嵌入"""
+        # 5. 拦截空列表和内部脏数据
+        if not text:
+            return []
+
+        if any(not s or not s.strip() for s in text):
+            raise ValueError("批量输入文本列表中不能包含空文本")
+
         kwargs = self._embedding_kwargs()
-        embeddings = await self.client.embeddings.create(
-            input=text,
-            model=self.model,
-            **kwargs,
-        )
-        return [item.embedding for item in embeddings.data]
+
+        try:
+            embeddings = await self.client.embeddings.create(
+                input=text,
+                model=self.model,
+                **kwargs,
+            )
+            return [item.embedding for item in embeddings.data]
+        except openai.OpenAIError as e:
+            raise Exception(f"OpenAI Embedding API 批量请求失败: {str(e)}") from e
 
     def _embedding_kwargs(self) -> dict:
         """构建嵌入请求的可选参数"""
@@ -111,5 +151,6 @@ def get_dim(self) -> int:
         return 0
 
     async def terminate(self):
-        if self.client:
+        """释放资源"""
+        if getattr(self, "client", None):
             await self.client.close()