Skip to content

Commit cf9d01f

Browse files
committed
Remove TODO comments
1 parent 305efc5 commit cf9d01f

5 files changed

Lines changed: 1 addition & 10 deletions

File tree

app/controllers/admin/api/buyers_users_controller.rb

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,8 +131,6 @@ def find_user
131131
def user_params
132132
@user_params ||= begin
133133
allowed_attrs = user.defined_fields_names | %i(password password_confirmation)
134-
# TODO: are these parameters needed?
135-
# allowed_attrs |= %i(conditions cas_identifier open_id service_conditions)
136134
flat_params.permit(*allowed_attrs)
137135
end
138136
end

app/controllers/admin/api/users_controller.rb

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -141,8 +141,6 @@ def user_params
141141
@user_params ||= begin
142142
allowed_attrs = user.defined_fields_names | %i(password password_confirmation cas_identifier)
143143
allowed_attrs |= [member_permission_service_ids: [], member_permission_ids: [], allowed_sections: [], allowed_service_ids: []] if (provider_key.present? || current_user.admin?)
144-
# TODO: are these parameters needed?
145-
# allowed_attrs |= %i(conditions open_id service_conditions)
146144
flat_params.permit(*allowed_attrs)
147145
end
148146
end

app/controllers/buyers/users_controller.rb

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,8 +87,6 @@ def user_params
8787
def permitted_user_params
8888
@permitted_user_params ||= begin
8989
allowed_attrs = user.defined_builtin_fields_names | %i(password password_confirmation)
90-
# TODO: are these parameters needed?
91-
# allowed_attrs |= %i(conditions cas_identifier open_id service_conditions)
9290
user_params.permit(*allowed_attrs, extra_fields: user.defined_extra_fields_names)
9391
end
9492
end

app/controllers/provider/admin/user/personal_details_controller.rb

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,6 @@ def user_params
3232
def permitted_user_params
3333
@permitted_user_params ||= begin
3434
allowed_attrs = current_user.defined_builtin_fields_names | %i(password)
35-
# TODO: are these parameters needed?
36-
# allowed_attrs |= %i(conditions cas_identifier open_id service_conditions)
3735
user_params.permit(*allowed_attrs, extra_fields: current_user.defined_extra_fields_names)
3836
end
3937
end

lib/developer_portal/app/controllers/developer_portal/accounts/invitee_signups_controller.rb

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,7 @@ def sso_create
3333
redirect_to strategy.redirect_to_on_successful_login
3434
else
3535
user_data = strategy.user_data || {}
36-
# TODO: verify that this is the right thing to do
37-
user_attributes = user_data.to_hash.compact.slice(:username, :email)
36+
user_attributes = user_data.to_hash.compact.slice(:username, :email, :authentication_id)
3837
@user.assign_attributes(user_attributes)
3938
session[:invitation_sso_uid] = user_data[:uid]
4039
session[:invitation_sso_system_name] = strategy.authentication_provider.system_name

0 commit comments

Comments
 (0)